500 error on generating CSV diffs #7788

New Issue

GiteaMirror · 2025-11-02T07:36:32-06:00

GiteaMirror commented

2025-11-02 07:36:32 -06:00

Originally created by @melmus on GitHub (Sep 2, 2021).

Gitea version (or commit ref): v1.15.0
Git version: 2.30.2
Operating system: Ubuntu 18.04.4 LTS
Gitea running in docker
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
Log gist:

Description

When i create PR in repository, i have 500 error. If i created another branch, and created PR in master branch, everything is fine, but if i see file changed, i have 500 error. This problem i see on one repository.

2021/09/02 12:09:00 ...s/context/context.go:195:HTML() [E] Render failed: template: repo/diff/csv_diff:15:21: executing "repo/diff/csv_diff" at <$cell.Type>: nil pointer evaluating *gitdiff.TableDiffCell.Type

Screenshots

Originally created by @melmus on GitHub (Sep 2, 2021).   - Gitea version (or commit ref): v1.15.0 - Git version: 2.30.2 - Operating system: Ubuntu 18.04.4 LTS Gitea running in docker    - Database (use `[x]`): - [X] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - Log gist:    ## Description  When i create PR in repository, i have 500 error. If i created another branch, and created PR in master branch, everything is fine, but if i see file changed, i have 500 error. This problem i see on one repository. ``` 2021/09/02 12:09:00 ...s/context/context.go:195:HTML() [E] Render failed: template: repo/diff/csv_diff:15:21: executing "repo/diff/csv_diff" at <$cell.Type>: nil pointer evaluating *gitdiff.TableDiffCell.Type ``` ## Screenshots

GiteaMirror added the type/bug issue/duplicate labels 2025-11-02 07:36:32 -06:00

GiteaMirror closed this issue

2025-11-02 07:36:32 -06:00

GiteaMirror commented

2025-11-02 07:36:33 -06:00

@zeripath commented on GitHub (Sep 2, 2021):

It would be helpful if you could upload an example CSV to try.gitea.io.

I think:

diff --git a/templates/repo/diff/csv_diff.tmpl b/templates/repo/diff/csv_diff.tmpl
index b86e9d2a7..b037e29b8 100644
--- a/templates/repo/diff/csv_diff.tmpl
+++ b/templates/repo/diff/csv_diff.tmpl
@@ -12,7 +12,9 @@
 						{{if and (eq $i 0) (eq $j 0)}}
 							<th class="line-num">{{.RowIdx}}</th>
 							{{range $j, $cell := $row.Cells}}
-								{{if eq $cell.Type 2}}
+								{{if not $cell}}
+									<th></th>
+								{{else if eq $cell.Type 2}}
 									<th class="modified"><span class="removed-code">{{.LeftCell}}</span> <span class="added-code">{{.RightCell}}</span></th>
 								{{else if eq $cell.Type 3}}
 									<th class="added"><span class="added-code">{{.LeftCell}}</span></th>
@@ -25,7 +27,9 @@
 						{{else}}
 							<td class="line-num">{{if .RowIdx}}{{.RowIdx}}{{end}}</td>
 							{{range $j, $cell := $row.Cells}}
-								{{if eq $cell.Type 2}}
+								{{if not $cell}}
+									<td></td>
+								{{else if eq $cell.Type 2}}
 									<td class="modified"><span class="removed-code">{{.LeftCell}}</span> <span class="added-code">{{.RightCell}}</span></td>
 								{{else if eq $cell.Type 3}}
 									<td class="added"><span class="added-code">{{.LeftCell}}</span></td>

Would stop the panic but I'm not sure if there is a deeper bug here.

@zeripath commented on GitHub (Sep 2, 2021): It would be helpful if you could upload an example CSV to try.gitea.io. I think: ```patch diff --git a/templates/repo/diff/csv_diff.tmpl b/templates/repo/diff/csv_diff.tmpl index b86e9d2a7..b037e29b8 100644 --- a/templates/repo/diff/csv_diff.tmpl +++ b/templates/repo/diff/csv_diff.tmpl @@ -12,7 +12,9 @@ {{if and (eq $i 0) (eq $j 0)}} <th class="line-num">{{.RowIdx}}</th> {{range $j, $cell := $row.Cells}} - {{if eq $cell.Type 2}} + {{if not $cell}} + <th></th> + {{else if eq $cell.Type 2}} <th class="modified">{{.LeftCell}} {{.RightCell}}</th> {{else if eq $cell.Type 3}} <th class="added">{{.LeftCell}}</th> @@ -25,7 +27,9 @@ {{else}} <td class="line-num">{{if .RowIdx}}{{.RowIdx}}{{end}}</td> {{range $j, $cell := $row.Cells}} - {{if eq $cell.Type 2}} + {{if not $cell}} + <td></td> + {{else if eq $cell.Type 2}} <td class="modified">{{.LeftCell}} {{.RightCell}}</td> {{else if eq $cell.Type 3}} <td class="added">{{.LeftCell}}</td> ``` Would stop the panic but I'm not sure if there is a deeper bug here.

GiteaMirror commented

2025-11-02 07:36:33 -06:00

@zeripath commented on GitHub (Sep 4, 2021):

Duplicate of #16837

@zeripath commented on GitHub (Sep 4, 2021): Duplicate of #16837

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#7788