github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-14 11:56:41 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

agit flow hook refuses forced pushes #7689

New Issue
Closed
opened 2025-11-02 07:33:41 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 07:33:41 -06:00
Owner
Copy Link

Originally created by @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf on GitHub (Aug 12, 2021).

  • Gitea version (or commit ref): Gitea version 1.16.0+dev-96-gf1a810e09 built with GNU Make 4.3, go1.16.7 : netgo, osusergo, bindata, sqlite, sqlite_unlock_notify

  • Git version: 2.33.0.rc0.290.g2c90b51f76

  • Operating system: Arch Linux

  • Built from: source

  • Run with: systemd

  • Database:

    • SQLite

  • Can you reproduce the bug at https://try.gitea.io:

    • I have not tried yet, I don't see why it wouldn't work in a fresh repo like I tried it with...

  • Log gist:

    • TBD

Description

First off, I appreciate this feature (implemented recently in #14295), it is really handy (I didn't know about agit flow before btw).

I have run into an issue when force pushing an update into a PR while doing this agit flow stuff (after initially opening the PR using this method).
The force push was then refused by Gitea (a git hook).
The command used was git push --force HEAD:refs/for/whatever-the-branch-was -o topic=topic-name if I recall correctly.
EDIT: this was a typo here, I meant to say I pushed the HEAD ref, not "HEADS".

Note that

  • branch protection has not been enabled in this particular instance,
  • repo hooks have been reinitialized as per the subject PR request (it was noted somewhere there).

I cannot tell whether that is intended behaviour or not, i.e. whether I even ought to try to force push in agit flow or not.

Originally created by @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf on GitHub (Aug 12, 2021). - Gitea version (or commit ref): `Gitea version 1.16.0+dev-96-gf1a810e09 built with GNU Make 4.3, go1.16.7 : netgo, osusergo, bindata, sqlite, sqlite_unlock_notify` - Git version: `2.33.0.rc0.290.g2c90b51f76` - Operating system: `Arch Linux` - Built from: `source` - Run with: `systemd` - Database: - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] I have not tried yet, I don't see why it wouldn't work in a fresh repo like I tried it with... - Log gist: - [ ] TBD ## Description First off, I appreciate this feature (implemented recently in #14295), it is really handy (I didn't know about agit flow before btw). I have run into an issue when force pushing an update into a PR while doing this agit flow stuff (after initially opening the PR using this method). The force push was then refused by Gitea (a git hook). The command used was `git push --force HEAD:refs/for/whatever-the-branch-was -o topic=topic-name` if I recall correctly. EDIT: this was a typo here, I meant to say I pushed the `HEAD` ref, not "`HEADS`". Note that * branch protection has not been enabled in this particular instance, * repo hooks have been reinitialized as per the subject PR request (it was noted somewhere there). I cannot tell whether that is intended behaviour or not, i.e. whether I even ought to try to force push in agit flow or not.
GiteaMirror added the type/enhancement label 2025-11-02 07:33:41 -06:00
GiteaMirror commented 2025-11-02 07:33:42 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 13, 2021):

@a1012112796 Maybe you can take a look.

@lunny commented on GitHub (Aug 13, 2021): @a1012112796 Maybe you can take a look.
GiteaMirror commented 2025-11-02 07:33:42 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Aug 13, 2021):

I think this is similar to the problem seen here https://github.com/go-gitea/gitea/issues/15373#issuecomment-898729133

I'm suspicious that might be some weird regression or interaction with #15629.

@zeripath commented on GitHub (Aug 13, 2021): I think this is similar to the problem seen here https://github.com/go-gitea/gitea/issues/15373#issuecomment-898729133 I'm suspicious that might be some weird regression or interaction with #15629.
GiteaMirror commented 2025-11-02 07:33:42 -06:00
Author
Owner
Copy Link

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented on GitHub (Aug 13, 2021):

I think this is similar to the problem seen here #15373 (comment)

I'm suspicious that might be some weird regression or interaction with #15629.

oh bugger 🙈

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf commented on GitHub (Aug 13, 2021): > I think this is similar to the problem seen here [#15373 (comment)](https://github.com/go-gitea/gitea/issues/15373#issuecomment-898729133) > > I'm suspicious that might be some weird regression or interaction with #15629. oh bugger 🙈
GiteaMirror commented 2025-11-02 07:33:42 -06:00
Author
Owner
Copy Link

@a1012112796 commented on GitHub (Aug 14, 2021):

Sorry, because can't get --force option in git hook, I use a push option to check if user want to force push
example:

git push -o force-push=true ...

ref：
23a87a003e/services/agit/agit.go (L39)

@a1012112796 commented on GitHub (Aug 14, 2021): Sorry, because can't get ``--force`` option in git hook, I use a push option to check if user want to force push example: ```SHELL git push -o force-push=true ... ``` ref： https://github.com/go-gitea/gitea/blob/23a87a003eb2b592ad5295f73d8d52d3f24069c6/services/agit/agit.go#L39
GiteaMirror commented 2025-11-02 07:33:42 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Aug 14, 2021):

@a1012112796 could you use https://github.com/go-gitea/gitea/blob/main/modules/repository/push.go#L101 to detect it?

@lunny commented on GitHub (Aug 14, 2021): @a1012112796 could you use https://github.com/go-gitea/gitea/blob/main/modules/repository/push.go#L101 to detect it?
GiteaMirror commented 2025-11-02 07:33:43 -06:00
Author
Owner
Copy Link

@a1012112796 commented on GitHub (Aug 14, 2021):

@a1012112796 could you use https://github.com/go-gitea/gitea/blob/main/modules/repository/push.go#L101 to detect it?

They are same, ref:
23a87a003e/services/agit/agit.go (L206-L223)

I means to check if user make sure they want to force push, like the usage of --force.

@a1012112796 commented on GitHub (Aug 14, 2021): > @a1012112796 could you use https://github.com/go-gitea/gitea/blob/main/modules/repository/push.go#L101 to detect it? They are same, ref: https://github.com/go-gitea/gitea/blob/23a87a003eb2b592ad5295f73d8d52d3f24069c6/services/agit/agit.go#L206-L223 I means to check if user make sure they want to force push, like the usage of ``--force``.
GiteaMirror commented 2025-11-02 07:33:43 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Oct 11, 2024):

Fixed by https://gitea.com/gitea/docs/pulls/78

@lunny commented on GitHub (Oct 11, 2024): Fixed by https://gitea.com/gitea/docs/pulls/78
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?