Automatic Review Dismissal Fails To Properly Dismiss Review #7622

New Issue

2025-11-02T07:31:39-06:00

GiteaMirror commented

2025-11-02 07:31:39 -06:00

Originally created by @delvh on GitHub (Jul 24, 2021).

Gitea version (or commit ref): 1.14.4
Can you reproduce the bug at https://try.gitea.io: Don't know, for that I would need at least 2-3 people, but I presume you can

Description

The automatic review dismissal of a PR when new commits are added fails as apparently all it does is clear the approvals already gotten. Previous approvals will however still be displayed as approvals (if that is too confusing, look at the screenshot below to see what I mean)

Screenshots

Names of people not being me were cropped. As you can see, the PR is in the weird state where there are 0 approvals, although I approved a previous state, and it still looks as if I approved the PR.

Originally created by @delvh on GitHub (Jul 24, 2021). - Gitea version (or commit ref): 1.14.4 - Can you reproduce the bug at https://try.gitea.io: Don't know, for that I would need at least 2-3 people, but I presume you can ## Description The automatic review dismissal of a PR when new commits are added fails as apparently all it does is clear the approvals already gotten. Previous approvals will however still be displayed as approvals (if that is too confusing, look at the screenshot below to see what I mean) ## Screenshots ![image](https://user-images.githubusercontent.com/51889757/126866989-618d02a4-cb27-412f-9552-aebe17dcb564.png) Names of people not being me were cropped. As you can see, the PR is in the weird state where there are 0 approvals, although I approved a previous state, and it still looks as if I approved the PR.

GiteaMirror added the type/bug label 2025-11-02 07:31:39 -06:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#7622