github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-14 20:07:40 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

pull request merged / closed webhook contains empty body #7392

New Issue
Closed
opened 2025-11-02 07:24:43 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-02 07:24:43 -06:00
Owner
Copy Link

Originally created by @jpraet on GitHub (May 27, 2021).

The body is empty in the webhook payload for pull request merged / closed events.

This is causing a problem with the redmine_merge_request_links plugin: https://github.com/tf/redmine_merge_request_links/issues/27

At first I thought that this behavior maybe was intentional, but looking at the code, I don't think it is:

c61b460038/modules/notification/mail/mail.go (L127)

The pr.Issue.Content is emptied in the e-mail notification code, and as a side-effect the issue content is also empty for notifiers that are called afterwards (indexer, webhook and action).

Such unexpected manipulations of the notification input also happens here:

c61b460038/modules/notification/mail/mail.go (L57)

c61b460038/modules/notification/mail/mail.go (L154)

Originally created by @jpraet on GitHub (May 27, 2021). The body is empty in the webhook payload for pull request merged / closed events. This is causing a problem with the redmine_merge_request_links plugin: https://github.com/tf/redmine_merge_request_links/issues/27 At first I thought that this behavior maybe was intentional, but looking at the code, I don't think it is: https://github.com/go-gitea/gitea/blob/c61b460038d461ae4df722b28fd0b9871393ea84/modules/notification/mail/mail.go#L127 The pr.Issue.Content is emptied in the e-mail notification code, and as a side-effect the issue content is also empty for notifiers that are called afterwards (indexer, webhook and action). Such unexpected manipulations of the notification input also happens here: https://github.com/go-gitea/gitea/blob/c61b460038d461ae4df722b28fd0b9871393ea84/modules/notification/mail/mail.go#L57 https://github.com/go-gitea/gitea/blob/c61b460038d461ae4df722b28fd0b9871393ea84/modules/notification/mail/mail.go#L154
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7392
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?