mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-21 04:02:17 -05:00
[Docs] Instructions for logrotate need attention #7328
Closed
opened 2025-11-02 07:23:03 -06:00 by GiteaMirror
·
9 comments
No Branch/Tag Specified
main
release/v1.25
release/v1.24
release/v1.23
release/v1.22
release/v1.21
release/v1.20
release/v1.19
release/v1.18
release/v1.17
release/v1.16
release/v1.15
release/v1.14
release/v1.13
release/v1.12
release/v1.11
release/v1.10
release/v1.9
release/v1.8
v1.25.3
v1.25.2
v1.25.1
v1.25.0
v1.24.7
v1.25.0-rc0
v1.26.0-dev
v1.24.6
v1.24.5
v1.24.4
v1.24.3
v1.24.2
v1.24.1
v1.24.0
v1.23.8
v1.24.0-rc0
v1.25.0-dev
v1.23.7
v1.23.6
v1.23.5
v1.23.4
v1.23.3
v1.23.2
v1.23.1
v1.23.0
v1.23.0-rc0
v1.24.0-dev
v1.22.6
v1.22.5
v1.22.4
v1.22.3
v1.22.2
v1.22.1
v1.22.0
v1.23.0-dev
v1.22.0-rc1
v1.21.11
v1.22.0-rc0
v1.21.10
v1.21.9
v1.21.8
v1.21.7
v1.21.6
v1.21.5
v1.21.4
v1.21.3
v1.21.2
v1.20.6
v1.21.1
v1.21.0
v1.21.0-rc2
v1.21.0-rc1
v1.20.5
v1.22.0-dev
v1.21.0-rc0
v1.20.4
v1.20.3
v1.20.2
v1.20.1
v1.20.0
v1.19.4
v1.21.0-dev
v1.20.0-rc2
v1.20.0-rc1
v1.20.0-rc0
v1.19.3
v1.19.2
v1.19.1
v1.19.0
v1.19.0-rc1
v1.20.0-dev
v1.19.0-rc0
v1.18.5
v1.18.4
v1.18.3
v1.18.2
v1.18.1
v1.18.0
v1.17.4
v1.18.0-rc1
v1.19.0-dev
v1.18.0-rc0
v1.17.3
v1.17.2
v1.17.1
v1.17.0
v1.17.0-rc2
v1.16.9
v1.17.0-rc1
v1.18.0-dev
v1.16.8
v1.16.7
v1.16.6
v1.16.5
v1.16.4
v1.16.3
v1.16.2
v1.16.1
v1.16.0
v1.15.11
v1.17.0-dev
v1.16.0-rc1
v1.15.10
v1.15.9
v1.15.8
v1.15.7
v1.15.6
v1.15.5
v1.15.4
v1.15.3
v1.15.2
v1.15.1
v1.14.7
v1.15.0
v1.15.0-rc3
v1.14.6
v1.15.0-rc2
v1.14.5
v1.16.0-dev
v1.15.0-rc1
v1.14.4
v1.14.3
v1.14.2
v1.14.1
v1.14.0
v1.13.7
v1.14.0-rc2
v1.13.6
v1.13.5
v1.14.0-rc1
v1.15.0-dev
v1.13.4
v1.13.3
v1.13.2
v1.13.1
v1.13.0
v1.12.6
v1.13.0-rc2
v1.14.0-dev
v1.13.0-rc1
v1.12.5
v1.12.4
v1.12.3
v1.12.2
v1.12.1
v1.11.8
v1.12.0
v1.11.7
v1.12.0-rc2
v1.11.6
v1.12.0-rc1
v1.13.0-dev
v1.11.5
v1.11.4
v1.11.3
v1.10.6
v1.12.0-dev
v1.11.2
v1.10.5
v1.11.1
v1.10.4
v1.11.0
v1.11.0-rc2
v1.10.3
v1.11.0-rc1
v1.10.2
v1.10.1
v1.10.0
v1.9.6
v1.9.5
v1.10.0-rc2
v1.11.0-dev
v1.10.0-rc1
v1.9.4
v1.9.3
v1.9.2
v1.9.1
v1.9.0
v1.9.0-rc2
v1.10.0-dev
v1.9.0-rc1
v1.8.3
v1.8.2
v1.8.1
v1.8.0
v1.8.0-rc3
v1.7.6
v1.8.0-rc2
v1.7.5
v1.8.0-rc1
v1.9.0-dev
v1.7.4
v1.7.3
v1.7.2
v1.7.1
v1.7.0
v1.7.0-rc3
v1.6.4
v1.7.0-rc2
v1.6.3
v1.7.0-rc1
v1.7.0-dev
v1.6.2
v1.6.1
v1.6.0
v1.6.0-rc2
v1.5.3
v1.6.0-rc1
v1.6.0-dev
v1.5.2
v1.5.1
v1.5.0
v1.5.0-rc2
v1.5.0-rc1
v1.5.0-dev
v1.4.3
v1.4.2
v1.4.1
v1.4.0
v1.4.0-rc3
v1.4.0-rc2
v1.3.3
v1.4.0-rc1
v1.3.2
v1.3.1
v1.3.0
v1.3.0-rc2
v1.3.0-rc1
v1.2.3
v1.2.2
v1.2.1
v1.2.0
v1.2.0-rc3
v1.2.0-rc2
v1.1.4
v1.2.0-rc1
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.2
v1.0.1
v1.0.0
v0.9.99
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
Mirrored from GitHub Pull Request
No labels
type/docs
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/gitea#7328
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Originally created by @lonix1 on GitHub (May 12, 2021).
[x]):n/a
Description
I want to do custom log rotation using logrotate.
Original issue: #9960
Implemented in PR: #11777
Docs: link
Docs say to send
kill -USR1to process that represents gitea container; but for that doesn't work for me. The logger continues to log togitea.log.1(instead ofgitea.log).Alternative is to do:
docker exec gitea_container_name gitea manager logging release-and-reopen, but I get:As I posted before, what works is this:
When using s6 that is the proper way to signal the process. It matches the startup of the container as well, see here.
I don't understand how this works for other people. I think the docs are wrong, and the approach I used above should be used as "correct", or at least as another alternative.
@zeripath commented on GitHub (May 12, 2021):
docker exec -u git gitea_container_name gitea manager logging release-and-reopen
@lonix1 commented on GitHub (May 13, 2021):
Thanks for that. If so it should be added to that docs section, would help others.
My way is foolproof when using s6, but relying on the app to reload its logs is probably the best way, I agree with you. It's a nice feature.
@zeripath commented on GitHub (May 13, 2021):
Where did you find the instruction to
docker exec gitea manager logging release-and-reopen? I only seegitea manager logging release-and-reopenin the docs.@lonix1 commented on GitHub (May 13, 2021):
Exactly, I didn't - I figured that out myself, but forgot about the
-u gitwhich you gave me above. (Thanks again!)So like I said those docs need some attention.
I think all three options are good, but your way is best. So in
postrotate .. endscript, use:docker exec -u git gitea_container_name sh -c 'gitea manager logging release-and-reopen'BESTdocker exec gitea_container_name sh -c '/bin/s6-svc -1 /etc/s6/gitea/relies on s6 (foolproof way used in most cases, but in this case we have a built-in way which is better)kill -USR1 $(docker inspect --format '{{.State.Pid}}' "$gitea_container_name")signal process directly@zeripath commented on GitHub (May 13, 2021):
I don't think the logging documentation is wrong - it's just not covering this usecase. It was never intended to provide information on how to run the command from outside of the container. I've added a PR to add your commands to the documentation though.
@lonix1 commented on GitHub (May 13, 2021):
Thanks!
I'm a little confused though - isn't it normal to run it from the host (rather than the container)? One would expose the log file to the host (via a file volume, e.g.
/var/log/gitea/gitea.log:/data/gitea/log/gitea.log), and rely on the host's logrotate to do the rotation. Then all the host's apps can be funneled into a log reporting tool.I'm genuinely curious - how do you/others do it? And why would one perform log rotation inside the container?
@zeripath commented on GitHub (May 13, 2021):
Not everyone uses docker and it was assumed that any docker user who wanted to use this more advanced functionality would understand how to run it.
As we provide docker builds its not entirely unreasonable to provide information on how docker users could run things though - hence the PR.
@lonix1 commented on GitHub (May 13, 2021):
LOL... I forgot that not everyone uses docker! 😄
Should we close this issue now?
PS thanks for all the work you do on gitea, it's really great!
@zeripath commented on GitHub (May 13, 2021):
the PR will close it when it's merged. So it's fine to leave it open.