[Bug] Deleting text disables recommendations #7326

Closed
opened 2025-11-02 07:23:01 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @delvh on GitHub (May 11, 2021).

  • Gitea version (or commit ref): 1.15.0+dev-274-g143071ee4 and every single one below
  • Can you reproduce the bug at https://try.gitea.io: Yes

Description

When a user enters text that requests recommendations (either the emoji :, the user mentioning @ or maybe later on the issue linking # syntax), recommendations will not get updated after text has been deleted from the input (i.e. removing the e from :smile ). This means the recommendations popup will be frozen in place, not changing for any input.
There are currently two ways to force the menu to close:
A) The textarea loses focus
B) Every part of the recommendation requesting input gets deleted (i.e. even the : of :smile)

It would be nice if the recommendations would also get updated when text is deleted and afterwards.

Screenshots

Screenshot_20210511_235746
In this screenshot, I entered :smile, then replaced it with :build. As you can see, the menu did not get updated and is now frozen.

Originally created by @delvh on GitHub (May 11, 2021). - Gitea version (or commit ref): 1.15.0+dev-274-g143071ee4 and every single one below - Can you reproduce the bug at https://try.gitea.io: Yes ## Description When a user enters text that requests recommendations (either the emoji `:`, the user mentioning `@` or maybe later on the issue linking `#` syntax), recommendations will not get updated after text has been deleted from the input (i.e. removing the `e` from `:smile` ). This means the recommendations popup will be frozen in place, not changing for any input. There are currently two ways to force the menu to close: A) The textarea loses focus B) Every part of the recommendation requesting input gets deleted (i.e. even the `:` of `:smile`) It would be nice if the recommendations would also get updated when text is deleted and afterwards. ## Screenshots ![Screenshot_20210511_235746](https://user-images.githubusercontent.com/51889757/117890058-c8580080-b2b4-11eb-95b1-6dc1b05903aa.png) In this screenshot, I entered `:smile`, then replaced it with `:build`. As you can see, the menu did not get updated and is now frozen.
GiteaMirror added the outdated/theme/markdowntopic/ui-interactiontype/bug labels 2025-11-02 07:23:01 -06:00
Author
Owner

@wxiaoguang commented on GitHub (Apr 12, 2023):

Resolved by https://github.com/go-gitea/gitea/pull/23985 ?

@wxiaoguang commented on GitHub (Apr 12, 2023): Resolved by https://github.com/go-gitea/gitea/pull/23985 ?
Author
Owner

@delvh commented on GitHub (Apr 12, 2023):

Yup.
Finally. I had a feeling when reviewing that PR that I missed an issue that is fixed by it 😃

@delvh commented on GitHub (Apr 12, 2023): Yup. Finally. I had a feeling when reviewing that PR that I missed an issue that is fixed by it :smiley:
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7326