Since Chi migration html rendering is essentially single threaded due to unrolled #7325

Closed
opened 2025-11-02 07:23:00 -06:00 by GiteaMirror · 2 comments
Owner

Originally created by @zeripath on GitHub (May 11, 2021).

There is a global lock in unrolled.render.HTML:

https://github.com/unrolled/render/blob/b7951a4bb643b89b5e45e179cee661139809c294/render.go#L392

Anything that holds up Rendering just blocks it for everyone and we essentially can only render one html template at a time.

Originally posted by @zeripath in https://github.com/go-gitea/gitea/issues/15826#issuecomment-837359192

Originally created by @zeripath on GitHub (May 11, 2021). There is a global lock in unrolled.render.HTML: https://github.com/unrolled/render/blob/b7951a4bb643b89b5e45e179cee661139809c294/render.go#L392 Anything that holds up Rendering just blocks it for everyone and we essentially can only render one html template at a time. _Originally posted by @zeripath in https://github.com/go-gitea/gitea/issues/15826#issuecomment-837359192_
GiteaMirror added the issue/critical label 2025-11-02 07:23:00 -06:00
Author
Owner

@zeripath commented on GitHub (May 11, 2021):

See: https://github.com/unrolled/render/pull/90

@zeripath commented on GitHub (May 11, 2021): See: https://github.com/unrolled/render/pull/90
Author
Owner

@zeripath commented on GitHub (May 12, 2021):

Fixed by #15845

@zeripath commented on GitHub (May 12, 2021): Fixed by #15845
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7325