Docs: Potential color theme tweaks #7287

@zeripath commented on GitHub (May 3, 2021):

Whilst I agree that the red colour at present is a bit glaring I think your change is too dark. Have you tried a dark burgundy?

@zeripath commented on GitHub (May 3, 2021): Whilst I agree that the red colour at present is a bit glaring I think your change is too dark. Have you tried a dark burgundy?

GiteaMirror commented

@silverwind commented on GitHub (May 3, 2021):

Looking good. As for green, I suggest #609926 which is also used in the gitea logo.

@silverwind commented on GitHub (May 3, 2021): Looking good. As for green, I suggest `#609926` which is also used in the gitea logo.

GiteaMirror commented

@silverwind commented on GitHub (May 3, 2021):

#148f77 on #ffffff is 4.01:1 contrast ratio (current)
#609926 on #ffffff is 3.45:1 contrast ratio
#2ea44f on #ffffff is 3.21:1 contrast ratio

Both new colors fail the WCAG AA requirement, to pass that it'd have to be at least 4.5 ratio, for example #528321.

@silverwind commented on GitHub (May 3, 2021): `#148f77` on `#ffffff` is 4.01:1 contrast ratio (current) `#609926` on `#ffffff` is 3.45:1 contrast ratio `#2ea44f` on `#ffffff` is 3.21:1 contrast ratio Both new colors fail the [WCAG AA requirement](https://webaim.org/resources/contrastchecker/), to pass that it'd have to be at least 4.5 ratio, for example `#528321`.

GiteaMirror commented

@pat-s commented on GitHub (May 4, 2021):

Ok, here's the next try

code {
    background-color: #ecf0f1;
    color: black;
    font-size: 0.85em;
    font-weight: normal;
    padding: .2em .4em;
    border-radius: 6px;
}

Also the body font is black here and the background #ecf0f1.

The green tone is #528321.

@pat-s commented on GitHub (May 4, 2021): Ok, here's the next try ```css code { background-color: #ecf0f1; color: black; font-size: 0.85em; font-weight: normal; padding: .2em .4em; border-radius: 6px; } ``` Also the body font is `black` here and the background `#ecf0f1`. The green tone is `#528321`. ![image](https://user-images.githubusercontent.com/8430564/117013095-d70c4980-acef-11eb-919a-cc3211eb970b.png)

GiteaMirror commented

@silverwind commented on GitHub (May 4, 2021):

I like it except the blueish header which seems a bit out of place but I see that color is also used on the frontpage, so it's a more involved change. Also, I would not use black body text because it seems to harsh of a color against white, maybe #333 instead.

@silverwind commented on GitHub (May 4, 2021): I like it except the blueish header which seems a bit out of place but I see that color is also used on the frontpage, so it's a more involved change. Also, I would not use `black` body text because it seems to harsh of a color against white, maybe `#333` instead.

GiteaMirror commented

@pat-s commented on GitHub (May 6, 2021):

I also do not like the blue. I could think of a general recoloring using a greyish tone and #528321 (maybe the green tone of the gitea logo to stay consistent).

Main page

Navbar background: #f4f4f4

Docs

With #333 as the body font and #f8f8f8 as the navbar background.

@pat-s commented on GitHub (May 6, 2021): I also do not like the blue. I could think of a general recoloring using a greyish tone and `#528321` (maybe the green tone of the gitea logo to stay consistent). ## Main page Navbar background: `#f4f4f4` ![image](https://user-images.githubusercontent.com/8430564/117252589-7b080900-ae46-11eb-97e5-8c8762d968de.png) ## Docs With `#333` as the body font and `#f8f8f8` as the navbar background. ![image](https://user-images.githubusercontent.com/8430564/117253122-26b15900-ae47-11eb-95dd-c89c18b5a0fd.png)

GiteaMirror commented

@silverwind commented on GitHub (May 16, 2021):

Looks great imho :)

@silverwind commented on GitHub (May 16, 2021): Looks great imho :)

GiteaMirror commented

@6543 commented on GitHub (Aug 1, 2021):

did you update the issue description screenshots with the current look @pat-s ?

@6543 commented on GitHub (Aug 1, 2021): did you update the issue description screenshots with the current look @pat-s ?

GiteaMirror commented

@pat-s commented on GitHub (Aug 1, 2021):

No, the current looks can be seen in the last comment which contains screenshots. Otherwise some comments would not make sense anymore which refer to the first proposals.

@pat-s commented on GitHub (Aug 1, 2021): No, the current looks can be seen in the last comment which contains screenshots. Otherwise some comments would not make sense anymore which refer to the first proposals.

GiteaMirror commented

@6543 commented on GitHub (Aug 1, 2021):

will update it then :)

@6543 commented on GitHub (Aug 1, 2021): will update it then :)

GiteaMirror commented

@6543 commented on GitHub (Aug 1, 2021):

@silverwind will need review at https://gitea.com/gitea/theme/pulls/95 :)

@6543 commented on GitHub (Aug 1, 2021): @silverwind will need review at https://gitea.com/gitea/theme/pulls/95 :)

GiteaMirror commented

@silverwind commented on GitHub (Aug 5, 2021):

PR is merged, but it does not seem to be live yet.

@silverwind commented on GitHub (Aug 5, 2021): PR is merged, but it does not seem to be live yet.

GiteaMirror commented

@techknowlogick commented on GitHub (Aug 5, 2021):

@silverwind that's my bad, I hadn't updated CI secrets so it didn't publish. I've resolved that and next PR merged to this repo will update theme.

@techknowlogick commented on GitHub (Aug 5, 2021): @silverwind that's my bad, I hadn't updated CI secrets so it didn't publish. I've resolved that and next PR merged to this repo will update theme.

GiteaMirror commented

@pat-s commented on GitHub (Aug 5, 2021):

Thanks!

I was expecting the theme change to apply to all sites, albeit only the docs were updated. Might need to look again.

@pat-s commented on GitHub (Aug 5, 2021): Thanks! I was expecting the theme change to apply to all sites, albeit only the docs were updated. Might need to look again.

GiteaMirror commented