Pull request #947 / #1753 (still) breaks HTTPS clone/push/pull to/from "master" when logged in as Admin #725

New Issue

GiteaMirror · 2025-11-02T03:34:13-06:00

GiteaMirror commented

2025-11-02 03:34:13 -06:00

Originally created by @wyattoday on GitHub (May 19, 2017).

Gitea version (or commit ref): 281a0389c1 or https://github.com/go-gitea/gitea/pull/1753
Git version: 2.13
Operating system: Ubuntu 16.04
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist:

Description

This is a followup to the issue that was closed (but not fixed): https://github.com/go-gitea/gitea/issues/1751

The proposed fix still breaks things (or leaves things broken). For example, as an admin user, when cloning an existing repository, I get an empty directory:

git.exe clone --progress -v "https://example.com/git/repository_name.git" "C:\Users\USERNAME\Documents\repository_name"

Cloning into 'C:\Users\USERNAME\Documents\repository_name'...
warning: You appear to have cloned an empty repository.

Success (641 ms @ 5/19/2017 8:08:51 AM)

Other things are broken as well (pulling still broken, haven't tried pushing yet).

Rolling back to before fd6034aaf2 fixes things for me.

Screenshots

If this issue involves the Web Interface, please include a screenshot

Originally created by @wyattoday on GitHub (May 19, 2017). - Gitea version (or commit ref): https://github.com/go-gitea/gitea/commit/281a0389c10b95a48045ebb161ad5492226bad78 or https://github.com/go-gitea/gitea/pull/1753 - Git version: 2.13 - Operating system: Ubuntu 16.04 - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description This is a followup to the issue that was closed (but not fixed): https://github.com/go-gitea/gitea/issues/1751 The proposed fix still breaks things (or leaves things broken). For example, as an admin user, when cloning an existing repository, I get an empty directory: ``` git.exe clone --progress -v "https://example.com/git/repository_name.git" "C:\Users\USERNAME\Documents\repository_name" Cloning into 'C:\Users\USERNAME\Documents\repository_name'... warning: You appear to have cloned an empty repository. Success (641 ms @ 5/19/2017 8:08:51 AM) ``` Other things are broken as well (pulling still broken, haven't tried pushing yet). Rolling back to before https://github.com/go-gitea/gitea/commit/fd6034aaf23af1ce03bcba0babcbe7675ce093ee fixes things for me. ## Screenshots **If this issue involves the Web Interface, please include a screenshot**

GiteaMirror added the type/bug label 2025-11-02 03:34:13 -06:00

GiteaMirror closed this issue

2025-11-02 03:34:13 -06:00

GiteaMirror commented

2025-11-02 03:34:14 -06:00

@sapk commented on GitHub (May 19, 2017):

cc @lunny maybe we should add integration test to validate action as an admin in a other PR.

@sapk commented on GitHub (May 19, 2017): cc @lunny maybe we should add integration test to validate action as an admin in a other PR.

GiteaMirror commented

2025-11-02 03:34:14 -06:00

@lunny commented on GitHub (May 19, 2017):

@sapk you are right! I remember I have sent a PR to add clone test, but not merged?