UI language setting problems #7244

New Issue

GiteaMirror · 2025-11-02T07:20:41-06:00

GiteaMirror commented

2025-11-02 07:20:41 -06:00

Originally created by @X-Lucifer on GitHub (Apr 25, 2021).

Gitea version (or commit ref): 1.14.1
Git version: 2.31.1
Operating system: Windows 10
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
Log gist:

Description

I used the Microsoft Edge browser and set the UI language to English, but after logging in again, it changed to Chinese by default.

Screenshots

Originally created by @X-Lucifer on GitHub (Apr 25, 2021).   - Gitea version (or commit ref): 1.14.1 - Git version: 2.31.1 - Operating system: Windows 10    - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [x] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No - Log gist:    ## Description  I used the Microsoft Edge browser and set the UI language to English, but after logging in again, it changed to Chinese by default. ## Screenshots  ![屏幕截图 2021-04-25 111115](https://user-images.githubusercontent.com/11420730/115979173-fb14b000-a5b6-11eb-92a3-b08d5702cbf5.png)

GiteaMirror added the topic/ui issue/confirmed labels 2025-11-02 07:20:41 -06:00

GiteaMirror closed this issue

2025-11-02 07:20:41 -06:00

GiteaMirror commented

2025-11-02 07:20:42 -06:00

@r10r commented on GitHub (Nov 17, 2021):

Hi there,

I can confirm this issue in the following clients in Gitea Version: 1.15.6

Safari on macOS 11.6
Edge on Windows 10

Steps to Reproduce

Set a language different from the browser language in Settings->Profile->Language and save the changes. The UI language is changed.
Logout from gitea
Login to gitea
The UI uses browser language which is different from the Settings->Profile->Language.

@r10r commented on GitHub (Nov 17, 2021): Hi there, I can confirm this issue in the following clients in **Gitea Version: 1.15.6** * Safari on macOS 11.6 * Edge on Windows 10 **Steps to Reproduce** 1. Set a language different from the browser language in `Settings->Profile->Language` and save the changes. The UI language is changed. 2. Logout from gitea 3. Login to gitea 4. The UI uses browser language which is different from the `Settings->Profile->Language`.

GiteaMirror commented

2025-11-02 07:20:42 -06:00

@wxiaoguang commented on GitHub (Nov 17, 2021):

Oh yes, I also meet the similar problem. The UI language sometimes differs from the language setting.

@wxiaoguang commented on GitHub (Nov 17, 2021): Oh yes, I also meet the similar problem. The UI language sometimes differs from the language setting.

GiteaMirror commented

2025-11-02 07:20:43 -06:00

@zeripath commented on GitHub (Nov 17, 2021):

I think this:

diff --git a/modules/context/api.go b/modules/context/api.go
index c978835af..e25318940 100644
--- a/modules/context/api.go
+++ b/modules/context/api.go
@@ -245,6 +245,9 @@ func APIAuth(authMethod auth.Method) func(*APIContext) {
 		// Get user from session if logged in.
 		ctx.User = authMethod.Verify(ctx.Req, ctx.Resp, ctx, ctx.Session)
 		if ctx.User != nil {
+			if ctx.Locale.Language() != ctx.User.Language {
+				ctx.Locale = middleware.Locale(ctx.Resp, ctx.Req)
+			}
 			ctx.IsBasicAuth = ctx.Data["AuthedMethod"].(string) == new(auth.Basic).Name()
 			ctx.IsSigned = true
 			ctx.Data["IsSigned"] = ctx.IsSigned
diff --git a/modules/context/context.go b/modules/context/context.go
index 8adf1f306..a405f93d1 100644
--- a/modules/context/context.go
+++ b/modules/context/context.go
@@ -614,6 +614,9 @@ func Auth(authMethod auth.Method) func(*Context) {
 	return func(ctx *Context) {
 		ctx.User = authMethod.Verify(ctx.Req, ctx.Resp, ctx, ctx.Session)
 		if ctx.User != nil {
+			if ctx.Locale.Language() != ctx.User.Language {
+				ctx.Locale = middleware.Locale(ctx.Resp, ctx.Req)
+			}
 			ctx.IsBasicAuth = ctx.Data["AuthedMethod"].(string) == new(auth.Basic).Name()
 			ctx.IsSigned = true
 			ctx.Data["IsSigned"] = ctx.IsSigned
diff --git a/routers/web/user/auth.go b/routers/web/user/auth.go
index ba37c8e3e..1b1c70c8f 100644
--- a/routers/web/user/auth.go
+++ b/routers/web/user/auth.go
@@ -572,6 +572,10 @@ func handleSignInFull(ctx *context.Context, u *models.User, remember bool, obeyR
 
 	middleware.SetLocaleCookie(ctx.Resp, u.Language, 0)
 
+	if ctx.Locale.Language() != u.Language {
+		ctx.Locale = middleware.Locale(ctx.Resp, ctx.Req)
+	}
+
 	// Clear whatever CSRF has right now, force to generate a new one
 	middleware.DeleteCSRFCookie(ctx.Resp)

would solve the issue.

It would be useful if you could test this patch.

@zeripath commented on GitHub (Nov 17, 2021): I think this: ```patch diff --git a/modules/context/api.go b/modules/context/api.go index c978835af..e25318940 100644 --- a/modules/context/api.go +++ b/modules/context/api.go @@ -245,6 +245,9 @@ func APIAuth(authMethod auth.Method) func(*APIContext) { // Get user from session if logged in. ctx.User = authMethod.Verify(ctx.Req, ctx.Resp, ctx, ctx.Session) if ctx.User != nil { + if ctx.Locale.Language() != ctx.User.Language { + ctx.Locale = middleware.Locale(ctx.Resp, ctx.Req) + } ctx.IsBasicAuth = ctx.Data["AuthedMethod"].(string) == new(auth.Basic).Name() ctx.IsSigned = true ctx.Data["IsSigned"] = ctx.IsSigned diff --git a/modules/context/context.go b/modules/context/context.go index 8adf1f306..a405f93d1 100644 --- a/modules/context/context.go +++ b/modules/context/context.go @@ -614,6 +614,9 @@ func Auth(authMethod auth.Method) func(*Context) { return func(ctx *Context) { ctx.User = authMethod.Verify(ctx.Req, ctx.Resp, ctx, ctx.Session) if ctx.User != nil { + if ctx.Locale.Language() != ctx.User.Language { + ctx.Locale = middleware.Locale(ctx.Resp, ctx.Req) + } ctx.IsBasicAuth = ctx.Data["AuthedMethod"].(string) == new(auth.Basic).Name() ctx.IsSigned = true ctx.Data["IsSigned"] = ctx.IsSigned diff --git a/routers/web/user/auth.go b/routers/web/user/auth.go index ba37c8e3e..1b1c70c8f 100644 --- a/routers/web/user/auth.go +++ b/routers/web/user/auth.go @@ -572,6 +572,10 @@ func handleSignInFull(ctx *context.Context, u *models.User, remember bool, obeyR middleware.SetLocaleCookie(ctx.Resp, u.Language, 0) + if ctx.Locale.Language() != u.Language { + ctx.Locale = middleware.Locale(ctx.Resp, ctx.Req) + } + // Clear whatever CSRF has right now, force to generate a new one middleware.DeleteCSRFCookie(ctx.Resp) ``` would solve the issue. It would be useful if you could test this patch.

GiteaMirror commented

2025-11-02 07:20:43 -06:00

@r10r commented on GitHub (Nov 17, 2021):

I'll try to test it on top of 1.15.6

@r10r commented on GitHub (Nov 17, 2021): I'll try to test it on top of 1.15.6

GiteaMirror commented

2025-11-02 07:20:43 -06:00

@r10r commented on GitHub (Nov 19, 2021):

Works! Thanks @zeripath!

Tested with

Safari on macOS 11.6
Firefox on Windows 10

Will this be added to the 1.15.7 ?

@r10r commented on GitHub (Nov 19, 2021): Works! Thanks @zeripath! Tested with * Safari on macOS 11.6 * Firefox on Windows 10 Will this be added to the 1.15.7 ?

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#7244