github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-05-23 15:57:22 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[bug] uters/routes/base.go:153:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference #7219

New Issue
Closed
opened 2025-11-02 07:19:58 -06:00 by GiteaMirror · 10 comments
GiteaMirror commented 2025-11-02 07:19:58 -06:00
Owner
Copy Link

Originally created by @eveslage on GitHub (Apr 20, 2021).

  • Gitea version (or commit ref): 1.14.1
  • Git version: 2.29.2
  • Operating system:
    debian buster
  • Database (use [x]):
    • MySQL
  • Can you reproduce the bug at https://try.gitea.io:
    • No
  • Log gist:
    2021/04/20 18:15:28 ...uters/routes/base.go:153:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference
    /usr/local/go/src/runtime/panic.go:212 (0x43de1a)
    /usr/local/go/src/runtime/signal_unix.go:734 (0x457b72)
    /source/models/user.go:1465 (0x1506c66)
    /source/routers/repo/commit.go:362 (0x2084bb5)
    /source/modules/web/route.go:53 (0x1f7de6b)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b3720a)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/modules/web/route.go:92 (0x1f7e3d6)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/modules/web/route.go:92 (0x1f7e3d6)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/modules/web/route.go:92 (0x1f7e3d6)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x21ad921)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/modules/context/context.go:704 (0x1b563a1)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/routers/routes/base.go:94 (0x21b4d21)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/routers/routes/base.go:94 (0x21b4d21)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/modules/public/public.go:86 (0x13f4947)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/modules/public/public.go:86 (0x13f4947)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/routers/routes/base.go:199 (0x21b6910)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/gitea.com/go-chi/session/session.go:256 (0x154682e)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/go-chi/chi/mux.go:70 (0x1b34d6a)
    /source/vendor/github.com/go-chi/chi/mux.go:311 (0x1b3b15b)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b3720a)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/routers/routes/web.go:110 (0x21b7d5d)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/routers/routes/base.go:38 (0x21b399b)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x21ae227)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x21a988e)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/routers/routes/web.go:66 (0x21b789c)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /source/vendor/github.com/go-chi/chi/mux.go:87 (0x1b34af0)
    /source/modules/web/route.go:268 (0x1f7d3b3)
    /source/vendor/github.com/gorilla/context/context.go:141 (0x11b4b53)
    /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3)
    /usr/local/go/src/net/http/server.go:2887 (0x7c0682)
    /usr/local/go/src/net/http/server.go:1952 (0x7bbbac)
    /usr/local/go/src/runtime/asm_amd64.s:1371 (0x47a4e0)

Description

getting a 500 error when opening a commit of a fairly large repo

git gc, git fsck all done, no issues detected

Originally created by @eveslage on GitHub (Apr 20, 2021). - Gitea version (or commit ref): 1.14.1 - Git version: 2.29.2 - Operating system: debian buster - Database (use `[x]`): - [x] MySQL - Can you reproduce the bug at https://try.gitea.io: - [x] No - Log gist: 2021/04/20 18:15:28 ...uters/routes/base.go:153:1() [E] PANIC: runtime error: invalid memory address or nil pointer dereference /usr/local/go/src/runtime/panic.go:212 (0x43de1a) /usr/local/go/src/runtime/signal_unix.go:734 (0x457b72) /source/models/user.go:1465 (0x1506c66) /source/routers/repo/commit.go:362 (0x2084bb5) /source/modules/web/route.go:53 (0x1f7de6b) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b3720a) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/modules/web/route.go:92 (0x1f7e3d6) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/modules/web/route.go:92 (0x1f7e3d6) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/modules/web/route.go:92 (0x1f7e3d6) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x21ad921) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/modules/context/context.go:704 (0x1b563a1) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/routers/routes/base.go:94 (0x21b4d21) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/routers/routes/base.go:94 (0x21b4d21) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/modules/public/public.go:86 (0x13f4947) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/modules/public/public.go:86 (0x13f4947) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/routers/routes/base.go:199 (0x21b6910) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/gitea.com/go-chi/session/session.go:256 (0x154682e) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/go-chi/chi/mux.go:70 (0x1b34d6a) /source/vendor/github.com/go-chi/chi/mux.go:311 (0x1b3b15b) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/go-chi/chi/mux.go:436 (0x1b3720a) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/routers/routes/web.go:110 (0x21b7d5d) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/routers/routes/base.go:38 (0x21b399b) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x21ae227) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x21a988e) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/routers/routes/web.go:66 (0x21b789c) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /source/vendor/github.com/go-chi/chi/mux.go:87 (0x1b34af0) /source/modules/web/route.go:268 (0x1f7d3b3) /source/vendor/github.com/gorilla/context/context.go:141 (0x11b4b53) /usr/local/go/src/net/http/server.go:2069 (0x7bd0c3) /usr/local/go/src/net/http/server.go:2887 (0x7c0682) /usr/local/go/src/net/http/server.go:1952 (0x7bbbac) /usr/local/go/src/runtime/asm_amd64.s:1371 (0x47a4e0) ## Description getting a 500 error when opening a commit of a fairly large repo git gc, git fsck all done, no issues detected
GiteaMirror added the type/bug label 2025-11-02 07:19:58 -06:00
GiteaMirror commented 2025-11-02 07:20:00 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Apr 20, 2021):

The panic is coming from:

990c6089db/models/user.go (L1465)

Implying that the c passed in is nil

That comes from L362:

990c6089db/routers/repo/commit.go (L357-L363)

Which implies that the problem is in git.GetNote(...)

Are you using the go-git variant or plain git variant?

@zeripath commented on GitHub (Apr 20, 2021): The panic is coming from: https://github.com/go-gitea/gitea/blob/990c6089db818d3e0e121fedbe883a08f4913236/models/user.go#L1465 Implying that the `c` passed in is `nil` That comes from L362: https://github.com/go-gitea/gitea/blob/990c6089db818d3e0e121fedbe883a08f4913236/routers/repo/commit.go#L357-L363 Which implies that the problem is in `git.GetNote(...)` Are you using the go-git variant or plain git variant?
GiteaMirror commented 2025-11-02 07:20:00 -06:00
Author
Owner
Copy Link

@eveslage commented on GitHub (Apr 20, 2021):

tbh, I am not sure. I installed gitea as binary from the official repository. How would I notice the difference?

@eveslage commented on GitHub (Apr 20, 2021): tbh, I am not sure. I installed gitea as binary from the official repository. How would I notice the difference?
GiteaMirror commented 2025-11-02 07:20:00 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Apr 20, 2021):

No problem so this is a bug in the native git backend then.

Would it be possible to try the following patch?

From 88f39bfc3f9e139450cbfc1b88f054efe5c26362 Mon Sep 17 00:00:00 2001
From: Andrew Thornton <art27@cantab.net>
Date: Tue, 20 Apr 2021 21:12:30 +0100
Subject: [PATCH] Fix NPE on view commit with notes

Fix #15558

Signed-off-by: Andrew Thornton <art27@cantab.net>
---
 modules/git/notes_nogogit.go | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/modules/git/notes_nogogit.go b/modules/git/notes_nogogit.go
index 613efd2e0..1379e5085 100644
--- a/modules/git/notes_nogogit.go
+++ b/modules/git/notes_nogogit.go
@@ -8,6 +8,7 @@ package git
 
 import (
 	"io/ioutil"
+	"strings"
 )
 
 // GetNote retrieves the git-notes data for a given commit.
@@ -49,7 +50,13 @@ func GetNote(repo *Repository, commitID string, note *Note) error {
 	}
 	note.Message = d
 
-	lastCommits, err := GetLastCommitForPaths(notes, "", []string{path})
+	treePath := ""
+	if idx := strings.LastIndex(path, "/"); idx > -1 {
+		treePath = path[:idx]
+		path = path[idx+1:]
+	}
+
+	lastCommits, err := GetLastCommitForPaths(notes, treePath, []string{path})
 	if err != nil {
 		return err
 	}
-- 
2.25.1
@zeripath commented on GitHub (Apr 20, 2021): No problem so this is a bug in the native git backend then. Would it be possible to try the following patch? ```patch From 88f39bfc3f9e139450cbfc1b88f054efe5c26362 Mon Sep 17 00:00:00 2001 From: Andrew Thornton <art27@cantab.net> Date: Tue, 20 Apr 2021 21:12:30 +0100 Subject: [PATCH] Fix NPE on view commit with notes Fix #15558 Signed-off-by: Andrew Thornton <art27@cantab.net> --- modules/git/notes_nogogit.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/git/notes_nogogit.go b/modules/git/notes_nogogit.go index 613efd2e0..1379e5085 100644 --- a/modules/git/notes_nogogit.go +++ b/modules/git/notes_nogogit.go @@ -8,6 +8,7 @@ package git import ( "io/ioutil" + "strings" ) // GetNote retrieves the git-notes data for a given commit. @@ -49,7 +50,13 @@ func GetNote(repo *Repository, commitID string, note *Note) error { } note.Message = d - lastCommits, err := GetLastCommitForPaths(notes, "", []string{path}) + treePath := "" + if idx := strings.LastIndex(path, "/"); idx > -1 { + treePath = path[:idx] + path = path[idx+1:] + } + + lastCommits, err := GetLastCommitForPaths(notes, treePath, []string{path}) if err != nil { return err } -- 2.25.1 ```
GiteaMirror commented 2025-11-02 07:20:00 -06:00
Author
Owner
Copy Link

@eveslage commented on GitHub (Apr 20, 2021):

Do I have to build gitea for source to try out the patch?

@eveslage commented on GitHub (Apr 20, 2021): Do I have to build gitea for source to try out the patch?
GiteaMirror commented 2025-11-02 07:20:00 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Apr 20, 2021):

yes - but I can build a v1.14.x version for you if you tell me which architecture you need

@zeripath commented on GitHub (Apr 20, 2021): yes - but I can build a v1.14.x version for you if you tell me which architecture you need
GiteaMirror commented 2025-11-02 07:20:00 -06:00
Author
Owner
Copy Link

@eveslage commented on GitHub (Apr 20, 2021):

That would be nice. It's Debian buster x64

@eveslage commented on GitHub (Apr 20, 2021): That would be nice. It's Debian buster x64
GiteaMirror commented 2025-11-02 07:20:01 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Apr 20, 2021):

temporary build is up at https://eldritchkitty.com/~andrew/gitea-v1.14.x-15558-linux-amd64.gz

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE0s922pXyAemQFTKrPN50Yx8Tp0gFAmB/OgYACgkQPN50Yx8T
p0hKVA/6Ak5fcH3Myfzgn/JIOA792L1+w3apP6/3pxqq5CV63aDNvBjLnzEDqPWc
di8dfRNNut7MY/gSdbSl+wMROx5+D7inp1W0QaQCk7fg5ZbUna4inzpEkV5isfwv
1ZbOpaW+ElSP3AFkfLrYp9HmQ7a5WI28wHamUsxDLFYUdkoo9JC/453avP5g1k4/
88w5UFH/XSx2EPzlB98/Pnjogc48e9PW9kj1xDUTWsvZZnPhcAv1K534lCf2NmEr
eKPbjhCqA72XU4VehyUNDGleVPRItt9r6iKn6oUxws9ZWz7H7rTsCyv4AeL8hoEn
wXT/hVeN8Lzd6M4xPnd2DQkLHUnRl4NU42LBh2Wm+UDSQtFqEEIPT47tSdeKNWSv
2BKEWKbO/Q32ZBAYQWDzXLqtstlfsQW8z7UMfnH/HJhIRKS8kv95F8w8zwxRfz1V
UO2hzy33Ej1U0B6Itj9z4mSr0/4oPop/ttPn46FkdmciI/GHks8M5UqBG2rmlp9K
4xRJC6pVJoz4ETWvx7DhJycBdDHaReUu5h1Xpx2sKu4qSXvLsLc85TUjFri0QKd2
wEIEnAoOaH61kjz/zBVSme4Io/IZjLg/ULTzlp+ITjFQNcXD/RnsiWjzTFBA5rW2
K+kNWmko7BVKGmEwTiBq8ImlWjSkTD687HNMg13ve55k2OPYE1E=
=PNrd
-----END PGP SIGNATURE-----

is a signature for the gz file.

gunzip it once you've got it.

@zeripath commented on GitHub (Apr 20, 2021): temporary build is up at https://eldritchkitty.com/~andrew/gitea-v1.14.x-15558-linux-amd64.gz ``` -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE0s922pXyAemQFTKrPN50Yx8Tp0gFAmB/OgYACgkQPN50Yx8T p0hKVA/6Ak5fcH3Myfzgn/JIOA792L1+w3apP6/3pxqq5CV63aDNvBjLnzEDqPWc di8dfRNNut7MY/gSdbSl+wMROx5+D7inp1W0QaQCk7fg5ZbUna4inzpEkV5isfwv 1ZbOpaW+ElSP3AFkfLrYp9HmQ7a5WI28wHamUsxDLFYUdkoo9JC/453avP5g1k4/ 88w5UFH/XSx2EPzlB98/Pnjogc48e9PW9kj1xDUTWsvZZnPhcAv1K534lCf2NmEr eKPbjhCqA72XU4VehyUNDGleVPRItt9r6iKn6oUxws9ZWz7H7rTsCyv4AeL8hoEn wXT/hVeN8Lzd6M4xPnd2DQkLHUnRl4NU42LBh2Wm+UDSQtFqEEIPT47tSdeKNWSv 2BKEWKbO/Q32ZBAYQWDzXLqtstlfsQW8z7UMfnH/HJhIRKS8kv95F8w8zwxRfz1V UO2hzy33Ej1U0B6Itj9z4mSr0/4oPop/ttPn46FkdmciI/GHks8M5UqBG2rmlp9K 4xRJC6pVJoz4ETWvx7DhJycBdDHaReUu5h1Xpx2sKu4qSXvLsLc85TUjFri0QKd2 wEIEnAoOaH61kjz/zBVSme4Io/IZjLg/ULTzlp+ITjFQNcXD/RnsiWjzTFBA5rW2 K+kNWmko7BVKGmEwTiBq8ImlWjSkTD687HNMg13ve55k2OPYE1E= =PNrd -----END PGP SIGNATURE----- ``` is a signature for the gz file. gunzip it once you've got it.
GiteaMirror commented 2025-11-02 07:20:01 -06:00
Author
Owner
Copy Link

@eveslage commented on GitHub (Apr 20, 2021):

I will try the build tomorrow and keep you updated. Thanks

@eveslage commented on GitHub (Apr 20, 2021): I will try the build tomorrow and keep you updated. Thanks
GiteaMirror commented 2025-11-02 07:20:01 -06:00
Author
Owner
Copy Link

@eveslage commented on GitHub (Apr 21, 2021):

fix confirmed, thanks for the quick help

@eveslage commented on GitHub (Apr 21, 2021): fix confirmed, thanks for the quick help
GiteaMirror commented 2025-11-02 07:20:01 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 21, 2021):

keep it open until it got merged :)

@6543 commented on GitHub (Apr 21, 2021): keep it open until it got merged :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7219
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?