github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Invalid directory issue with online editor #7024

New Issue
Closed
opened 2025-11-02 07:13:46 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 07:13:46 -06:00
Owner
Copy Link

Originally created by @KN4CK3R on GitHub (Mar 19, 2021).

  • Gitea version (or commit ref): current master

Description

When using the online editor an invalid directory name (because of a file with the same name exists) is detected and reported as an error. On the editor page the invalid directory is now embedded into the path and can't be changed anymore.

Screenshots

test

Originally created by @KN4CK3R on GitHub (Mar 19, 2021). - Gitea version (or commit ref): current master ## Description When using the online editor an invalid directory name (because of a file with the same name exists) is detected and reported as an error. On the editor page the invalid directory is now embedded into the path and can't be changed anymore. ## Screenshots ![test](https://user-images.githubusercontent.com/1666336/111799900-ba48bd80-88cb-11eb-8209-76c29114205b.gif)
GiteaMirror commented 2025-11-02 07:13:47 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Mar 19, 2021):

Huh, I guess no on really thought about putting directories there. If we continue to allow it, we must sanitize input for any .. path segments for security (thought I guess it may not be as critical as this operates on paths within the bare git repos, not directly on the file system).

@silverwind commented on GitHub (Mar 19, 2021): Huh, I guess no on really thought about putting directories there. If we continue to allow it, we must sanitize input for any `..` path segments for security (thought I guess it may not be as critical as this operates on paths within the bare git repos, not directly on the file system).
GiteaMirror commented 2025-11-02 07:13:47 -06:00
Author
Owner
Copy Link

@KN4CK3R commented on GitHub (Mar 19, 2021):

It looks like there isn't an error. The info tooltip says to press backspace on the left of the input field. In this case the directory name gets pulled into the name field again.

.. isn't a problem too:
grafik

@KN4CK3R commented on GitHub (Mar 19, 2021): It looks like there isn't an error. The info tooltip says to press backspace on the left of the input field. In this case the directory name gets pulled into the name field again. `..` isn't a problem too: ![grafik](https://user-images.githubusercontent.com/1666336/111818863-f5ed8280-88df-11eb-88ff-54517ee8dbe9.png)
GiteaMirror commented 2025-11-02 07:13:47 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Mar 19, 2021):

Agh but you have found a bug - we really should not be displaying /src/data/tmp/local-repo/...

@zeripath commented on GitHub (Mar 19, 2021): Agh but you have found a bug - we really should not be displaying `/src/data/tmp/local-repo/...`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#7024
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?