Permissions related question #70

@thibaultmeyer commented on GitHub (Nov 21, 2016):

"why do I need to set repos as private when the entire Gogs installation is private, that shoud be enough"

By example, in our company : we don't want that repo A was visible from users who only have read permission on repo B. We also use this feature to hide a lot a repos from trainees or to hide "non android" projects to Android developers.

Private Gitea instance ==> Must be registered to see something
Private repo ==> Must be accepted by repo owner to view files or contribute

@thibaultmeyer commented on GitHub (Nov 21, 2016): _"why do I need to set repos as private when the entire Gogs installation is private, that shoud be enough"_ By example, in our company : we don't want that repo A was visible from users who only have read permission on repo B. We also use this feature to hide a lot a repos from trainees or to hide "non android" projects to Android developers. Private Gitea instance ==> Must be registered to see something Private repo ==> Must be accepted by repo owner to view files or contribute

GiteaMirror commented

@lunny commented on GitHub (Nov 21, 2016):

^

The same word private which has different meaning.

@lunny commented on GitHub (Nov 21, 2016): ^ The same word `private` which has different meaning.

GiteaMirror commented

@axeloz commented on GitHub (Nov 21, 2016):

Hello @0xbaadf00d,

"why do I need to set repos as private when the entire Gogs installation is private, that shoud be enough" ==> my mistake I did not finish this sentence, I forgot to get rid of it prior to posting...

Yes, that's my point. I have my internal devs, they're in my MyTeam team and should have access to all repos of my MyOrg organisation.
But I also have external devs on particular projects and they must have access to one given repo (which works well when adding the user directly in the repo settings). But same issue for external devs : even if they have access to a repo, this repo doesn't show up in the Explorer.

That's why I use private repos on my org. So the two issues I can see here are :

why doesn't the Explorer list all repos you have access to?
why a team member cannot list all repos of a given organisation?

Thanks

@axeloz commented on GitHub (Nov 21, 2016): Hello @0xbaadf00d, "_why do I need to set repos as private when the entire Gogs installation is private, that shoud be enough_" ==> my mistake I did not finish this sentence, I forgot to get rid of it prior to posting... Yes, that's my point. I have my internal devs, they're in my MyTeam team and should have access to all repos of my MyOrg organisation. But I also have external devs on particular projects and they must have access to one given repo (which works well when adding the user directly in the repo settings). But same issue for external devs : even if they have access to a repo, this repo doesn't show up in the Explorer. That's why I use private repos on my org. So the two issues I can see here are : * why doesn't the Explorer list all repos you have access to? * why a team member cannot list all repos of a given organisation? Thanks

GiteaMirror commented

@axeloz commented on GitHub (Nov 21, 2016):

I add a comment in the issue because it is related :
because my users can't see anything in the Explorer page, they also can't use the search engine.
Plus, because all the repos are ordered by updated date, it is a pain to find a repo : I have to browse all the pages, one by one, to find the repo I'm looking for. I have 50 repos so far and more are coming. It's frustrating.

So my guess would be to :

allow users to order repos anywhere by name / updated_time / creation_time (and to set this set by default or to keep this setting in a cookie)
allow users to browse all the repos they have access to in the Explorer page (not only the public one)
therefore, allow users to use the search engine (not only for public repos but all repos they have access to).
allow all users of a given team to access (read, read/write or admin according to the team permission) to all repos of the organisation owning the team, no matter the repo belong to the Owner of the organisation or to the team. This point is actually quite weird in term of functionality by the way, because when adding a repo, I did set the owner to "MyOrg" in the select list but in reality, the repo is assigned to the "Owners" team of the "MyOrg" org, not directly to the "MyOrg" organisation like I asked.

That would make me very happy and I can't imagine I'm the only one. I'm a good web developer and CTO and I'm mad at myself I don't know a thing about Go. I know exactly what should be modified and where in the sources, line by line, but it will take me so much time to do so and to understand how to develop on Gitea... :( I couldn't find a tuto on how to build the master branch with live reload. If anyone has this, I might be interested.

Thanks a lot

@axeloz commented on GitHub (Nov 21, 2016): I add a comment in the issue because it is related : because my users can't see anything in the Explorer page, they also can't use the search engine. Plus, because all the repos are ordered by updated date, it is a pain to find a repo : I have to browse all the pages, one by one, to find the repo I'm looking for. I have 50 repos so far and more are coming. It's frustrating. So my guess would be to : * allow users to order repos anywhere by name / updated_time / creation_time (and to set this set by default or to keep this setting in a cookie) * allow users to browse all the repos they have access to in the Explorer page (not only the public one) * therefore, allow users to use the search engine (not only for public repos but all repos they have access to). * allow all users of a given team to access (read, read/write or admin according to the team permission) to all repos of the organisation owning the team, no matter the repo belong to the Owner of the organisation or to the team. This point is actually quite weird in term of functionality by the way, because when adding a repo, I did set the owner to "MyOrg" in the select list but in reality, the repo is assigned to the "Owners" team of the "MyOrg" org, not directly to the "MyOrg" organisation like I asked. That would make me very happy and I can't imagine I'm the only one. I'm a good web developer and CTO and I'm mad at myself I don't know a thing about Go. I know exactly what should be modified and where in the sources, line by line, but it will take me so much time to do so and to understand how to develop on Gitea... :( I couldn't find a tuto on how to build the master branch with live reload. If anyone has this, I might be interested. Thanks a lot

GiteaMirror commented

@Bwko commented on GitHub (Nov 21, 2016):

I'm almost done with:

allow users to order repos anywhere by name / updated_time / creation_time (and to set this set by default or to keep this setting in a cookie)
allow users to browse all the repos they have access to in the Explorer page (not only the public one)
therefore, allow users to use the search engine (not only for public repos but all repos they have access to).

I'll create a PR tomorrow

@Bwko commented on GitHub (Nov 21, 2016): I'm almost done with: - allow users to order repos anywhere by name / updated_time / creation_time (and to set this set by default or to keep this setting in a cookie) - allow users to browse all the repos they have access to in the Explorer page (not only the public one) - therefore, allow users to use the search engine (not only for public repos but all repos they have access to). I'll create a PR tomorrow

GiteaMirror commented

@axeloz commented on GitHub (Nov 22, 2016):

@bwko awesome, thanks. You're fast.
I have to dig into Go. How do you set a dev environment ?

@axeloz commented on GitHub (Nov 22, 2016): @bwko awesome, thanks. You're fast. I have to dig into Go. How do you set a dev environment ?

GiteaMirror commented

@strk commented on GitHub (Nov 22, 2016):

On Tue, Nov 22, 2016 at 12:26:34AM -0800, axeloz wrote:

How do you set a dev environment ?

See https://golang.org/doc/install

Once you're setup (Go installed and GOPATH env variable set)
you'd do:

 go get code.gitea.io/gitea
 cd $GOPATH/src/code.gitea.io/gitea
 ./gitea web

@strk commented on GitHub (Nov 22, 2016): On Tue, Nov 22, 2016 at 12:26:34AM -0800, axeloz wrote: > How do you set a dev environment ? See https://golang.org/doc/install Once you're setup (Go installed and GOPATH env variable set) you'd do: ``` go get code.gitea.io/gitea cd $GOPATH/src/code.gitea.io/gitea ./gitea web ```

GiteaMirror commented

@axeloz commented on GitHub (Nov 22, 2016):

Thanks @strk does it include a file watcher which will recompile when I update the code? Or should I rerun the server each time?

@axeloz commented on GitHub (Nov 22, 2016): Thanks @strk does it include a file watcher which will recompile when I update the code? Or should I rerun the server each time?

GiteaMirror commented

@strk commented on GitHub (Nov 22, 2016):

The commands I showed do not include a file watcher.
You need to recompile (go build from within the
source directory) and then re-run the server, upon
changes.

@strk commented on GitHub (Nov 22, 2016): The commands I showed do not include a file watcher. You need to _recompile_ (`go build` from within the source directory) and then re-run the server, upon changes.

GiteaMirror commented

@axeloz commented on GitHub (Nov 22, 2016):

OK thanks,
I asked because Gogs uses a watcher according to its documentation :

You can enable live compile by executing bra run in the Gogs source folder To install bra: go get -u github.com/Unknwon/bra

@axeloz commented on GitHub (Nov 22, 2016): OK thanks, I asked because Gogs uses a watcher according to its documentation : `You can enable live compile by executing bra run in the Gogs source folder To install bra: go get -u github.com/Unknwon/bra`

GiteaMirror commented

@lunny commented on GitHub (Nov 22, 2016):

Any file watcher included bra is still avaiable for Gitea. @axeloz

@lunny commented on GitHub (Nov 22, 2016): Any file watcher included `bra` is still avaiable for Gitea. @axeloz

GiteaMirror commented