[FR] Implement Required Approvals similar to GitLab #6856

New Issue

GiteaMirror · 2025-11-02T07:08:44-06:00

GiteaMirror commented

2025-11-02 07:08:44 -06:00

Originally created by @Reinitialized on GitHub (Feb 12, 2021).

Currently, the pull request approvals are lackluster in the sense of not enforcing reviewers to give consent before a request can be merged. GitLab has the ability to require approval from reviewers, and a lot of customization. Refer to the link for detailed explanation as I feel it is redundant to rewrite what's already written.

https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html#required-approvals

Originally created by @Reinitialized on GitHub (Feb 12, 2021). Currently, the pull request approvals are lackluster in the sense of not enforcing reviewers to give consent before a request can be merged. GitLab has the ability to require approval from reviewers, and a lot of customization. Refer to the link for detailed explanation as I feel it is redundant to rewrite what's already written. https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html#required-approvals

GiteaMirror closed this issue

2025-11-02 07:08:44 -06:00

GiteaMirror commented

2025-11-02 07:08:45 -06:00

@jolheiser commented on GitHub (Feb 12, 2021):

You can set the number of required approvals, as well as a list of users/teams who count towards that number.

@jolheiser commented on GitHub (Feb 12, 2021): You can set the number of required approvals, as well as a list of users/teams who count towards that number.

GiteaMirror commented

2025-11-02 07:08:46 -06:00

@Reinitialized commented on GitHub (Feb 12, 2021):

You can set the number of required approvals, as well as a list of users/teams who count towards that number.

I've been playing around with Pull Requests before making this while reading available documentation, and haven't seen it? When setting test accounts as Reviewers, I was still able to merge the request and could not find options to enforce their consent beforehand.

@Reinitialized commented on GitHub (Feb 12, 2021): > You can set the number of required approvals, as well as a list of users/teams who count towards that number. I've been playing around with Pull Requests before making this while reading available documentation, and haven't seen it? When setting test accounts as Reviewers, I was still able to merge the request and could not find options to enforce their consent beforehand.

GiteaMirror commented

2025-11-02 07:08:46 -06:00

@jolheiser commented on GitHub (Feb 12, 2021):

You have to set up branch protection.

https://try.gitea.io/<user>/<repo>/settings/branches/master

@jolheiser commented on GitHub (Feb 12, 2021): You have to set up branch protection. `https://try.gitea.io/<user>/<repo>/settings/branches/master`

GiteaMirror commented

2025-11-02 07:08:46 -06:00

@Reinitialized commented on GitHub (Feb 12, 2021):

Alright, good to know. I'll adapt this request then as afaict this has to be implemented per branch, and it would be nice to have this automatically apply on each pull request vs manually configuring it. Scratch that, upon further review it seems this would apply to each merge request. Closing

@Reinitialized commented on GitHub (Feb 12, 2021): ~~Alright, good to know. I'll adapt this request then as afaict this has to be implemented per branch, and it would be nice to have this automatically apply on each pull request vs manually configuring it.~~ Scratch that, upon further review it seems this would apply to each merge request. Closing

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6856