Delete account password field length #683

Closed
opened 2025-11-02 03:33:04 -06:00 by GiteaMirror · 15 comments
Owner

Originally created by @Fastidious on GitHub (May 2, 2017).

Description

Make delete account password field match the length of rest of the fields under settings.

Screenshots

Currently:

screen shot 2017-05-02 at 13 32 27

Make it like gogs (talking about the length, not the settings arrangement):

screen shot 2017-05-02 at 13 33 00

Originally created by @Fastidious on GitHub (May 2, 2017). - Gitea version (or commit ref): `Current` - Git version: `N/A` - Operating system: `N/A` - Database (use `[x]`): `N/A` - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (provide example URL) https://try.gitea.io/user/settings/delete - [ ] No - [ ] Not relevant - Log gist: ## Description Make delete account password field match the length of rest of the fields under settings. ## Screenshots Currently: ![screen shot 2017-05-02 at 13 32 27](https://cloud.githubusercontent.com/assets/8352292/25630746/2bef5d56-2f3c-11e7-9f1a-ef29cb33ade0.png) Make it like `gogs` (talking about the length, not the settings arrangement): ![screen shot 2017-05-02 at 13 33 00](https://cloud.githubusercontent.com/assets/8352292/25630775/47125ffc-2f3c-11e7-8c3a-1a49ff7a71a0.png)
GiteaMirror added the topic/uitype/bug labels 2025-11-02 03:33:04 -06:00
Author
Owner

@bkcsoft commented on GitHub (May 2, 2017):

I'm calling this a ui-bug 😄

@bkcsoft commented on GitHub (May 2, 2017): I'm calling this a ui-bug 😄
Author
Owner

@Fastidious commented on GitHub (May 2, 2017):

@bkcsoft also, why is there a reason for a “Forgot password?” link there? To get to this, one must be logged in, am I missing something? Gogs, for example, do not have it there.

@Fastidious commented on GitHub (May 2, 2017): @bkcsoft also, why is there a reason for a “Forgot password?” link there? To get to this, one must be logged in, am I missing something? `Gogs`, for example, do not have it there.
Author
Owner

@bkcsoft commented on GitHub (May 2, 2017):

I have no clue 😂

@bkcsoft commented on GitHub (May 2, 2017): I have no clue 😂
Author
Owner

@lunny commented on GitHub (May 3, 2017):

@Fastidious Since Gitea support login via Oauth2 then many people maybe didn't use their password many days. So when he want to delete himself he maybe forget his password.

@lunny commented on GitHub (May 3, 2017): @Fastidious Since Gitea support login via Oauth2 then many people maybe didn't use their password many days. So when he want to delete himself he maybe forget his password.
Author
Owner

@lunny commented on GitHub (May 3, 2017):

And I don't think this is a bug, maybe it's an enhancement.

@lunny commented on GitHub (May 3, 2017): And I don't think this is a bug, maybe it's an enhancement.
Author
Owner

@Fastidious commented on GitHub (May 3, 2017):

So when he want to delete himself he maybe forget his password.

@lunny, if anything, that’s an UX problem. Perhaps gitea should detect you are logging in with Oauth2, and allow account deletion under those conditions, perhaps asking “Are you sure?” with a little verbose stating that’s final — thus making the “Forgot password?” link irrelevant.

@Fastidious commented on GitHub (May 3, 2017): > So when he want to delete himself he maybe forget his password. @lunny, if anything, that’s an UX problem. Perhaps `gitea` should detect you are logging in with Oauth2, and allow account deletion under those conditions, perhaps asking “Are you sure?” with a little verbose stating that’s final — thus making the “Forgot password?” link irrelevant.
Author
Owner

@lafriks commented on GitHub (May 3, 2017):

Deleting account must ask for password for security reasons

@lafriks commented on GitHub (May 3, 2017): Deleting account must ask for password for security reasons
Author
Owner

@Fastidious commented on GitHub (May 3, 2017):

@lafriks I think we all understand that. How do you propose asking for a password should happen, when using Oauth2 to login? Perhaps disable account deletion with Oauth2 logins, and only show it with local logins?

@Fastidious commented on GitHub (May 3, 2017): @lafriks I think we all understand that. How do you propose asking for a password should happen, when using Oauth2 to login? Perhaps disable account deletion with Oauth2 logins, and only show it with local logins?
Author
Owner

@lunny commented on GitHub (May 3, 2017):

@Fastidious, in fact, OAuth2/OpenID is an linked account, you also has an related local account. This is different from LDAP/SMTP. Also, maybe we should change LDAP/SMTP like OAuth2 in future.

@lunny commented on GitHub (May 3, 2017): @Fastidious, in fact, OAuth2/OpenID is an linked account, you also has an related local account. This is different from LDAP/SMTP. Also, maybe we should change LDAP/SMTP like OAuth2 in future.
Author
Owner

@lafriks commented on GitHub (May 3, 2017):

No, LDAP should not be moved to linked account as in organizations LDAP will be primary account store and users should not be able to change/use different passwords for Gitea as than it can't be controlled by password policy etc.

@lafriks commented on GitHub (May 3, 2017): No, LDAP should not be moved to linked account as in organizations LDAP will be primary account store and users should not be able to change/use different passwords for Gitea as than it can't be controlled by password policy etc.
Author
Owner

@Fastidious commented on GitHub (May 3, 2017):

@lunny yes, I understand that too. Yet, once you use OAuth2 there is no longer a need to remember the “other” local password.

@Fastidious commented on GitHub (May 3, 2017): @lunny yes, I understand that too. Yet, once you use OAuth2 there is no longer a need to remember the “other” local password.
Author
Owner

@lafriks commented on GitHub (May 3, 2017):

@Fastidious that is why there is Forgot password link ;)

@lafriks commented on GitHub (May 3, 2017): @Fastidious that is why there is Forgot password link ;)
Author
Owner

@Fastidious commented on GitHub (May 3, 2017):

@lafriks we are dancing in a loop, playing a broken record. Back to this track. Cheers!

@Fastidious commented on GitHub (May 3, 2017): @lafriks we are dancing in a loop, playing a broken record. Back to [this track](https://github.com/go-gitea/gitea/issues/1659#issuecomment-298889237). Cheers!
Author
Owner

@strk commented on GitHub (May 4, 2017):

Password handling discussion should be in #1036, please continue it there.
This ticket is for an UI bug, keep that here.

@strk commented on GitHub (May 4, 2017): Password handling discussion should be in #1036, please continue it there. This ticket is for an UI bug, keep that here.
Author
Owner

@sondr3 commented on GitHub (May 14, 2017):

I can fix the password length field if no one else is working on it.

Edit: Seems I overlooked the comment about what to do with it regarding OAuth2 etc, scratch that.

@sondr3 commented on GitHub (May 14, 2017): I can fix the password length field if no one else is working on it. *Edit*: Seems I overlooked the comment about what to do with it regarding OAuth2 etc, scratch that.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#683