Issue/Pull dependencies is inefficient #6807

New Issue

GiteaMirror · 2025-11-02T07:07:03-06:00

GiteaMirror commented

2025-11-02 07:07:03 -06:00

Originally created by @6543 on GitHub (Feb 3, 2021).

look like gitea >= 1.13.0; gitea < 1.14.0 is affected

-> if you type text into search field no issues/pulls are displayed to select
-> JS does not hit the API to get issues :/

Originally created by @6543 on GitHub (Feb 3, 2021). look like gitea >= 1.13.0; gitea < 1.14.0 is affected -> if you type text into search field no issues/pulls are displayed to select -> JS does not hit the API to get issues :/

GiteaMirror added the type/bug label 2025-11-02 07:07:03 -06:00

GiteaMirror closed this issue

2025-11-02 07:07:03 -06:00

GiteaMirror commented

2025-11-02 07:07:04 -06:00

@lunny commented on GitHub (Feb 4, 2021):

If it affected v1.13.0, I think we should move milestone to v1.13.3

@lunny commented on GitHub (Feb 4, 2021): If it affected v1.13.0, I think we should move milestone to v1.13.3

GiteaMirror commented

2025-11-02 07:07:05 -06:00

@gregzawadzki commented on GitHub (Feb 4, 2021):

From gitea chat what I came to:

Gitea Version: 1.12.6  This one shows me only #20 and up.
[20:35]
@6543 search by name does not work either. Like it was limited to some number of entries to check. No idea. For example load last 10 to memory, then filter from these 10 matching elements.
[20:37]
@6543 Pattern seems to be, it only shows searches from these, that are visible on 1st page of issues.
On repo1 where I have on 1st page issues #18 and up (#19 is closed) and it shows #18 and up. without #19
On repo2 where on first page i have #20 and up visible, only these are searchable
So it seems to be bound only to 1st page of issues somehow

@gregzawadzki commented on GitHub (Feb 4, 2021): From gitea chat what I came to: ``` Gitea Version: 1.12.6 This one shows me only #20 and up. [20:35] @6543 search by name does not work either. Like it was limited to some number of entries to check. No idea. For example load last 10 to memory, then filter from these 10 matching elements. [20:37] @6543 Pattern seems to be, it only shows searches from these, that are visible on 1st page of issues. On repo1 where I have on 1st page issues #18 and up (#19 is closed) and it shows #18 and up. without #19 On repo2 where on first page i have #20 and up visible, only these are searchable So it seems to be bound only to 1st page of issues somehow ```

GiteaMirror commented

2025-11-02 07:07:05 -06:00

@6543 commented on GitHub (Feb 27, 2021):

Tested (Linux + Firefox 86.0 (64-bit)):

mysql + 1.14.0+dev-765-g42118c6bc	works ...
sqlite + 1.14.0+dev-765-g42118c6bc	works ...
mysql + 1.13.2+14-g90bf1e796	broken

Discover:
JS does not hit the API to get issues :/

@6543 commented on GitHub (Feb 27, 2021): Tested (Linux + Firefox 86.0 (64-bit)): |mysql + 1.14.0+dev-765-g42118c6bc | works ...| |---|---| | sqlite + 1.14.0+dev-765-g42118c6bc | works ...| | mysql + 1.13.2+14-g90bf1e796 | broken | Discover: JS does not hit the API to get issues :/

GiteaMirror commented

2025-11-02 07:07:05 -06:00

@zeripath commented on GitHub (Mar 3, 2021):

OK I just tested on 1.13.0+30-g205be63bc

On the issues page this works. On pulls page this works.

(Chromium linux & firefox linux)

@zeripath commented on GitHub (Mar 3, 2021): OK I just tested on 1.13.0+30-g205be63bc On the issues page this works. On pulls page this works. (Chromium linux & firefox linux)

GiteaMirror commented

2025-11-02 07:07:05 -06:00

@zeripath commented on GitHub (Mar 3, 2021):

There is a minimum number of letters required to make it do a search - perhaps this was the issue?

@zeripath commented on GitHub (Mar 3, 2021): There is a minimum number of letters required to make it do a search - perhaps this was the issue?

GiteaMirror commented

2025-11-02 07:07:06 -06:00

@zeripath commented on GitHub (Mar 3, 2021):

As I cannot reproduce I'm gonna unmilestone and mark it as needs-feedback.

@zeripath commented on GitHub (Mar 3, 2021): As I cannot reproduce I'm gonna unmilestone and mark it as needs-feedback.

GiteaMirror commented

2025-11-02 07:07:06 -06:00

@gregzawadzki commented on GitHub (Mar 4, 2021):

@zeripath https://try.gitea.io/seigieu/test/issues/23
On this one, I currently cannot even search for issues
https://youtu.be/c_msyXXHD2I

@gregzawadzki commented on GitHub (Mar 4, 2021): @zeripath https://try.gitea.io/seigieu/test/issues/23 On this one, I currently cannot even search for issues https://youtu.be/c_msyXXHD2I

GiteaMirror commented

2025-11-02 07:07:07 -06:00

@gregzawadzki commented on GitHub (Mar 4, 2021):

https://youtu.be/iJhSqSpA0X4
Here is movie of my instance. 1.12.6 currently. Cant select any from second page

@gregzawadzki commented on GitHub (Mar 4, 2021): https://youtu.be/iJhSqSpA0X4 Here is movie of my instance. 1.12.6 currently. Cant select any from second page

GiteaMirror commented

2025-11-02 07:07:07 -06:00

@6543 commented on GitHub (Mar 4, 2021):

@seigieu witch browser & OS do you use?

@6543 commented on GitHub (Mar 4, 2021): @seigieu witch browser & OS do you use?

GiteaMirror commented

2025-11-02 07:07:08 -06:00

@zeripath commented on GitHub (Mar 5, 2021):

Could you add arandomer@mailinator.com to that repository as a writing collaborator so I can test.

That the number of issues is >20 makes me suspicious it's a paging issue but I'm not certain.

@zeripath commented on GitHub (Mar 5, 2021): Could you add arandomer@mailinator.com to that repository as a writing collaborator so I can test. That the number of issues is >20 makes me suspicious it's a paging issue but I'm not certain.

GiteaMirror commented

2025-11-02 07:07:08 -06:00

@zeripath commented on GitHub (Mar 5, 2021):

Ok your second video looks exactly like a paging issue, does typing the issue in to the search box reveal the issues?

In your first video try.gitea.io looks like it's running very slow indeed and I suspect that the API call to list the issues hasn't returned by the time you're expecting it to have and our UI doesn't have any marker to show that it's doing a search.

@zeripath commented on GitHub (Mar 5, 2021): Ok your second video looks exactly like a paging issue, does typing the issue in to the search box reveal the issues? In your first video try.gitea.io looks like it's running very slow indeed and I suspect that the API call to list the issues hasn't returned by the time you're expecting it to have and our UI doesn't have any marker to show that it's doing a search.

GiteaMirror commented

2025-11-02 07:07:08 -06:00

@gregzawadzki commented on GitHub (Mar 5, 2021):

@6543
Linux Firefox (newest) also Chromium. Same effect.
@zeripath i get "User does not exist" on try.gitea.com.
If you mean my repository I cannot route it to world. It's only available in LAN.

(after some testing...)

But when I tested it more to look for issue. Search seems to work. But it searches ONLY for whole words.
If i type propa it will not look for popragation etc. Have to type propagation literally for it to search just fine.
Typing #33 have found 33 string in 2020-10-21 13:02:33 text line, but not issue #33.

I'm not sure if I didn't get confused, since I was 100% sure I can search issues by #33 and partial words etc.

And for pagination part. Pagination issue seems to be present only when I click and scroll down (not sure if its feature or issue now. May be feature to limit to latest entries).

try.gitea.com - yes, its running very slow. checked in network tab and its a long loading issue.

@gregzawadzki commented on GitHub (Mar 5, 2021): @6543 Linux Firefox (newest) also Chromium. Same effect. @zeripath i get "User does not exist" on try.gitea.com. If you mean my repository I cannot route it to world. It's only available in LAN. *(after some testing...)* But when I tested it more to look for issue. Search seems to work. But it searches ONLY for whole words. If i type `propa` it will not look for `popragation` etc. Have to type `propagation` literally for it to search just fine. Typing `#33` have found `33` string in `2020-10-21 13:02:33` text line, but not issue `#33`. I'm not sure if I didn't get confused, since I was 100% sure I can search issues by `#33` and partial words etc. And for pagination part. Pagination issue seems to be present only when I click and scroll down (not sure if its feature or issue now. May be feature to limit to latest entries). try.gitea.com - yes, its running very slow. checked in network tab and its a long loading issue.

GiteaMirror commented

2025-11-02 07:07:09 -06:00

@zeripath commented on GitHub (Mar 5, 2021):

I meant on the try.gitea.io repository you'd uploaded.

In regards to exact searching #14694 should help there.

I'll look at the rest of your comments tomorrow. Sorry I didn't get to this today.

@zeripath commented on GitHub (Mar 5, 2021): I meant on the try.gitea.io repository you'd uploaded. In regards to exact searching #14694 should help there. I'll look at the rest of your comments tomorrow. Sorry I didn't get to this today.

GiteaMirror commented

2025-11-02 07:07:09 -06:00

@zeripath commented on GitHub (Mar 11, 2021):

I think in part some of this issue is related to #12827

@zeripath commented on GitHub (Mar 11, 2021): I think in part some of this issue is related to #12827

GiteaMirror commented

2025-11-02 07:07:09 -06:00

@zeripath commented on GitHub (Mar 29, 2021):

Looking at try.gitea.io it appears that the improvement from #15179 could actually be sufficient to close this issue! Although I would still argue that the API is still too non-performant.

@zeripath commented on GitHub (Mar 29, 2021): Looking at try.gitea.io it appears that the improvement from #15179 could actually be sufficient to close this issue! Although I would still argue that the API is still too non-performant.

GiteaMirror commented

2025-11-02 07:07:09 -06:00

@6543 commented on GitHub (Mar 29, 2021):

~~let it open~~ rename it & let it open

@6543 commented on GitHub (Mar 29, 2021): ~~let it open~~ rename it & let it open

GiteaMirror commented

2025-11-02 07:07:09 -06:00

@6543 commented on GitHub (Mar 29, 2021):

close in favour of #12827

@6543 commented on GitHub (Mar 29, 2021): close in favour of #12827

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6807