util, helper and etc package names should be depreciated. #6804

Closed
opened 2025-11-02 07:06:58 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @6543 on GitHub (Feb 3, 2021).

util, helper and etc package names should be depreciated.

Originally posted by @lunny in https://github.com/go-gitea/gitea/issues/14524#issuecomment-772637719

Originally created by @6543 on GitHub (Feb 3, 2021). `util`, `helper` and etc package names should be depreciated. _Originally posted by @lunny in https://github.com/go-gitea/gitea/issues/14524#issuecomment-772637719_
GiteaMirror added the issue/needs-feedbacktype/refactoring labels 2025-11-02 07:06:58 -06:00
Author
Owner

@6543 commented on GitHub (Feb 3, 2021):

helpers:

"move modules/util/paginate.go to modules/paginate/paginate.go"

@6543 commented on GitHub (Feb 3, 2021): helpers: * API helper: [routers/api/v1/utils](https://github.com/go-gitea/gitea/tree/master/routers/api/v1/utils) * [modules/util](https://github.com/go-gitea/gitea/tree/master/modules/util) "move `modules/util/paginate.go` to `modules/paginate/paginate.go`"
Author
Owner

@wxiaoguang commented on GitHub (Apr 26, 2023):

We are still adding new code to the util package. So I guess it's so far so good?

ps: IMO instead of keeping issues open, I think it's better to write some PRs to refactor ... if it's worth and it is necessary 😁

@wxiaoguang commented on GitHub (Apr 26, 2023): We are still adding new code to the `util` package. So I guess it's so far so good? ps: IMO instead of keeping issues open, I think it's better to write some PRs to refactor ... if it's worth and it is necessary 😁
Author
Owner

@harryzcy commented on GitHub (Aug 26, 2023):

I feel utils is too vague for a package name, and it's unclear what's actually inside.

We should either use gitutil, webhookutil... or put those into respective modules or services

@harryzcy commented on GitHub (Aug 26, 2023): I feel `utils` is too vague for a package name, and it's unclear what's actually inside. We should either use `gitutil`, `webhookutil`... or put those into respective `modules` or `services`
Author
Owner

@GiteaBot commented on GitHub (Sep 25, 2023):

We close issues that need feedback from the author if there were no new comments for a month. 🍵

@GiteaBot commented on GitHub (Sep 25, 2023): We close issues that need feedback from the author if there were no new comments for a month. :tea:
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#6804