[Bug] Don't mark due date in merged/ closed PRs as overdue #6795

New Issue

GiteaMirror · 2025-11-02T07:06:45-06:00

GiteaMirror commented

2025-11-02 07:06:45 -06:00

Originally created by @delvh on GitHub (Jan 31, 2021).

Gitea version (or commit ref): 1.14.0+dev-646-g6064bfa3c
Can you reproduce the bug at https://try.gitea.io:
- Yes

Description

Currently when a PR has a due date and gets merged or closed, it will, after the due date has expired, get displayed as overdue, even if it was merged on time. This always gets confusing when looking at closed PRs.
The question is: Is it really needed to display the due date when a PR has been closed (independent from if it was closed or merged)?
I'd argue that leaving it out for any closed/ merged PR would suffice to solve the problem, as there is no real value in leaving it in.
Another possible approach would be to display the due date in a PR merged on time normally, and otherwise overdue. This approach however is most likely more complex to implement.
I'm fine with both.
...

Screenshots

Originally created by @delvh on GitHub (Jan 31, 2021). - Gitea version (or commit ref): 1.14.0+dev-646-g6064bfa3c - Can you reproduce the bug at https://try.gitea.io: - [Yes](https://try.gitea.io/delvh/kanban-test/pulls?q=&type=all&sort=&state=closed&labels=&milestone=0&assignee=0) ## Description Currently when a PR has a due date and gets merged or closed, it will, after the due date has expired, get displayed as overdue, even if it was merged on time. This always gets confusing when looking at closed PRs. The question is: Is it really needed to display the due date when a PR has been closed (independent from if it was closed or merged)? I'd argue that leaving it out for any closed/ merged PR would suffice to solve the problem, as there is no real value in leaving it in. Another possible approach would be to display the due date in a PR merged on time normally, and otherwise overdue. This approach however is most likely more complex to implement. I'm fine with both. ... ## Screenshots ![image](https://user-images.githubusercontent.com/51889757/106400449-b564a300-641e-11eb-907b-9c3fb5dcc91b.png)

GiteaMirror added the type/bug label 2025-11-02 07:06:45 -06:00

GiteaMirror closed this issue

2025-11-02 07:06:45 -06:00

GiteaMirror commented

2025-11-02 07:06:46 -06:00

@delvh commented on GitHub (Mar 5, 2021):

Furthermore, the same behavior could also be found when looking explicitly at a closed PR: The due date will also after expiring, no matter whether the PR has been merged/ closed or not, get displayed as overdue.
Here however, the solution will be more complicated as it is counterproductive to completely remove the due date here. Here, we really have to change appearance depending on whether the PR has been merged on time or not.

(the screenshot has been taken on a merged PR (and with German locale…))

@delvh commented on GitHub (Mar 5, 2021): Furthermore, the same behavior could also be found when looking explicitly at a closed PR: The due date will also after expiring, no matter whether the PR has been merged/ closed or not, get displayed as overdue. Here however, the solution will be more complicated as it is counterproductive to completely remove the due date here. Here, we really have to change appearance depending on whether the PR has been merged on time or not. ![image](https://user-images.githubusercontent.com/51889757/110105648-f1d24880-7da8-11eb-9f16-946d42d0cfcc.png) (the screenshot has been taken on a merged PR (and with German locale…))

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6795