HTML source reveals version #6788

New Issue

GiteaMirror · 2025-11-02T07:06:34-06:00

GiteaMirror commented

2025-11-02 07:06:34 -06:00

Originally created by @morph027 on GitHub (Jan 29, 2021).

Gitea version (or commit ref): 1.13.1
Git version: 1:2.17.1-1ubuntu0.7
Operating system:

Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.4 LTS
Release:	18.04
Codename:	bionic

Package download from https://dl.gitea.io/gitea/ and running via systemd

Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite

Description

I already set SHOW_FOOTER_VERSION which does work for the footer, but inspecting the source code of the page still reveals the version.

Screenshots

Originally created by @morph027 on GitHub (Jan 29, 2021). - Gitea version (or commit ref): 1.13.1 - Git version: 1:2.17.1-1ubuntu0.7 - Operating system: ``` Distributor ID: Ubuntu Description: Ubuntu 18.04.4 LTS Release: 18.04 Codename: bionic ``` Package download from https://dl.gitea.io/gitea/ and running via systemd - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite ## Description I already set `SHOW_FOOTER_VERSION` which does work for the footer, but inspecting the source code of the page still reveals the version. ## Screenshots ![Screenshot from 2021-01-29 13-24-36](https://user-images.githubusercontent.com/600106/106274927-58f25f80-6235-11eb-97dc-c13db4499e40.png)

GiteaMirror added the type/question label 2025-11-02 07:06:34 -06:00

GiteaMirror closed this issue

2025-11-02 07:06:34 -06:00

GiteaMirror commented

2025-11-02 07:06:35 -06:00

@KN4CK3R commented on GitHub (Jan 29, 2021):

SHOW_FOOTER_VERSION is not intended to keep the version secret. Should this be a feature request to keep the version number private?

@KN4CK3R commented on GitHub (Jan 29, 2021): `SHOW_FOOTER_VERSION` is not intended to keep the version secret. Should this be a feature request to keep the version number private?

GiteaMirror commented

2025-11-02 07:06:35 -06:00

@lunny commented on GitHub (Jan 29, 2021):

The AppVer is used by service worker to cache something.

@lunny commented on GitHub (Jan 29, 2021): The `AppVer` is used by service worker to cache something.

GiteaMirror commented

2025-11-02 07:06:35 -06:00

@morph027 commented on GitHub (Jan 29, 2021):

Okay, thanks for clarification!

@morph027 commented on GitHub (Jan 29, 2021): Okay, thanks for clarification!

GiteaMirror commented

2025-11-02 07:06:35 -06:00

@morph027 commented on GitHub (Feb 1, 2021):

Crawling trough the code, i see a lot of {{MD5 AppVer}} template variables. Can't we just use the md5 hash as the service worker cacheKey too?

@morph027 commented on GitHub (Feb 1, 2021): Crawling trough the code, i see a lot of `{{MD5 AppVer}}` template variables. Can't we just use the md5 hash as the service worker `cacheKey` too?

GiteaMirror commented

2025-11-02 07:06:35 -06:00

@KN4CK3R commented on GitHub (Feb 1, 2021):

If your concern is security, that won't help.

@KN4CK3R commented on GitHub (Feb 1, 2021): If your concern is security, that won't help.

GiteaMirror commented

2025-11-02 07:06:36 -06:00

@morph027 commented on GitHub (Feb 1, 2021):

Argh, you're right 🤦

@morph027 commented on GitHub (Feb 1, 2021): Argh, you're right :facepalm:

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6788