Render LFS text file on diff page #6747

New Issue

GiteaMirror · 2025-11-02T07:05:26-06:00

GiteaMirror commented

2025-11-02 07:05:26 -06:00

Originally created by @lunny on GitHub (Jan 25, 2021).

Currently all LFS files are considered as binary files but in fact it's not true. We have implemented render LFS file on tree view, so in diff page, we should also implement it.

Originally created by @lunny on GitHub (Jan 25, 2021). Currently all LFS files are considered as binary files but in fact it's not true. We have implemented render LFS file on tree view, so in diff page, we should also implement it.

GiteaMirror added the type/enhancement issue/needs-feedback labels 2025-11-02 07:05:26 -06:00

GiteaMirror closed this issue

2025-11-02 07:05:26 -06:00

GiteaMirror commented

2025-11-02 07:05:27 -06:00

@delvh commented on GitHub (Jan 27, 2021):

To save on computing power, we could also implement a mechanism similar to that used by GitHub where, if a file is too large/ contains to many differences, then the user has too manually click on "Load File" - "Large diffs are not rendered by default"

@delvh commented on GitHub (Jan 27, 2021): To save on computing power, we could also implement a mechanism similar to that used by GitHub where, if a file is too large/ contains to many differences, then the user has too manually click on "Load File" - "Large diffs are not rendered by default"

GiteaMirror commented

2025-11-02 07:05:27 -06:00

@wxiaoguang commented on GitHub (Apr 26, 2023):

If a file is put into LFS, I do not think we should touch it in the diff page.

Is it still a open proposal?

@wxiaoguang commented on GitHub (Apr 26, 2023): If a file is put into LFS, I do not think we should touch it in the diff page. Is it still a open proposal?

GiteaMirror commented

2025-11-02 07:05:27 -06:00

@lunny commented on GitHub (Apr 27, 2023):

I think it's very difficult because LFS storage is very different from git data. There is no patch, we need a diff tool but it maybe very slow. I think maybe we can close this one.

@lunny commented on GitHub (Apr 27, 2023): I think it's very difficult because LFS storage is very different from git data. There is no patch, we need a diff tool but it maybe very slow. I think maybe we can close this one.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6747