Local time zone in timestamps #6494

@zeripath commented on GitHub (Dec 11, 2020):

Paging @silverwind - is it possible recent changes to js have broken this?

@zeripath commented on GitHub (Dec 11, 2020): Paging @silverwind - is it possible recent changes to js have broken this?

GiteaMirror commented

@silverwind commented on GitHub (Dec 11, 2020):

No, I've never touched those. I remember suggesting them to be converted in JS to browser timezone but I think @lunny persisted that they should render in the server timezone.

@silverwind commented on GitHub (Dec 11, 2020): No, I've never touched those. I remember suggesting them to be converted in JS to browser timezone but I think @lunny persisted that they should render in the server timezone.

GiteaMirror commented

@Colin5887 commented on GitHub (Dec 11, 2020):

I've tested 1.9.0, 1.10.0, 1.11.0 and 1.12.0. They all have the same issue. This is also reproducible in https://try.gitea.io

Here: I create a repo 4 minutes ago and it's marked to be an operation yesterday.

BTW, I'm at AEDT.

@Colin5887 commented on GitHub (Dec 11, 2020): I've tested 1.9.0, 1.10.0, 1.11.0 and 1.12.0. They all have the same issue. This is also reproducible in https://try.gitea.io Here: I create a repo 4 minutes ago and it's marked to be an operation yesterday. ![image](https://user-images.githubusercontent.com/30656548/101957930-7ef87c00-3c56-11eb-8e06-528d33c7cafd.png) BTW, I'm at AEDT.

GiteaMirror commented

@lunny commented on GitHub (Jan 1, 2021):

See https://docs.gitea.io/en-us/config-cheat-sheet/#time-time . You can change the default time zone and even the format which will be displayed on UI.

@lunny commented on GitHub (Jan 1, 2021): See https://docs.gitea.io/en-us/config-cheat-sheet/#time-time . You can change the default time zone and even the format which will be displayed on UI.

GiteaMirror commented

@Colin5887 commented on GitHub (Jan 1, 2021):

@lunny I promise I change that and it works......partially works.

It only changes the time when the mouse hovers on the commit and the time IS correct now.
However, the table of contributions is still incorrect. A commit made at 9:30 is still marked as yesterday's work.
It is reproducible on https://try.gitea.io as well.

@Colin5887 commented on GitHub (Jan 1, 2021): @lunny I promise I change that and it works......partially works. It only changes the time when the mouse hovers on the commit and the time IS correct now. However, the table of contributions is still incorrect. A commit made at 9:30 is still marked as yesterday's work. It is reproducible on https://try.gitea.io as well.

GiteaMirror commented

@Colin5887 commented on GitHub (Jan 1, 2021):

@lunny The problem is not the time in the text format but the table.

I mean, the table:

@Colin5887 commented on GitHub (Jan 1, 2021): @lunny The problem is not the time in the text format but the table. I mean, the table: ![image](https://user-images.githubusercontent.com/30656548/103447101-da101280-4cda-11eb-8af9-b8fe78a9c665.png)

GiteaMirror commented

@lunny commented on GitHub (Jan 2, 2021):

@Colin5887 Your problem is not the same as this one. I think you can create a new issue so that we can track that.

@lunny commented on GitHub (Jan 2, 2021): @Colin5887 Your problem is not the same as this one. I think you can create a new issue so that we can track that.

GiteaMirror commented

@Colin5887 commented on GitHub (Jan 2, 2021):

@lunny Thanks, a new issue is created here: https://github.com/go-gitea/gitea/issues/14215

@Colin5887 commented on GitHub (Jan 2, 2021): @lunny Thanks, a new issue is created here: https://github.com/go-gitea/gitea/issues/14215

GiteaMirror commented

@mozoh commented on GitHub (Jan 2, 2021):

Why the issue has been closed? "Change timezone on server” is not the real solution.

@mozoh commented on GitHub (Jan 2, 2021): Why the issue has been closed? "Change timezone on server” is not the real solution.

GiteaMirror commented

@lunny commented on GitHub (Jan 2, 2021):

@mozoh see my reply https://github.com/go-gitea/gitea/issues/13925#issuecomment-753341604

@lunny commented on GitHub (Jan 2, 2021): @mozoh see my reply https://github.com/go-gitea/gitea/issues/13925#issuecomment-753341604

GiteaMirror commented

@mozoh commented on GitHub (Jan 2, 2021):

@lunny your reply is about changing default, but not for local timezone. Every client can have its own timezone, different from the server. So, there will no solution for this as i understand.

@mozoh commented on GitHub (Jan 2, 2021): @lunny your reply is about changing default, but not for local timezone. Every client can have its own timezone, different from the server. So, there will no solution for this as i understand.

GiteaMirror commented

@silverwind commented on GitHub (Jan 3, 2021):

Yes, we need some JS that runs during page load that converts timestamp to local. Should probably be inline so wrong timestamps never even render (can't put it in the main js bundle because that takes time to load).

@silverwind commented on GitHub (Jan 3, 2021): Yes, we need some JS that runs during page load that converts timestamp to local. Should probably be inline so wrong timestamps never even render (can't put it in the main js bundle because that takes time to load).

GiteaMirror commented