Commit hash and commiter avatar off in the PR view #6387

New Issue

GiteaMirror · 2025-11-02T06:54:20-06:00

GiteaMirror commented

2025-11-02 06:54:20 -06:00

Originally created by @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf on GitHub (Nov 26, 2020).

Gitea version (or commit ref): 1.14.0+dev-258-g03fa2eccb
Git version: git version 2.29.2.526.gbb4321173f
Operating system: Arch Linux
Built from
- source
Run with
- systemd
Database:
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- No

Description

Recently I have noticed this anomalously off-set commit hash+avatar labels in the PR view (see screenshots below).
Could this be somehow linked to the recent and otherwise awesome improvements brought by https://github.com/go-gitea/gitea/issues/13594?

Screenshots

Originally created by @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf on GitHub (Nov 26, 2020). - Gitea version (or commit ref): `1.14.0+dev-258-g03fa2eccb` - Git version: `git version 2.29.2.526.gbb4321173f` - Operating system: Arch Linux - Built from - [x] source - Run with - [x] systemd - Database: - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] No ## Description Recently I have noticed this anomalously off-set commit hash+avatar labels in the PR view (see screenshots below). Could this be somehow linked to the recent and otherwise awesome improvements brought by https://github.com/go-gitea/gitea/issues/13594? ## Screenshots ![image](https://user-images.githubusercontent.com/61180606/100299931-2d34ce00-2f95-11eb-9546-aaeda49b106c.png) ![image](https://user-images.githubusercontent.com/61180606/100300000-5a817c00-2f95-11eb-82c0-6b70d74107d6.png)

GiteaMirror closed this issue

2025-11-02 06:54:20 -06:00

GiteaMirror commented

2025-11-02 06:54:21 -06:00

@silverwind commented on GitHub (Nov 26, 2020):

Possible, those SHA boxes are currently a bit of a pain because they use like three different templates and three different CSS sections so issues like that are bound to arise eventually until they properly share template and CSS.

@silverwind commented on GitHub (Nov 26, 2020): Possible, those SHA boxes are currently a bit of a pain because they use like three different templates and three different CSS sections so issues like that are bound to arise eventually until they properly share template and CSS.

GiteaMirror commented

2025-11-02 06:54:21 -06:00

@CirnoT commented on GitHub (Nov 27, 2020):

Caused by https://github.com/go-gitea/gitea/pull/13594 by blindly forcing display: inline on Fomantic's ui.label element. Fomantic's label element can contain additional elements (such as .detail which is used here) which breaks when inline is forced.

Since we use Fomantic and this change explicitly breaks Fomantic styling, I suppose it will have to be reverted and better solution found (refering here to w/e the display: inline attempts to do, not whole PR).

@CirnoT commented on GitHub (Nov 27, 2020): Caused by https://github.com/go-gitea/gitea/pull/13594 by blindly forcing `display: inline` on Fomantic's `ui.label` element. Fomantic's label element can contain additional elements (such as `.detail` which is used here) which breaks when `inline` is forced. Since we use Fomantic and this change explicitly breaks Fomantic styling, I suppose it will have to be reverted and better solution found (refering here to w/e the `display: inline` attempts to do, not whole PR).

GiteaMirror commented

2025-11-02 06:54:21 -06:00

@CirnoT commented on GitHub (Nov 27, 2020):

Additionally it seems that the .detail element is now not matching with box itself (for some reason we're using padding and margin hack there), a quick fix would be to change it to:

margin: -3px -6px -3px 0;
padding: 3px 6px 3px 6px;

however I fear this might be font-related.

Possibly removing .button .icon would work better (this removes forced padding applied by Fomantic so we don't have to work around it with hacks)?

@CirnoT commented on GitHub (Nov 27, 2020): Additionally it seems that the `.detail` element is now not matching with box itself (for some reason we're using padding and margin hack there), a quick fix would be to change it to: ```css margin: -3px -6px -3px 0; padding: 3px 6px 3px 6px; ``` however I fear this might be font-related. Possibly removing `.button .icon` would work better (this removes forced padding applied by Fomantic so we don't have to work around it with hacks)?

GiteaMirror commented

2025-11-02 06:54:21 -06:00

@silverwind commented on GitHub (Nov 28, 2020):

That display: inline is for issue label lists only (so they wrap around and stuff), it should not match on that shabox.

@silverwind commented on GitHub (Nov 28, 2020): That `display: inline` is for issue label lists only (so they wrap around and stuff), it should not match on that shabox.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6387