github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-17 21:52:42 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

PR options disappears once unchecked. Can not enable Pull Requests again. #6227

New Issue
Closed
opened 2025-11-02 06:49:05 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-02 06:49:05 -06:00
Owner
Copy Link

Originally created by @tna76874 on GitHub (Oct 30, 2020).

  • Gitea version (or commit ref):
  • Git version: Gitea Version: 1.14.0+dev-106-g5b2096dd5
  • Operating system: docker
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (--> just create repo and disable PR in options)
    • No
  • Log gist:

Description

  1. Enter repository options
  2. uncheck "Activate Pull requests"
  3. Whole PR option area with all PR-related options are disappearing
  4. How to enable PR for repository again?

Screenshots

missing_PR_options

Originally created by @tna76874 on GitHub (Oct 30, 2020). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): - Git version: Gitea Version: 1.14.0+dev-106-g5b2096dd5 - Operating system: docker - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (--> just create repo and disable PR in options) - [ ] No - Log gist: ## Description 1. Enter repository options 2. uncheck "Activate Pull requests" 3. Whole PR option area with all PR-related options are disappearing 4. **How to enable PR for repository again?** ## Screenshots ![missing_PR_options](https://user-images.githubusercontent.com/47271687/97718252-05e9fe80-1ac6-11eb-8de4-6ae4558f3dbc.jpg)
GiteaMirror commented 2025-11-02 06:49:06 -06:00
Author
Owner
Copy Link

@jolheiser commented on GitHub (Oct 30, 2020):

I think this may be caused by #12808

Instead of checking if PRs can be enabled, it now checks if PRs are enabled. (assuming variables are named semantically)

643a0a691a/templates/repo/settings/options.tmpl (L287)

@jolheiser commented on GitHub (Oct 30, 2020): I think this may be caused by #12808 Instead of checking if PRs _can_ be enabled, it now checks if PRs _are_ enabled. (assuming variables are named semantically) https://github.com/go-gitea/gitea/blob/643a0a691a53a1c13a52edf0a09e8013394b07fe/templates/repo/settings/options.tmpl#L287
GiteaMirror commented 2025-11-02 06:49:06 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 30, 2020):

yup - this should be fixed in the same way as projects bit just above it.

643a0a691a/templates/repo/settings/options.tmpl (L274-L281)

@zeripath commented on GitHub (Oct 30, 2020): yup - this should be fixed in the same way as projects bit just above it. https://github.com/go-gitea/gitea/blob/643a0a691a53a1c13a52edf0a09e8013394b07fe/templates/repo/settings/options.tmpl#L274-L281
GiteaMirror commented 2025-11-02 06:49:06 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 30, 2020):

I suspect that simply changing line 287 to:

{{if not .IsMirror}}

might actually be enough?

@zeripath commented on GitHub (Oct 30, 2020): I suspect that simply changing line 287 to: ``` {{if not .IsMirror}} ``` might actually be enough?
GiteaMirror commented 2025-11-02 06:49:06 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Oct 30, 2020):

I'll add this change to #13360

@zeripath commented on GitHub (Oct 30, 2020): I'll add this change to #13360
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#6227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?