migration: pull requests show broken but they dont #6219

New Issue

GiteaMirror · 2025-11-02T06:48:49-06:00

GiteaMirror commented

2025-11-02 06:48:49 -06:00

Originally created by @6543 on GitHub (Oct 27, 2020).

gitea version: v1.13

gitea_uploader.go has to trigger Merge conflict checking is in progress for each pull after migration.

workaround: close & reopen a pull

Originally created by @6543 on GitHub (Oct 27, 2020). gitea version: v1.13 gitea_uploader.go has to trigger `Merge conflict checking is in progress` for each pull after migration. workaround: close & reopen a pull

GiteaMirror added the topic/repo-migration type/bug labels 2025-11-02 06:48:49 -06:00

GiteaMirror closed this issue

2025-11-02 06:48:49 -06:00

GiteaMirror commented

2025-11-02 06:48:50 -06:00

@ramasoft-dv commented on GitHub (Oct 27, 2020):

We do have that issue also and it's quite annoying.
For old PR (before migrating to 1.13), when we Update the branch we have the "Missing fork information ...".

The workaround from @6543 does not work for us. When we close the PR, we cannot reopen it : "This pull request cannot be reopened because the branch was deleted." (of course the branch is not deleted)
The only workaround we found is to merge the PR manually.

@ramasoft-dv commented on GitHub (Oct 27, 2020): We do have that issue also and it's quite annoying. For old PR (before migrating to 1.13), when we Update the branch we have the "Missing fork information ...". The workaround from @6543 does not work for us. When we close the PR, we cannot reopen it : "This pull request cannot be reopened because the branch was deleted." (of course the branch is not deleted) The only workaround we found is to merge the PR manually.

GiteaMirror commented

2025-11-02 06:48:50 -06:00

@6543 commented on GitHub (Oct 27, 2020):

@ramasoft-dv another workaround should be to push a new commit to the pull (could be an empty one too)

@6543 commented on GitHub (Oct 27, 2020): @ramasoft-dv another workaround should be to push a new commit to the pull (could be an empty one too)

GiteaMirror commented

2025-11-02 06:48:50 -06:00

@zeripath commented on GitHub (Oct 27, 2020):

diff --git a/modules/migrations/gitea_uploader.go b/modules/migrations/gitea_uploader.go
index cd1fd5cb8..466c83275 100644
--- a/modules/migrations/gitea_uploader.go
+++ b/modules/migrations/gitea_uploader.go
@@ -28,6 +28,7 @@ import (
        "code.gitea.io/gitea/modules/storage"
        "code.gitea.io/gitea/modules/structs"
        "code.gitea.io/gitea/modules/timeutil"
+       "code.gitea.io/gitea/services/pull"
 
        gouuid "github.com/google/uuid"
 )
@@ -524,6 +525,7 @@ func (g *GiteaLocalUploader) CreatePullRequests(prs ...*base.PullRequest) error
        }
        for _, pr := range gprs {
                g.issues.Store(pr.Issue.Index, pr.Issue.ID)
+               pull.AddToTaskQueue(pr)
        }
        return nil
 }

@zeripath commented on GitHub (Oct 27, 2020): ``` diff --git a/modules/migrations/gitea_uploader.go b/modules/migrations/gitea_uploader.go index cd1fd5cb8..466c83275 100644 --- a/modules/migrations/gitea_uploader.go +++ b/modules/migrations/gitea_uploader.go @@ -28,6 +28,7 @@ import ( "code.gitea.io/gitea/modules/storage" "code.gitea.io/gitea/modules/structs" "code.gitea.io/gitea/modules/timeutil" + "code.gitea.io/gitea/services/pull" gouuid "github.com/google/uuid" ) @@ -524,6 +525,7 @@ func (g *GiteaLocalUploader) CreatePullRequests(prs ...*base.PullRequest) error } for _, pr := range gprs { g.issues.Store(pr.Issue.Index, pr.Issue.ID) + pull.AddToTaskQueue(pr) } return nil } ```

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6219