Diffs are rendered incompletely #6188

Closed
opened 2025-11-02 06:47:42 -06:00 by GiteaMirror · 0 comments
Owner

Originally created by @lhinderberger on GitHub (Oct 21, 2020).

Parallel discussion at Codeberg: https://codeberg.org/Codeberg/Community/issues/313

Description

Hi everyone!

There seems to be a bug with the rendering of diffs in Gitea. It seems to me that whenever a diff contains an image, the diff is only rendered up to that image and all other files will not be rendered, although present in the commit that is to be displayed.

This can lead to code reviews being prevented, due to maintainers being unable to see the sourcecode (for example: https://codeberg.org/Codeberg/Documentation/pulls/99).

Screenshots

screenshot-gitea

Originally created by @lhinderberger on GitHub (Oct 21, 2020). - Gitea version (or commit ref): 1.12.5+25-g3dc7f2839 (Codeberg.org) - Can you reproduce the bug at https://try.gitea.io: - [X] Yes (provide example URL) - Commit that contains one PNG file and two Markdown files; only one of the two Markdown files is rendered: https://try.gitea.io/knut/incomplete-diff/commit/eb853fee9565e9d2d71dfb5f28a37a825a15feed - PR that shows the same effect on both the Commits and Changed Files tabs: https://try.gitea.io/knut/incomplete-diff/pulls/1 - [ ] No Parallel discussion at Codeberg: https://codeberg.org/Codeberg/Community/issues/313 ## Description Hi everyone! There seems to be a bug with the rendering of diffs in Gitea. It seems to me that whenever a diff contains an image, the diff is only rendered up to that image and all other files will not be rendered, although present in the commit that is to be displayed. This can lead to code reviews being prevented, due to maintainers being unable to see the sourcecode (for example: https://codeberg.org/Codeberg/Documentation/pulls/99). ## Screenshots ![screenshot-gitea](https://user-images.githubusercontent.com/5623987/96785990-e250f500-13ef-11eb-8fbf-f4802cc047d6.png)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#6188