Hyperlinks in comments to source code in pull request are rendered grey, they are difficult to spot #6074

New Issue

GiteaMirror · 2025-11-02T06:44:23-06:00

GiteaMirror commented

2025-11-02 06:44:23 -06:00

Originally created by @shaoran on GitHub (Oct 1, 2020).

Gitea version: 1.12.2
Git version:
Operating system:
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes, https://try.gitea.io/shaoran/hyperlink-test/pulls/2
- No
- Not relevant
Log gist:

Description

The hyperlinks inside review comments in pull request get the .text.grey class and the hyperlink are hard to see.

If you go to the Files Changed section of the pull request, you'll see that the style of the hyperlink is blue, so it is easy to read.

However, if you go to the Conversation tab of the same pull request, it's hard to realize that this is a hyperlink because it's almost black and matches the color of the surrounding text. That happens because the <a href="..."> tag is inside a <span class="text grey"> tag as you can see here:

It seems to me that there is an error with the ending tag of the <span class="text grey"> tag. Notice that there are also block elements (like <div>) inside the <span>, which are not allowed in an inline element like <span> anyway. See https://github.com/go-gitea/gitea/blob/master/templates/repo/issue/view_content/comments.tmpl#L488

Screenshots

Originally created by @shaoran on GitHub (Oct 1, 2020).   - Gitea version: 1.12.2 - Git version: - Operating system: - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [x] Yes, https://try.gitea.io/shaoran/hyperlink-test/pulls/2 - [ ] No - [ ] Not relevant - Log gist: ## Description The hyperlinks inside review comments in pull request get the `.text.grey` class and the hyperlink are hard to see. If you go to the [Files Changed](https://try.gitea.io/shaoran/hyperlink-test/pulls/2/files) section of the pull request, you'll see that the style of the hyperlink is blue, so it is easy to read. However, if you go to the [Conversation](https://try.gitea.io/shaoran/hyperlink-test/pulls/2) tab of the same pull request, it's hard to realize that this is a hyperlink because it's almost black and matches the color of the surrounding text. That happens because the `<a href="...">` tag is inside a `<span class="text grey">` tag as you can see here: ![](https://user-images.githubusercontent.com/113313/94786491-555ae300-03d1-11eb-982a-0ac9aba80971.png) It seems to me that there is an error with the ending tag of the `<span class="text grey">` tag. Notice that there are also block elements (like `<div>`) inside the `<span>`, which are not allowed in an inline element like `<span>` anyway. See https://github.com/go-gitea/gitea/blob/master/templates/repo/issue/view_content/comments.tmpl#L488 ## Screenshots ![hyperlink-test-side-by-side](https://user-images.githubusercontent.com/113313/94785624-327bff00-03d0-11eb-9992-6d37c70c2e1c.png)

GiteaMirror added the hacktoberfest topic/ui good first issue type/bug labels 2025-11-02 06:44:23 -06:00

GiteaMirror closed this issue

2025-11-02 06:44:23 -06:00

GiteaMirror commented

2025-11-02 06:44:24 -06:00

@mrsdizzie commented on GitHub (Oct 2, 2020):

Closed by linked pr

@mrsdizzie commented on GitHub (Oct 2, 2020): Closed by linked pr

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#6074