Rename gitea/conf/app.ini to app.ini.example #605

Closed
opened 2025-11-02 03:29:44 -06:00 by GiteaMirror · 8 comments
Owner

Originally created by @cez81 on GitHub (Apr 1, 2017).

The app.ini found in gitea/conf is not an active configuration file. To save the confusion it might be a good idea to rename it to app.ini.example.

Originally created by @cez81 on GitHub (Apr 1, 2017). The app.ini found in gitea/conf is not an active configuration file. To save the confusion it might be a good idea to rename it to app.ini.example.
GiteaMirror added the type/proposal label 2025-11-02 03:29:44 -06:00
Author
Owner

@tboerger commented on GitHub (Apr 1, 2017):

Why is it confusing? It's even not shipped with the binary.

@tboerger commented on GitHub (Apr 1, 2017): Why is it confusing? It's even not shipped with the binary.
Author
Owner

@andreynering commented on GitHub (Apr 1, 2017):

@tboerger Many people compile from source. I actually liked the idea. Alternatively could be an "example" folder.

@andreynering commented on GitHub (Apr 1, 2017): @tboerger Many people compile from source. I actually liked the idea. Alternatively could be an "example" folder.
Author
Owner

@strk commented on GitHub (Apr 2, 2017):

As far as I know conf/app.ini is actually what gets compiled into bindata,
for builds with the bindata tag, and is otherwise read from FS before
the custom one for other builds.

If that's confirmed, I think it shouldn't be renamed.

Note that bindata builds should not even have a conf/ directory as the
binary would be enough to run.

@strk commented on GitHub (Apr 2, 2017): As far as I know conf/app.ini is actually what gets compiled into bindata, for builds with the `bindata` tag, and is otherwise read from FS before the custom one for other builds. If that's confirmed, I think it shouldn't be renamed. Note that bindata builds should not even have a conf/ directory as the binary would be enough to run.
Author
Owner

@cez81 commented on GitHub (Apr 2, 2017):

Yes, that's what I thought but if I have understood it correctly all defaults are loaded from modules/setting/setting.go. Only reference that I can find is in gogs_migration.sh

In Gogs it works like you have described it.

@cez81 commented on GitHub (Apr 2, 2017): Yes, that's what I thought but if I have understood it correctly all defaults are loaded from modules/setting/setting.go. Only reference that I can find is in gogs_migration.sh In Gogs it works like you have described it.
Author
Owner

@strk commented on GitHub (Apr 2, 2017):

Interesting, I confirm you can actually move away the conf/ directory
even with non-bindata build. I'm not sure renaming to .example but keeping
it in that dir helps anyone though, because dropping the .example part
would still have no effect unless it's moved to the custom dir.

@strk commented on GitHub (Apr 2, 2017): Interesting, I confirm you can actually move away the conf/ directory even with non-bindata build. I'm not sure renaming to .example but keeping it in that dir helps anyone though, because dropping the .example part would still have no effect unless it's moved to the custom dir.
Author
Owner

@cez81 commented on GitHub (Apr 2, 2017):

Good point. Renaming the folder and explaining the purpose of the file might be a better idea.

@cez81 commented on GitHub (Apr 2, 2017): Good point. Renaming the folder and explaining the purpose of the file might be a better idea.
Author
Owner

@bkcsoft commented on GitHub (Apr 18, 2017):

You have my 👍 on changing the name of the file/folder

@tboerger We still have to consider people that don't install from binary 😉

@bkcsoft commented on GitHub (Apr 18, 2017): You have my 👍 on changing the name of the file/folder @tboerger We still have to consider people that don't install from binary 😉
Author
Owner

@cez81 commented on GitHub (Nov 26, 2017):

Closed by #1522

@cez81 commented on GitHub (Nov 26, 2017): Closed by #1522
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#605