Add more info about project management to CONTRIBUTING.md #601

New Issue

GiteaMirror · 2025-11-02T03:29:36-06:00

GiteaMirror commented

2025-11-02 03:29:36 -06:00

Originally created by @strk on GitHub (Apr 1, 2017).

The CONTRIBUTING.md file only partially describe the project management policy:

it doesn't mention who has merge powers and how such powers are obtained
it does not say that maintainers have veto powers on pull requests ("requested change" effectively gives veto powers at the moment)
it doesn't describe any way to deal with stale PRs/issues or inactive maintainers (minor issue at this moment, but still useful to have)

Originally created by @strk on GitHub (Apr 1, 2017). The `CONTRIBUTING.md` file only partially describe the project management policy: - it doesn't mention who has merge powers and how such powers are obtained - it does not say that maintainers have veto powers on pull requests ("requested change" effectively gives veto powers at the moment) - it doesn't describe any way to deal with stale PRs/issues or inactive maintainers (minor issue at this moment, but still useful to have)

GiteaMirror added the type/docs issue/stale labels 2025-11-02 03:29:36 -06:00

GiteaMirror closed this issue

2025-11-02 03:29:36 -06:00

GiteaMirror commented

2025-11-02 03:29:37 -06:00

@bkcsoft commented on GitHub (Apr 18, 2017):

Anyone can use "request change" AFAIK, if not everyone should have that.

As for stale PRs/issues, anyone can pro-actively ask for feedback, if nothing is done for a month I propose closing it. Reporter/Contributor can re-open if the become active again. (Not documented, only proposed, should be documented if agreed opon)

@bkcsoft commented on GitHub (Apr 18, 2017): Anyone can use "request change" AFAIK, if not everyone _should_ have that. As for stale PRs/issues, anyone can pro-actively ask for feedback, if nothing is done for a month I propose closing it. Reporter/Contributor can re-open if the become active again. (Not documented, only proposed, should be documented if agreed opon)

GiteaMirror commented

2025-11-02 03:29:37 -06:00

@strk commented on GitHub (Apr 18, 2017):

On Tue, Apr 18, 2017 at 12:20:08AM -0700, bkcsoft wrote:

Anyone can use "request change" AFAIK, if not everyone should have that.

You mean any maintainer, right ?
While I agree it's important that anyone can request changes, making it
easy to raise a barrier would basically let a minority block what the
majority would agree to instead merge.
How can a change request be set off by others ?

As for stale PRs/issues, anyone can pro-actively ask for feedback, if nothing is done for a month I propose closing it. Reporter/Contributor can re-open if the become active again. (Not documented, only proposed, should be documented if agreed opon)

I agree on automatically closing after a period of silence from the
proponent (which we need to allow changing over time). Maybe the period
could be 2 weeks too, but I'm ok with 1 month if that helps reaching
an agreement sooner.

@strk commented on GitHub (Apr 18, 2017): On Tue, Apr 18, 2017 at 12:20:08AM -0700, bkcsoft wrote: > Anyone can use "request change" AFAIK, if not everyone _should_ have that. You mean any *maintainer*, right ? While I agree it's important that anyone can request changes, making it easy to raise a barrier would basically let a minority block what the majority would agree to instead merge. How can a change request be set off by others ? > As for stale PRs/issues, anyone can pro-actively ask for feedback, if nothing is done for a month I propose closing it. Reporter/Contributor can re-open if the become active again. (Not documented, only proposed, should be documented if agreed opon) I agree on automatically closing after a period of silence from the proponent (which we need to allow changing over time). Maybe the period could be 2 weeks too, but I'm ok with 1 month if that helps reaching an agreement sooner.

GiteaMirror commented

2025-11-02 03:29:37 -06:00

@bkcsoft commented on GitHub (Apr 19, 2017):

You mean any maintainer, right ?

Haven't looked into the permissions, but IMO yes, any maintainer.

would let a minority block what the majority would agree to instead merge.

This is where it gets tricky, what if the minority block is correct in blocking it? (see my Status-API PR for example where I'm using TEXT INDEX which isn't possible on MySQL). Once the PR has been updated to fix the issue any Owner can simply reject the request if the requester doesn't approve it themselfs.

@bkcsoft commented on GitHub (Apr 19, 2017): > You mean any *maintainer*, right ? Haven't looked into the permissions, but IMO yes, any *maintainer*. > would let a minority block what the majority would agree to instead merge. This is where it gets tricky, what if the minority block is correct in blocking it? (see my Status-API PR for example where I'm using `TEXT INDEX` which isn't possible on MySQL). Once the PR has been updated to fix the issue any Owner can simply reject the request if the requester doesn't approve it themselfs.

GiteaMirror commented

2025-11-02 03:29:37 -06:00

@stale[bot] commented on GitHub (Jan 27, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Jan 27, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 03:29:37 -06:00

@lunny commented on GitHub (Feb 7, 2019):

@strk is this still an issue?

@lunny commented on GitHub (Feb 7, 2019): @strk is this still an issue?

GiteaMirror commented

2025-11-02 03:29:37 -06:00

@stale[bot] commented on GitHub (Feb 21, 2019):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (Feb 21, 2019): This issue has been automatically closed because of inactivity. You can re-open it if needed.

GiteaMirror referenced this issue

2025-11-02 03:52:20 -06:00