Two Factor Authentication on Gitea #59

@metalmatze commented on GitHub (Nov 15, 2016):

Yesterday I thought about exactly this feature. I really want that too and would like to contribute to this as well. Has anyone tried any lib for 2fa in Go?

@metalmatze commented on GitHub (Nov 15, 2016): Yesterday I thought about exactly this feature. I really want that too and would like to contribute to this as well. Has anyone tried any lib for 2fa in Go?

GiteaMirror commented

@thibaultmeyer commented on GitHub (Nov 15, 2016):

It would be nice if U2F - FIDO Universal 2nd Factor Authentication will be implemented too. It allow usage of USB key rather than SMS / Mail. A GO library exists : https://developers.yubico.com/U2F/Libraries/List_of_libraries.html

@thibaultmeyer commented on GitHub (Nov 15, 2016): It would be nice if U2F - FIDO Universal 2nd Factor Authentication will be implemented too. It allow usage of USB key rather than SMS / Mail. A GO library exists : https://developers.yubico.com/U2F/Libraries/List_of_libraries.html

GiteaMirror commented

@gencer commented on GitHub (Nov 15, 2016):

@0xbaadf00d this can be useful, yes, but, many people use a traditional way for 2FA -including me-. So at least for starting, we should have 2FA enabled. If we make generalize, im pretty sure that 2FA users are most.

Correct me If I am wrong.

@gencer commented on GitHub (Nov 15, 2016): @0xbaadf00d this can be useful, yes, but, many people use a traditional way for 2FA -including me-. So at least for starting, we should have 2FA enabled. If we make generalize, im pretty sure that 2FA users are most. Correct me If I am wrong.

GiteaMirror commented

@thibaultmeyer commented on GitHub (Nov 15, 2016):

@gencer U2F FIDO is 2FA too, but it allow usage of an cryptographic USB Key. By exemple Github propose U2F FIDO or Token generated via "Authenticator" mobile app.

You can read more at https://help.github.com/articles/configuring-two-factor-authentication-via-fido-u2f/

We have just to keep in mind to get something modular with the possibility to add new 2FA methods in future

@thibaultmeyer commented on GitHub (Nov 15, 2016): @gencer U2F FIDO is 2FA too, but it allow usage of an cryptographic USB Key. By exemple Github propose U2F FIDO or Token generated via "Authenticator" mobile app. You can read more at https://help.github.com/articles/configuring-two-factor-authentication-via-fido-u2f/ We have just to keep in mind to get something modular with the possibility to add new 2FA methods in future

GiteaMirror commented

@tboerger commented on GitHub (Nov 15, 2016):

But this won't get into 1.0.0 as this is a release that will be done pretty soon. Maybe we can integrate it for 1.1.0 or 1.2.0.

@tboerger commented on GitHub (Nov 15, 2016): But this won't get into 1.0.0 as this is a release that will be done pretty soon. Maybe we can integrate it for 1.1.0 or 1.2.0.

GiteaMirror commented

@lunny commented on GitHub (Nov 16, 2016):

Yes, this should be enabled on admin panel. It should not be a default setting.

@lunny commented on GitHub (Nov 16, 2016): Yes, this should be enabled on admin panel. It should not be a default setting.

GiteaMirror commented

@strk commented on GitHub (Nov 16, 2016):

Agreed this cannot be in 1.0.0.
Open for 1.1+, as soon as a PR is ready :)

@strk commented on GitHub (Nov 16, 2016): Agreed this cannot be in 1.0.0. Open for 1.1+, as soon as a PR is ready :)

GiteaMirror commented

@stevenroose commented on GitHub (Nov 16, 2016):

Might go good with #183

@stevenroose commented on GitHub (Nov 16, 2016): Might go good with #183

GiteaMirror commented

@mmoya commented on GitHub (Jan 6, 2017):

FTR, a proof of concept for gogits/gogs#945 was posted to 5cd29970a3.

@mmoya commented on GitHub (Jan 6, 2017): FTR, a proof of concept for gogits/gogs#945 was posted to https://github.com/minecrafter/gogs/commit/5cd29970a39ba273a4d1115373099c7615353902.

GiteaMirror commented

@lunny commented on GitHub (Jan 6, 2017):

@mmoya, Could you send a PR to Gitea?

@lunny commented on GitHub (Jan 6, 2017): @mmoya, Could you send a PR to Gitea?

GiteaMirror commented

@gencer commented on GitHub (Jan 6, 2017):

@lunny as soon as PR accepted, I will try on brand new server with fresh config for better result and for one to the existing installation to see how its going on. I am preparing a new test server until PR accepted. (Otherwise, I will try target PR source myself)

@gencer commented on GitHub (Jan 6, 2017): @lunny as soon as PR accepted, I will try on brand new server with fresh config for better result and for one to the existing installation to see how its going on. I am preparing a new test server until PR accepted. (Otherwise, I will try target PR source myself)

GiteaMirror commented

@mmoya commented on GitHub (Jan 9, 2017):

@lunny, I'll ask OP first. @minecrafter, are you willing to submit a PR to gitea with your 2fa proof-of-concept?

@mmoya commented on GitHub (Jan 9, 2017): @lunny, I'll ask OP first. @minecrafter, are you willing to submit a PR to gitea with your 2fa proof-of-concept?

GiteaMirror commented

@minecrafter commented on GitHub (Jan 9, 2017):

I'm assuming the only reason I was mentioned was because I did make this attempt to support 2FA from the parent project.

~~Unfortunately, I do not think I will have the time to continue working on projects like Gitea and Gogs. However, you are free to expand upon my initial work.~~

@minecrafter commented on GitHub (Jan 9, 2017): I'm assuming the only reason I was mentioned was because I did make [this attempt to support 2FA from the parent project](https://github.com/minecrafter/gogs/tree/2fa). ~~Unfortunately, I do not think I will have the time to continue working on projects like Gitea and Gogs. However, you are free to expand upon my initial work.~~

GiteaMirror commented

@minecrafter commented on GitHub (Jan 9, 2017):

After getting some more background information, I might be willing to contribute two-factor authentication support to the project. I too have been a former Gogs contributor who was stalled by the maintainer.

@minecrafter commented on GitHub (Jan 9, 2017): After getting some more background information, I might be willing to contribute two-factor authentication support to the project. I too have been a former Gogs contributor who was stalled by the maintainer.

GiteaMirror commented

@lunny commented on GitHub (Jan 9, 2017):

@minecrafter you are welcome back!

@lunny commented on GitHub (Jan 9, 2017): @minecrafter you are welcome back!

GiteaMirror commented

@minecrafter commented on GitHub (Jan 9, 2017):

@lunny Thanks! 👍

@minecrafter commented on GitHub (Jan 9, 2017): @lunny Thanks! :+1:

GiteaMirror commented