Multiple review textarea after comment code #5883

Closed
opened 2025-11-02 06:39:15 -06:00 by GiteaMirror · 11 comments
Owner

Originally created by @davidglezz on GitHub (Aug 23, 2020).

  • Gitea version (or commit ref): 12.3 +
  • Git version:
  • Operating system: Ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Adding or editing a code comment causes multiple textarea fields to appear in the review button popover.

Screenshots

image

Originally created by @davidglezz on GitHub (Aug 23, 2020). - Gitea version (or commit ref): 12.3 + - Git version: - Operating system: Ubuntu - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [ ] Not relevant - Log gist: ## Description Adding or editing a code comment causes multiple textarea fields to appear in the review button popover. ## Screenshots ![image](https://user-images.githubusercontent.com/194784/90975369-cf2ac180-e533-11ea-8683-88bf8a126c42.png)
GiteaMirror added the type/bug label 2025-11-02 06:39:15 -06:00
Author
Owner

@zeripath commented on GitHub (Oct 5, 2020):

does this still occur on 1.12.5? I'm fairly certain I've already fixed this.

@zeripath commented on GitHub (Oct 5, 2020): does this still occur on 1.12.5? I'm fairly certain I've already fixed this.
Author
Owner

@davidglezz commented on GitHub (Oct 5, 2020):

Sorry, the problem stills in 1.12.5.
Adding comments seems to work fine, but editing one shows that the problem is still present.

@davidglezz commented on GitHub (Oct 5, 2020): Sorry, the problem stills in 1.12.5. Adding comments seems to work fine, but editing one shows that the problem is still present.
Author
Owner

@zeripath commented on GitHub (Oct 5, 2020):

Can you get it to occur on try?

@zeripath commented on GitHub (Oct 5, 2020): Can you get it to occur on try?
Author
Owner

@davidglezz commented on GitHub (Oct 6, 2020):

I have never compiled gitea, is there any way, for example with a docker, to compile without having to install all the tools?
https://docs.gitea.io/en-us/install-from-source/

@davidglezz commented on GitHub (Oct 6, 2020): I have never compiled gitea, is there any way, for example with a docker, to compile without having to install all the tools? https://docs.gitea.io/en-us/install-from-source/
Author
Owner

@zeripath commented on GitHub (Oct 6, 2020):

Oh actually thinking on I think the attached pr is likely fixing a different problem... your problem appears to be in the review comment box on the files page of a pr right?

In terms of compiling Gitea - unfortunately you'd need to install the tools. Were you thinking of compiling on doze?

@zeripath commented on GitHub (Oct 6, 2020): Oh actually thinking on I think the attached pr is likely fixing a different problem... your problem appears to be in the review comment box on the files page of a pr right? In terms of compiling Gitea - unfortunately you'd need to install the tools. Were you thinking of compiling on doze?
Author
Owner

@davidglezz commented on GitHub (Oct 6, 2020):

Oh actually thinking on I think the attached pr is likely fixing a different problem... your problem appears to be in the review comment box on the files page of a pr right?

Yes

@davidglezz commented on GitHub (Oct 6, 2020): > Oh actually thinking on I think the attached pr is likely fixing a different problem... your problem appears to be in the review comment box on the files page of a pr right? Yes
Author
Owner

@zeripath commented on GitHub (Oct 6, 2020):

Can you tell me exactly how to replicate on try.gitea.io ? I'm struggling to replicate this.

@zeripath commented on GitHub (Oct 6, 2020): Can you tell me exactly how to replicate on try.gitea.io ? I'm struggling to replicate this.
Author
Owner

@davidglezz commented on GitHub (Oct 6, 2020):

Cant reproduce in Gitea Version: 1.13.0+dev-737-gc584364b9
https://try.gitea.io/davidglezz2/issue-12573/

@davidglezz commented on GitHub (Oct 6, 2020): Cant reproduce in Gitea Version: 1.13.0+dev-737-gc584364b9 https://try.gitea.io/davidglezz2/issue-12573/
Author
Owner

@davidglezz commented on GitHub (Oct 6, 2020):

But the problem may not appear because a javascript error occurs when saving or canceling the comment edition.
image

@davidglezz commented on GitHub (Oct 6, 2020): But the problem may not appear because a javascript error occurs when saving or canceling the comment edition. ![image](https://user-images.githubusercontent.com/194784/95189912-d3066080-07ce-11eb-89e0-8b92cd4ee749.png)
Author
Owner

@zeripath commented on GitHub (Oct 6, 2020):

OK the emit error appears to be another issue with dropzone that's quite easy to fix and I've copied it in to #13036

@zeripath commented on GitHub (Oct 6, 2020): OK the emit error appears to be another issue with dropzone that's quite easy to fix and I've copied it in to #13036
Author
Owner

@wxiaoguang commented on GitHub (Apr 29, 2022):

Outdated

@wxiaoguang commented on GitHub (Apr 29, 2022): Outdated
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5883