Mirror Task: System message say: "finished" but the task is still running #5834

Closed
opened 2025-11-02 06:37:29 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @somera on GitHub (Aug 6, 2020).

  • Gitea version (or commit ref): 1.12.3
  • Git version: 2.25.1
  • Operating system: Ubuntu 20.04
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I have only screenshots. I started it mynually (why there is no system message, that the task was started?). Than I saw the message:

Task: Update Mirrors started by gitea_admin has finished

and wanted shutdown the server. But ... the monitoring page say: "Stop, the task is still running."

And I'm missing the time Information in the detail status to the action. Will be helpfull if you will match this with the logs.

Screenshots

image

image

image

Originally created by @somera on GitHub (Aug 6, 2020). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): 1.12.3 - Git version: 2.25.1 - Operating system: Ubuntu 20.04 - Database (use `[x]`): - [x] PostgreSQL - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: ## Description I have only screenshots. I started it mynually (why there is no system message, that the task was started?). Than I saw the message: `Task: Update Mirrors started by gitea_admin has finished` and wanted shutdown the server. But ... the monitoring page say: "Stop, the task is still running." And I'm missing the time Information in the detail status to the action. Will be helpfull if you will match this with the logs. ## Screenshots ![image](https://user-images.githubusercontent.com/8334250/89528620-a395a080-d7eb-11ea-854b-c6015293296a.png) ![image](https://user-images.githubusercontent.com/8334250/89528633-a7c1be00-d7eb-11ea-9991-25cbb4764f23.png) ![image](https://user-images.githubusercontent.com/8334250/89528906-1e5ebb80-d7ec-11ea-953f-a4198eb13d8d.png)
Author
Owner

@somera commented on GitHub (Aug 6, 2020):

Some minutes after the post ...

image

Still running.

@somera commented on GitHub (Aug 6, 2020): Some minutes after the post ... ![image](https://user-images.githubusercontent.com/8334250/89529180-93ca8c00-d7ec-11ea-9a5f-099f2267401f.png) Still running.
Author
Owner

@somera commented on GitHub (Aug 6, 2020):

... running

image

@somera commented on GitHub (Aug 6, 2020): ... running ![image](https://user-images.githubusercontent.com/8334250/89529371-e86e0700-d7ec-11ea-9482-5a0f1e39d5d5.png)
Author
Owner

@zeripath commented on GitHub (Aug 6, 2020):

Please ignore the system notices for UpdateMirror they don't mean what they imply they do and therefore I've just merged a PR that means they are going to stop appearing soon.

@zeripath commented on GitHub (Aug 6, 2020): Please ignore the system notices for UpdateMirror they don't mean what they imply they do and therefore I've just merged a PR that means they are going to stop appearing soon.
Author
Owner

@somera commented on GitHub (Aug 6, 2020):

Ok. Bit and information, that the process is finished will be better/helpful.

@somera commented on GitHub (Aug 6, 2020): Ok. Bit and information, that the process is finished will be better/helpful.
Author
Owner

@zeripath commented on GitHub (Aug 6, 2020):

The issue is that the UpdateMirror task simply adds the repo ID to a queue of mirrors to be updated - that's all that the task does. The actual work of updating mirrors is done by the syncMirror function. That's the place that should be sending a repository notice to say it's been updated and by how much - however, as we've noted that could cause a lot of messages. We need to think a bit more about these things.

@zeripath commented on GitHub (Aug 6, 2020): The issue is that the UpdateMirror task simply adds the repo ID to a queue of mirrors to be updated - that's all that the task does. The actual work of updating mirrors is done by the syncMirror function. That's the place that should be sending a repository notice to say it's been updated and by how much - however, as we've noted that could cause a lot of messages. We need to think a bit more about these things.
Author
Owner

@somera commented on GitHub (Aug 6, 2020):

thx for the feedback!

@somera commented on GitHub (Aug 6, 2020): thx for the feedback!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5834