github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-25 07:56:03 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Block password-only auth when 2FA is enabled #579

New Issue
Closed
opened 2025-11-02 03:28:43 -06:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-02 03:28:43 -06:00
Owner
Copy Link

Originally created by @rugk on GitHub (Mar 27, 2017).

  • Gitea version (or commit ref): 1.1.0
  • Operating system: Debian
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
    • Not tested yet

Description

When 2FA is enabled Gitea should block the authentication via password and require auth tokens.
The current behaviour is to allow authentication via git even with 2FA enabled. This, however, defeats the whole point of 2FA: This way users/attackers can perform git actions (aka login, push code, etc.) without authenticating with the 2FA method.

Originally created by @rugk on GitHub (Mar 27, 2017). - Gitea version (or commit ref): 1.1.0 - Operating system: Debian - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [ ] Not relevant - [x] Not tested yet ## Description When 2FA is enabled Gitea should block the authentication via password and require auth tokens. The current behaviour is to allow authentication via git even with 2FA enabled. This, however, defeats the whole point of 2FA: This way users/attackers can perform git actions (aka login, push code, etc.) without authenticating with the 2FA method.
GiteaMirror added the type/bug label 2025-11-02 03:28:43 -06:00
GiteaMirror commented 2025-11-02 03:28:44 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 28, 2017):

@minecrafter maybe you can see this issue.

@lunny commented on GitHub (Mar 28, 2017): @minecrafter maybe you can see this issue.
GiteaMirror commented 2025-11-02 03:28:44 -06:00
Author
Owner
Copy Link

@minecrafter commented on GitHub (Mar 31, 2017):

I might be able to find time to work on this next week.

@minecrafter commented on GitHub (Mar 31, 2017): I might be able to find time to work on this next week.
GiteaMirror commented 2025-11-02 03:28:45 -06:00
Author
Owner
Copy Link

@moritzheiber commented on GitHub (Jul 19, 2017):

@minecrafter This is a serious security issue, as users are able to circumvent 2FA with regular Git commands .. could this be re-prioritized? IMHO it needs fixing yesterday 😦

@moritzheiber commented on GitHub (Jul 19, 2017): @minecrafter This is a serious security issue, as users are able to circumvent 2FA with regular Git commands .. could this be re-prioritized? IMHO it needs fixing yesterday :frowning:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#579
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?