installer: Current handling of form "Domain" seems questionable #571

New Issue

GiteaMirror · 2025-11-02T03:28:34-06:00

GiteaMirror commented

2025-11-02 03:28:34 -06:00

Originally created by @pmattern on GitHub (Mar 24, 2017).

Gitea version (or commit ref): 6a451a2b
Git version: 2.12.1
Operating system: Arch Linux x86_64
Database (use [x]):
- PostgreSQL 9.6.1
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant

Description

The value of form "Application General Settings" - "Domain" is currently assigned to directive [server] - SSH_DOMAIN in app.ini. According to the template directive SSH_DOMAIN is by default adopting the value of DOMAIN, but not the other way around. All in all just using the installer and filing a custom value in form "Domain" results in an instance using different values of the two directives {SSH_,}DOMAIN.

So far I haven't seen any malfunction due to this, yet I think it's weird behaviour. I guess it would be better to assign the value of form "Domain" to DOMAIN as this results in consistency when a custom value is filed in form "Domain" and no further tweaking of app.ini takes place.

Similar problems have been addressed in #785 and #552.

Originally created by @pmattern on GitHub (Mar 24, 2017). - Gitea version (or commit ref): 6a451a2b - Git version: 2.12.1 - Operating system: Arch Linux x86_64 - Database (use `[x]`): - [x] PostgreSQL 9.6.1 - [ ] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant ## Description The value of form "Application General Settings" - "Domain" is currently assigned to directive `[server]` - `SSH_DOMAIN` in `app.ini`. According to the [template](https://github.com/go-gitea/gitea/blob/6a451a2b5986bf5c27f20a00000495da1064c386/conf/app.ini) directive `SSH_DOMAIN` is by default adopting the value of `DOMAIN`, but not the other way around. All in all just using the installer and filing a custom value in form "Domain" results in an instance using different values of the two directives `{SSH_,}DOMAIN`. So far I haven't seen any malfunction due to this, yet I think it's weird behaviour. I guess it would be better to assign the value of form "Domain" to `DOMAIN` as this results in consistency when a custom value is filed in form "Domain" and no further tweaking of `app.ini` takes place. Similar problems have been addressed in #785 and #552.

GiteaMirror added the type/question issue/stale labels 2025-11-02 03:28:34 -06:00

GiteaMirror closed this issue

2025-11-02 03:28:34 -06:00

GiteaMirror commented

2025-11-02 03:28:35 -06:00

@stale[bot] commented on GitHub (Feb 16, 2019):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale[bot] commented on GitHub (Feb 16, 2019): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

GiteaMirror commented

2025-11-02 03:28:35 -06:00

@lunny commented on GitHub (Feb 28, 2019):

I think this should not be a problem any more.

@lunny commented on GitHub (Feb 28, 2019): I think this should not be a problem any more.

GiteaMirror referenced this issue

2025-11-02 11:47:03 -06:00

[PR #571] [MERGED] Keep email private #15461

Sign in to join this conversation.