Organization custom avatar only gets updated on browser cache reset #56

Closed
opened 2025-11-02 03:06:24 -06:00 by GiteaMirror · 10 comments
Owner

Originally created by @gencer on GitHub (Nov 13, 2016).

When a new organization avatar get uploaded you get a message says:

Organization avatar setting has been updated successfully.

File is uploaded to data/avatars/{orgId} but it does not show up on frontend.

Until you Ctrl+ F5 or reset browser cache. It should reflect change immediately.

Originally created by @gencer on GitHub (Nov 13, 2016). When a new organization avatar get uploaded you get a message says: `Organization avatar setting has been updated successfully.` File is uploaded to `data/avatars/{orgId}` but it does not show up on frontend. Until you Ctrl+ F5 or reset browser cache. It should reflect change immediately.
GiteaMirror added the type/bug label 2025-11-02 03:06:24 -06:00
Author
Owner

@thibaultmeyer commented on GitHub (Nov 13, 2016):

Maybe you have cache. Try to call directly /avatars/{id} (use force refresh: CTRL-SHIFT-R on Chrome) and refresh organisation page.

@thibaultmeyer commented on GitHub (Nov 13, 2016): Maybe you have cache. Try to call directly `/avatars/{id}` (use force refresh: CTRL-SHIFT-R on Chrome) and refresh organisation page.
Author
Owner

@gencer commented on GitHub (Nov 13, 2016):

Indeed I had a cache.

@gencer commented on GitHub (Nov 13, 2016): Indeed I had a cache.
Author
Owner

@tboerger commented on GitHub (Nov 24, 2016):

So let's refine the cache headers for the avatars.

@tboerger commented on GitHub (Nov 24, 2016): So let's refine the cache headers for the avatars.
Author
Owner

@Bwko commented on GitHub (Jan 5, 2017):

It looks like this issue got fixed

@Bwko commented on GitHub (Jan 5, 2017): It looks like this issue got fixed
Author
Owner

@lunny commented on GitHub (Jan 6, 2017):

Really? But which PR fixed this?

@lunny commented on GitHub (Jan 6, 2017): Really? But which PR fixed this?
Author
Owner

@Bwko commented on GitHub (Jan 6, 2017):

@lunny Nvm somehow disable cache was checked >_<

@Bwko commented on GitHub (Jan 6, 2017): @lunny Nvm somehow disable cache was checked >_<
Author
Owner

@lunny commented on GitHub (Jan 6, 2017):

Then, just close this one? @gencer could you confirm this is resolved?

@lunny commented on GitHub (Jan 6, 2017): Then, just close this one? @gencer could you confirm this is resolved?
Author
Owner

@Bwko commented on GitHub (Jan 7, 2017):

@lunny No, my browser did not cache any images so it looked like it was fixed.
I've create a branch to add ETag headers to macaron and fixing this issue.
Maybe we should fork macaron to add things like this?

@Bwko commented on GitHub (Jan 7, 2017): @lunny No, my browser did not cache any images so it looked like it was fixed. I've create a [branch](https://github.com/Bwko/macaron/tree/etag) to add ETag headers to macaron and fixing this issue. Maybe we should fork macaron to add things like this?
Author
Owner

@lunny commented on GitHub (Jan 8, 2017):

fork macaron and send PR to the original? Maybe we will change macaron to other framework some time.

@lunny commented on GitHub (Jan 8, 2017): fork macaron and send PR to the original? Maybe we will change macaron to other framework some time.
Author
Owner

@Bwko commented on GitHub (Jan 8, 2017):

@lunny Done, now I hope that Unknwon merges this PR in the next couple of days.

@Bwko commented on GitHub (Jan 8, 2017): @lunny Done, now I hope that Unknwon merges this PR in the next couple of days.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#56