Install form layout is broken #550

@Fastidious commented on GitHub (Mar 20, 2017):

AFAIK, the master holds daily changes, and can be broken at times. If you can't bare with that, stick to releases.

That been said, it is good to know when things are broken. The commit you mention was sent in by @strk, maybe he will take a look at it, and fix it.

@Fastidious commented on GitHub (Mar 20, 2017): AFAIK, the `master` holds daily changes, and can be broken at times. If you can't bare with that, stick to [releases](https://github.com/go-gitea/gitea/releases). That been said, it is good to know when things are broken. The commit you mention was sent in by @strk, maybe he will take a look at it, and fix it.

GiteaMirror commented

@tboerger commented on GitHub (Mar 20, 2017):

I wouldn't directly call it broken as still seems to work, but it looks bad/ugly.

@tboerger commented on GitHub (Mar 20, 2017): I wouldn't directly call it broken as still seems to work, but it looks bad/ugly.

GiteaMirror commented

@Fastidious commented on GitHub (Mar 20, 2017):

@tboerger semantics. It looks pretty broken to me. Usable, but broken.

@Fastidious commented on GitHub (Mar 20, 2017): @tboerger semantics. It looks pretty broken to me. Usable, but broken.

GiteaMirror commented

@lunny commented on GitHub (Mar 21, 2017):

It's broken I think. @strk

@lunny commented on GitHub (Mar 21, 2017): It's broken I think. @strk

GiteaMirror commented

@strk commented on GitHub (Mar 21, 2017):

Tge only change in a9de85d31d is adding !important to some CSS and was done by less compiler. Are you sure that revertig that fixes the issue ? (Watch out for browser cache)

@strk commented on GitHub (Mar 21, 2017): Tge only change in https://github.com/go-gitea/gitea/commit/a9de85d31d8ba3ce8801d03e66866e527f5f39d7 is adding !important to some CSS and was done by `less` compiler. Are you sure that revertig that fixes the issue ? (Watch out for browser cache)

GiteaMirror commented

@aloupfor commented on GitHub (Mar 21, 2017):

Here is what make think that it was since a9de85d31d.

$git log --oneline
888dee3 fix delete user failed on sqlite (#1321)
bd8fe49 fix wiki bugs (#1294)
dbabc35 Delete the useless code (#1335)
5586445 LFS: Return 404 for unimplemented endpoints (#1330)
9182a35 Show user OpenID URIs in their profile (#1314)
e158689 Add change-password admin command (#1304)
97ee889 Add captcha support to OpenID based signup
f00a4c8 Gitea OpenID-2.0 login has been tested with livejournal.com too
a9de85d Improve style of user OpenID setting page (#1324)
608cd54 fix gpg wrong column types

Before a9de85d31d commit:

$ git checkout 608cd54
$ make generate build
$ ./gitea web

After a9de85d31d commit:

$ git checkout a9de85d
$ make generate build
$ ./gitea web

@aloupfor commented on GitHub (Mar 21, 2017): Here is what make think that it was since https://github.com/go-gitea/gitea/commit/a9de85d31d8ba3ce8801d03e66866e527f5f39d7. ``` $git log --oneline 888dee3 fix delete user failed on sqlite (#1321) bd8fe49 fix wiki bugs (#1294) dbabc35 Delete the useless code (#1335) 5586445 LFS: Return 404 for unimplemented endpoints (#1330) 9182a35 Show user OpenID URIs in their profile (#1314) e158689 Add change-password admin command (#1304) 97ee889 Add captcha support to OpenID based signup f00a4c8 Gitea OpenID-2.0 login has been tested with livejournal.com too a9de85d Improve style of user OpenID setting page (#1324) 608cd54 fix gpg wrong column types ``` **Before https://github.com/go-gitea/gitea/commit/a9de85d31d8ba3ce8801d03e66866e527f5f39d7 commit:** ``` $ git checkout 608cd54 $ make generate build $ ./gitea web ``` ![screen shot 2017-03-21 at 19 54 55](https://cloud.githubusercontent.com/assets/11750180/24165625/2db0420e-0e71-11e7-87a5-d3eadc74c9a1.png) **After https://github.com/go-gitea/gitea/commit/a9de85d31d8ba3ce8801d03e66866e527f5f39d7 commit:** ``` $ git checkout a9de85d $ make generate build $ ./gitea web ``` ![screen shot 2017-03-21 at 20 00 11](https://cloud.githubusercontent.com/assets/11750180/24165638/330ba6a8-0e71-11e7-834a-37b9b2c4f5ea.png)

GiteaMirror commented

@strk commented on GitHub (Mar 22, 2017):

So it looks like the .css generated by my version of less compiler isn't good, if that's the case we should make the Makefile rule refuse to update index.css with an unexpected .css.

Can you please try to git revert a9de85d31d8ba3ce8801d03e66866e527f5f39d7 from master and try again ?
The only thing I really needed in that commit was the public/less/_user.less patch adding .openid.list selector beside .email.list one.

Can you help checking this @geek1011 ? (as my favorite resident CSS guy :)

@strk commented on GitHub (Mar 22, 2017): So it looks like the .css generated by my version of less compiler isn't good, if that's the case we should make the Makefile rule refuse to update index.css with an unexpected .css. Can you please try to `git revert a9de85d31d8ba3ce8801d03e66866e527f5f39d7` from master and try again ? The only thing I really needed in that commit was the `public/less/_user.less` patch adding `.openid.list` selector beside `.email.list` one. Can you help checking this @geek1011 ? (as my favorite resident CSS guy :)

GiteaMirror commented

@lunny commented on GitHub (Apr 20, 2017):

@strk is this resolved?

@lunny commented on GitHub (Apr 20, 2017): @strk is this resolved?

GiteaMirror commented

@strk commented on GitHub (Apr 20, 2017):

As of current master (bb14c97d40) it seems to be fixed, yes. Feel free to close (I don't have a close button)

@strk commented on GitHub (Apr 20, 2017): As of current master (bb14c97d406e5ed49863c666897da890e600a3f3) it seems to be fixed, yes. Feel free to close (I don't have a close button)

GiteaMirror commented

@lunny commented on GitHub (Apr 20, 2017):

@aloupfor please confirm what @strk said.

@lunny commented on GitHub (Apr 20, 2017): @aloupfor please confirm what @strk said.

GiteaMirror commented

@sapk commented on GitHub (Apr 21, 2017):

Change made by less version of @strk was revert in one of my commit @912b340d0d674b35ef04e66d00a10a8e4a02e82c (in master) because of re-generation of the file by less (maybe not the same version). So if it was the source of the bug it's corrected in master.

@sapk commented on GitHub (Apr 21, 2017): Change made by less version of @strk was revert in one of my commit @912b340d0d674b35ef04e66d00a10a8e4a02e82c (in master) because of re-generation of the file by less (maybe not the same version). So if it was the source of the bug it's corrected in master.

GiteaMirror commented