github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 10:39:38 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[BUG] The information in commit detail page was incorrect #5480

New Issue
Closed
opened 2025-11-02 06:26:02 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-02 06:26:02 -06:00
Owner
Copy Link

Originally created by @L0veSunshine on GitHub (May 31, 2020).

  • Gitea version (or commit ref):
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL) 7f0689524f
    • No
    • Not relevant
  • Log gist:

Description

When you visit a commit's detail page, if this commit is a merge opeation. The information on the page was a bit incorrect.
As you can see in this screenshot:
The parent commit is incorrect.
image

Screenshots

Originally created by @L0veSunshine on GitHub (May 31, 2020). <!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue --> <!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. --> - Gitea version (or commit ref): - Git version: - Operating system: - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [X] SQLite - Can you reproduce the bug at https://try.gitea.io: - [X] Yes (provide example URL) https://gitea.com/gitnex/GitNex/commit/7f0689524f2132cd52042f53eee93c43778358b8?lang=en-US - [ ] No - [ ] Not relevant - Log gist: ## Description When you visit a commit's detail page, if this commit is a merge opeation. The information on the page was a bit incorrect. As you can see in this screenshot: The parent commit is incorrect. ![image](https://user-images.githubusercontent.com/19653204/83357096-f04c9d80-a39c-11ea-8570-6e0c4b3d3402.png) ## Screenshots <!-- **If this issue involves the Web Interface, please include a screenshot** -->
GiteaMirror commented 2025-11-02 06:26:03 -06:00
Author
Owner
Copy Link

@CirnoT commented on GitHub (May 31, 2020):

What exactly do you mean by that?
The commit 7f0689524f2132cd52042f53eee93c43778358b8 has two parents: 29756511f3f3c2e32a7d89bb051a2494cc942211 and a4afa5fbc2fe9e6fea17788975987cf6faab382f

You should get same result by doing git log -1 7f0689524f2132cd52042f53eee93c43778358b8

commit 7f0689524f2132cd52042f53eee93c43778358b8
Merge: 2975651 a4afa5f
Author: M M Arif <mmarif@swatian.com>
Date:   Fri May 15 22:08:29 2020 +0000

    Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master

    Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/495
    Reviewed-by: opyale <opyale@noreply.gitea.io>

chrome_2020-05-31_22-55-23

@CirnoT commented on GitHub (May 31, 2020): What exactly do you mean by that? The commit `7f0689524f2132cd52042f53eee93c43778358b8` has two parents: `29756511f3f3c2e32a7d89bb051a2494cc942211` and `a4afa5fbc2fe9e6fea17788975987cf6faab382f` You should get same result by doing `git log -1 7f0689524f2132cd52042f53eee93c43778358b8` ``` commit 7f0689524f2132cd52042f53eee93c43778358b8 Merge: 2975651 a4afa5f Author: M M Arif <mmarif@swatian.com> Date: Fri May 15 22:08:29 2020 +0000 Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/495 Reviewed-by: opyale <opyale@noreply.gitea.io> ``` ![chrome_2020-05-31_22-55-23](https://user-images.githubusercontent.com/1447794/83362474-da85ab00-a391-11ea-8d4b-2f3e0a15d345.png)
GiteaMirror commented 2025-11-02 06:26:03 -06:00
Author
Owner
Copy Link

@L0veSunshine commented on GitHub (Jun 1, 2020):

What exactly do you mean by that?
The commit 7f0689524f2132cd52042f53eee93c43778358b8 has two parents: 29756511f3f3c2e32a7d89bb051a2494cc942211 and a4afa5fbc2fe9e6fea17788975987cf6faab382f

You should get same result by doing git log -1 7f0689524f2132cd52042f53eee93c43778358b8

commit 7f0689524f2132cd52042f53eee93c43778358b8
Merge: 2975651 a4afa5f
Author: M M Arif <mmarif@swatian.com>
Date:   Fri May 15 22:08:29 2020 +0000

    Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master

    Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/495
    Reviewed-by: opyale <opyale@noreply.gitea.io>

chrome_2020-05-31_22-55-23

I am very sorry for the late reply.
After checking about this again, i confirm you are right, that is only a ui issue.
Thanks for your pr!

@L0veSunshine commented on GitHub (Jun 1, 2020): > What exactly do you mean by that? > The commit `7f0689524f2132cd52042f53eee93c43778358b8` has two parents: `29756511f3f3c2e32a7d89bb051a2494cc942211` and `a4afa5fbc2fe9e6fea17788975987cf6faab382f` > > You should get same result by doing `git log -1 7f0689524f2132cd52042f53eee93c43778358b8` > > ``` > commit 7f0689524f2132cd52042f53eee93c43778358b8 > Merge: 2975651 a4afa5f > Author: M M Arif <mmarif@swatian.com> > Date: Fri May 15 22:08:29 2020 +0000 > > Merge pull request 'Add corners to popup dialogs' (#495) from ui-enhancements into master > > Reviewed-on: https://gitea.com/gitnex/GitNex/pulls/495 > Reviewed-by: opyale <opyale@noreply.gitea.io> > ``` > > ![chrome_2020-05-31_22-55-23](https://user-images.githubusercontent.com/1447794/83362474-da85ab00-a391-11ea-8d4b-2f3e0a15d345.png) I am very sorry for the late reply. After checking about this again, i confirm you are right, that is only a ui issue. Thanks for your pr!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5480
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?