access table should store all explicit accesses to repository #5443

Open
opened 2025-11-02 06:25:05 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @CirnoT on GitHub (May 22, 2020).

Currently it does not store explicit read access, even for private organizations or for restricted users.

This is because of 5789e60316/models/access.go (L190-L192)

The code was introduced with Gogs in 473e265727

If removed, migration would be required to recalculate accesses for current teams.

Originally created by @CirnoT on GitHub (May 22, 2020). Currently it does not store explicit read access, even for private organizations or for restricted users. This is because of https://github.com/go-gitea/gitea/blob/5789e603161aff311f8afcc15585892e783c931e/models/access.go#L190-L192 The code was introduced with Gogs in https://github.com/go-gitea/gitea/commit/473e265727c1e47dd83e3f66a5cc92d2f027d951 If removed, migration would be required to recalculate accesses for current teams.
GiteaMirror added the issue/confirmed label 2025-11-02 06:25:05 -06:00
Author
Owner

@mrsdizzie commented on GitHub (May 22, 2020):

This would be needed for proper issue assignment without having to walk through every team with access

@mrsdizzie commented on GitHub (May 22, 2020): This would be needed for proper issue assignment without having to walk through every team with access
Author
Owner

@stale[bot] commented on GitHub (Jul 25, 2020):

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale[bot] commented on GitHub (Jul 25, 2020): This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.
Author
Owner

@CirnoT commented on GitHub (Jul 26, 2020):

bad bot

@CirnoT commented on GitHub (Jul 26, 2020): bad bot
Author
Owner

@stale[bot] commented on GitHub (Oct 4, 2020):

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale[bot] commented on GitHub (Oct 4, 2020): This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5443