Gitea doesn't handle newline ('\n') in file specified by INTERNAL_TOKEN_URI #5423

New Issue

GiteaMirror · 2025-11-02T06:24:33-06:00

GiteaMirror commented

2025-11-02 06:24:33 -06:00

Originally created by @paradon on GitHub (May 18, 2020).

Gitea version (or commit ref): 1.11.5
Git version: 2.24.1
Operating system: Docker
Database (use [x]):
- PostgreSQL
- MySQL
- MSSQL
- SQLite
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
Log gist: https://gist.github.com/paradon/c48ab42740c8731b625313cf9d66e41c

Description

If the content in the file referenced by INTERNAL_TOKEN_URI ends with a newline, all commits fail with an internal server error.

As gitea generate secret appends a newline to its output, this means that, (where app.ini contains INTERNAL_TOKEN_URI = file:/data/gitea/conf/internal-token), generating this file as below will cause this error:

gitea generate secret INTERNAL_TOKEN >/data/gitea/conf/internal-token

Screenshots

Originally created by @paradon on GitHub (May 18, 2020).   - Gitea version (or commit ref): 1.11.5 - Git version: 2.24.1 - Operating system: Docker - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [ ] No - [x] Not relevant - Log gist: https://gist.github.com/paradon/c48ab42740c8731b625313cf9d66e41c ## Description If the content in the file referenced by INTERNAL_TOKEN_URI ends with a newline, all commits fail with an internal server error. As `gitea generate secret` appends a newline to its output, this means that, (where app.ini contains `INTERNAL_TOKEN_URI = file:/data/gitea/conf/internal-token`), generating this file as below will cause this error: ``` gitea generate secret INTERNAL_TOKEN >/data/gitea/conf/internal-token ``` ## Screenshots ![image](https://user-images.githubusercontent.com/31676142/82269096-b0f97680-99c4-11ea-8b1e-311ed45f2118.png)

GiteaMirror added the type/bug label 2025-11-02 06:24:33 -06:00

GiteaMirror closed this issue

2025-11-02 06:24:33 -06:00

GiteaMirror commented

2025-11-02 06:24:34 -06:00

@zeripath commented on GitHub (May 19, 2020):

I also note that this uses ioutil.ReadAll which will not work on Symlinks...

@zeripath commented on GitHub (May 19, 2020): I also note that this uses ioutil.ReadAll which will not work on Symlinks...

GiteaMirror referenced this issue

2025-11-02 15:48:48 -06:00

[PR #5423] [MERGED] Upgrade alpine to 3.8 #17790

Sign in to join this conversation.