Pull Request fails to change the target branch. #5298

New Issue

GiteaMirror · 2025-11-02T06:20:47-06:00

GiteaMirror commented

2025-11-02 06:20:47 -06:00

Originally created by @chriseaton on GitHub (Apr 24, 2020).

Gitea version (or commit ref): 1.11.4
Git version: 1.8.3.1
Operating system: CentOS 7
Database (use [x]):
- PostgreSQL
Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)

Description

Editing an existing Pull Request target doesn't actually change the target.

Reproduce:

Create 2 branches (branch A, branch B).
Create a new pull request to merge branch A into master.
Navigate to the pull request created and click "Edit".
Change the target from master to branch B.
Click "Save"
Notice the target branch reverts to master.

Expected behavior from reproduction:
The target branch should have changed from master to branch B.

Originally created by @chriseaton on GitHub (Apr 24, 2020). - Gitea version (or commit ref): 1.11.4 - Git version: 1.8.3.1 - Operating system: CentOS 7 - Database (use `[x]`): - [x] PostgreSQL - Can you reproduce the bug at https://try.gitea.io: - [x] Yes (provide example URL) ## Description Editing an existing Pull Request target doesn't actually change the target. Reproduce: 1. Create 2 branches (`branch A`, `branch B`). 1. Create a new pull request to merge `branch A` into `master`. 1. Navigate to the pull request created and click "Edit". 1. Change the target from `master` to `branch B`. 1. Click "Save" 1. Notice the target branch reverts to `master`. Expected behavior from reproduction: The target branch should have changed from `master` to `branch B`.

GiteaMirror added the issue/duplicate label 2025-11-02 06:20:47 -06:00

GiteaMirror closed this issue

2025-11-02 06:20:47 -06:00

GiteaMirror commented

2025-11-02 06:20:48 -06:00

@guillep2k commented on GitHub (Apr 25, 2020):

Currently there's no support for moving a PR to a different branch. It's not that the branch is "reverted"; it's rather that you're not making any changes to the file so no commit is created.

There is already an issue requesting this functionality. Closing as a duplicate.

@guillep2k commented on GitHub (Apr 25, 2020): Currently there's no support for moving a PR to a different branch. It's not that the branch is "reverted"; it's rather that you're not making any changes to the file so no commit is created. There is already an issue requesting this functionality. Closing as a duplicate.

GiteaMirror commented

2025-11-02 06:20:48 -06:00

@chriseaton commented on GitHub (Apr 28, 2020):

In this case then it's just bad UI since it's presented as an editable form, and the reaction by the app is to present faulty information when the form is acted upon. I think most users would expect, if this is indeed not a function that is supported, that it shouldn't be presented as such through the interface.

@chriseaton commented on GitHub (Apr 28, 2020): In this case then it's just bad UI since it's presented as an editable form, and the reaction by the app is to present faulty information when the form is acted upon. I think most users would expect, if this is indeed not a function that is supported, that it shouldn't be presented as such through the interface.

GiteaMirror commented

2025-11-02 06:20:48 -06:00

@guillep2k commented on GitHub (Apr 29, 2020):

~~We could add a "File had no changes; no commit or branch was created" flash, perhaps?~~ Sorry, not enough sleep.

@guillep2k commented on GitHub (Apr 29, 2020): ~~We could add a "File had no changes; no commit or branch was created" flash, perhaps?~~ Sorry, not enough sleep.

GiteaMirror referenced this issue

2025-11-02 15:28:23 -06:00

[PR #5298] [MERGED] Add changelog for 1.5.3 release (#5227) #17744

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/gitea#5298