Pull request is broken #5252

Closed
opened 2025-11-02 06:19:12 -06:00 by GiteaMirror · 3 comments
Owner

Originally created by @kraszied on GitHub (Apr 17, 2020).

  • Gitea version (or commit ref): 1.11.4
  • Git version: 2.24.0
  • Operating system: Windows 10
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If a pull request (PR) is created and then a new commit is pushed to the source (head) branch the PR became broken. The newly pushed commit doesn’t appear in the PR and head branch appears as "deleted". The branch protection is set to the destination branch. In this repository all created PRs behave the same independently which are the source and destination branches. In our other repository this error never comes. This situation prevents us to fulfill an effective code review, because we need to open a new PR after every newly pushed commit related to the review.

Here is a link to my ticket on our forum: https://discourse.gitea.io/t/pull-request-is-broken/2092

Originally created by @kraszied on GitHub (Apr 17, 2020). - Gitea version (or commit ref): 1.11.4 - Git version: 2.24.0 - Operating system: Windows 10 - Database (use `[x]`): - [ ] PostgreSQL - [ ] MySQL - [ ] MSSQL - [x] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No - [ ] Not relevant - Log gist: ## Description If a pull request (PR) is created and then a new commit is pushed to the source (head) branch the PR became broken. The newly pushed commit doesn’t appear in the PR and head branch appears as "deleted". The branch protection is set to the destination branch. In this repository all created PRs behave the same independently which are the source and destination branches. In our other repository this error never comes. This situation prevents us to fulfill an effective code review, because we need to open a new PR after every newly pushed commit related to the review. Here is a link to my ticket on our forum: https://discourse.gitea.io/t/pull-request-is-broken/2092
Author
Owner

@filipnavara commented on GitHub (Apr 17, 2020):

Check that the git hooks are executing properly. This exact problem was happening on our installation and that was the root cause.

@filipnavara commented on GitHub (Apr 17, 2020): Check that the git hooks are executing properly. This exact problem was happening on our installation and that was the root cause.
Author
Owner

@kraszied commented on GitHub (Apr 17, 2020):

@filipnavara thank you for your info! Actually we don't have any git hooks but updating the Gitea version and regeneration of SSH keys (Update the '.ssh/authorized_keys' file with Gitea SSH keys. (Not needed for the built-in SSH server.) on dashboard) are solved our problem.

@kraszied commented on GitHub (Apr 17, 2020): @filipnavara thank you for your info! Actually we don't have any git hooks but updating the Gitea version and regeneration of SSH keys (Update the '.ssh/authorized_keys' file with Gitea SSH keys. (Not needed for the built-in SSH server.) on dashboard) are solved our problem.
Author
Owner

@filipnavara commented on GitHub (Apr 17, 2020):

Gitea relies on git hooks that are installed in the repositories. If they are not present then it will break in this exact way. When you create the repository in Gitea these hooks are automatically installed but someone might have broken them during some maintenance operation.

@filipnavara commented on GitHub (Apr 17, 2020): Gitea relies on git hooks that are installed in the repositories. If they are not present then it will break in this exact way. When you create the repository in Gitea these hooks are automatically installed but someone might have broken them during some maintenance operation.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5252