github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-16 21:23:02 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

[BUG] Reviews not corect sorted to pulls in Pull-List-View #5228

New Issue
Closed
opened 2025-11-02 06:18:30 -06:00 by GiteaMirror · 7 comments
GiteaMirror commented 2025-11-02 06:18:30 -06:00
Owner
Copy Link

Originally created by @6543 on GitHub (Apr 13, 2020).

Gitea Version: 1.12.0+dev-72-g2c25e75dc

example pull https://gitea.com/gitnex/GitNex/pulls/398
has 1 aprofal and 1 rejection on pull-list-view but rejection was aproved later from same user

Originally created by @6543 on GitHub (Apr 13, 2020). Gitea Version: 1.12.0+dev-72-g2c25e75dc example pull https://gitea.com/gitnex/GitNex/pulls/398 has 1 aprofal and 1 rejection on pull-list-view but rejection was aproved later from same user
GiteaMirror added the type/bug label 2025-11-02 06:18:30 -06:00
GiteaMirror commented 2025-11-02 06:18:31 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 13, 2020):

Screenshot at 2020-04-13 04-27-10

does not match with

Screenshot at 2020-04-13 04-27-22

@6543 commented on GitHub (Apr 13, 2020): ![Screenshot at 2020-04-13 04-27-10](https://user-images.githubusercontent.com/24977596/79087310-1f507680-7d3f-11ea-8b00-449bcd844112.png) ## does not match with ![Screenshot at 2020-04-13 04-27-22](https://user-images.githubusercontent.com/24977596/79087312-224b6700-7d3f-11ea-903d-19c20b19a925.png)
GiteaMirror commented 2025-11-02 06:18:31 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 13, 2020):

same thing if you only aprove ... I guess: approvals are als counted as change-requests - didn't looket ito the code jet

@6543 commented on GitHub (Apr 13, 2020): same thing if you only aprove ... I guess: approvals are als counted as change-requests - didn't looket ito the code jet
GiteaMirror commented 2025-11-02 06:18:31 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 14, 2020):

cant reproduce on current master - looks like the pull for review-request fixed this

@6543 commented on GitHub (Apr 14, 2020): cant reproduce on current master - looks like the pull for review-request fixed this
GiteaMirror commented 2025-11-02 06:18:31 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 15, 2020):

Looks like issue is till here :/

@6543 commented on GitHub (Apr 15, 2020): Looks like issue is till here :/
GiteaMirror commented 2025-11-02 06:18:32 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 15, 2020):

as "eider" pointed out on discord:
80db44267c/models/issue_list.go (L538)

if i force search to give me only one PR
the count is fine
but if in list there's at least one other issue
with requested change
the count goes to wrong issue
the "1 change request"
should go to other issue in list
but it isnt there!
@6543 commented on GitHub (Apr 15, 2020): as "eider" pointed out on discord: https://github.com/go-gitea/gitea/blob/80db44267ccb688c596e8375523af5cd92864d87/models/issue_list.go#L538 ``` if i force search to give me only one PR the count is fine but if in list there's at least one other issue with requested change the count goes to wrong issue the "1 change request" should go to other issue in list but it isnt there! ```
GiteaMirror commented 2025-11-02 06:18:32 -06:00
Author
Owner
Copy Link

@CirnoT commented on GitHub (Apr 15, 2020):

Reproduction:

https://try.gitea.io/test_org21/test_repo/pulls
https://try.gitea.io/test_org21/test_repo/pulls?q=LICENSE
https://try.gitea.io/test_org21/test_repo/pulls?q=README.md
https://try.gitea.io/test_org21/test_repo/pulls?q=.gitignore

@CirnoT commented on GitHub (Apr 15, 2020): Reproduction: https://try.gitea.io/test_org21/test_repo/pulls https://try.gitea.io/test_org21/test_repo/pulls?q=LICENSE https://try.gitea.io/test_org21/test_repo/pulls?q=README.md https://try.gitea.io/test_org21/test_repo/pulls?q=.gitignore
GiteaMirror commented 2025-11-02 06:18:32 -06:00
Author
Owner
Copy Link

@6543 commented on GitHub (Apr 16, 2020):

I'll take this

@6543 commented on GitHub (Apr 16, 2020): I'll take this
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?