github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-07-16 21:53:50 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Activity page- broken urls - in 1.1.0 #521

New Issue
Closed
opened 2025-11-02 03:26:34 -06:00 by GiteaMirror · 9 comments
GiteaMirror commented 2025-11-02 03:26:34 -06:00
Owner
Copy Link

Originally created by @yusefmaali on GitHub (Mar 16, 2017).

  • Gitea version (or commit ref): 1.1.0 built with: bindata, sqlite (as seen in admin panel)
  • Git version: 2.7.4
  • Operating system: Ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

In the activity page all the links provided are broken.

in my installation (italian language) I have:

yma "ha creato il repository yma/BugHunting"

in try.gitea.io I have:

yma ha creato il repository yma/BugHunting

(please note the quotation marks).

The problem goes deeper in the urls.
In my installation I have (I've replace my real hostname with a placeholder):

http://host_name/%5C%22/yma/BugHunting%5C%22

in try.gitea.io I have:

https://try.gitea.io/yma/BugHunting

This issue wasn't present in the previous version (1.0.2) and is affecting every kind of urls: issue, commits, repo creatiions, etc...

Originally created by @yusefmaali on GitHub (Mar 16, 2017). - Gitea version (or commit ref): 1.1.0 built with: bindata, sqlite (as seen in admin panel) - Git version: 2.7.4 - Operating system: Ubuntu - Database (use `[x]`): - [ ] PostgreSQL - [x] MySQL - [ ] MSSQL - [ ] SQLite - Can you reproduce the bug at https://try.gitea.io: - [ ] Yes (provide example URL) - [x] No - [ ] Not relevant - Log gist: ## Description In the activity page all the links provided are broken. in my installation (italian language) I have: > yma "ha creato il repository yma/BugHunting" in try.gitea.io I have: > yma ha creato il repository yma/BugHunting (please note the quotation marks). The problem goes deeper in the urls. In my installation I have (I've replace my real hostname with a placeholder): http://host_name/%5C%22/yma/BugHunting%5C%22 in try.gitea.io I have: https://try.gitea.io/yma/BugHunting This issue wasn't present in the previous version (1.0.2) and is affecting every kind of urls: issue, commits, repo creatiions, etc...
GiteaMirror added the issue/duplicate label 2025-11-02 03:26:34 -06:00
GiteaMirror commented 2025-11-02 03:26:35 -06:00
Author
Owner
Copy Link

@yusefmaali commented on GitHub (Mar 16, 2017):

Looking into Gitea code seems to me the issue happens here in this template:

https://github.com/go-gitea/gitea/blob/master/templates/user/dashboard/feeds.tmpl

The example I provide happens when GetOpType == 6

@yusefmaali commented on GitHub (Mar 16, 2017): Looking into Gitea code seems to me the issue happens here in this template: https://github.com/go-gitea/gitea/blob/master/templates/user/dashboard/feeds.tmpl The example I provide happens when GetOpType == 6
GiteaMirror commented 2025-11-02 03:26:35 -06:00
Author
Owner
Copy Link

@yusefmaali commented on GitHub (Mar 16, 2017):

Ok, found the issue (or a part of it).

7d8f9d1c46/options/locale/locale_it-IT.ini

The it-IT localization is incorrect:
in "action" section you can see that the "create_issue" statement starts with a double quotation mark. This may be escaped into HTML %5C%22.
That quotation mark is surely wrong and it is present also in other statements.

@yusefmaali commented on GitHub (Mar 16, 2017): Ok, found the issue (or a part of it). https://github.com/go-gitea/gitea/blob/7d8f9d1c46e38681f2a4033a7da811ab7562d953/options/locale/locale_it-IT.ini The it-IT localization is incorrect: in "action" section you can see that the "create_issue" statement starts with a double quotation mark. This may be escaped into HTML %5C%22. That quotation mark is surely wrong and it is present also in other statements.
GiteaMirror commented 2025-11-02 03:26:35 -06:00
Author
Owner
Copy Link

@tboerger commented on GitHub (Mar 16, 2017):

Damn crowdin -.-

@tboerger commented on GitHub (Mar 16, 2017): Damn crowdin -.-
GiteaMirror commented 2025-11-02 03:26:35 -06:00
Author
Owner
Copy Link

@yusefmaali commented on GitHub (Mar 16, 2017):

Ok, the it_IT localization has been corrected in master.
As soon as you release the new version, the issue will be resolved.

BTW the current v1.1.0 has this issue.

@yusefmaali commented on GitHub (Mar 16, 2017): Ok, the it_IT localization has been corrected in master. As soon as you release the new version, the issue will be resolved. BTW the current v1.1.0 has this issue.
GiteaMirror commented 2025-11-02 03:26:36 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 17, 2017):

Master and release/v1.1 has fixed this problem and will be released on v1.1.1

@lunny commented on GitHub (Mar 17, 2017): Master and release/v1.1 has fixed this problem and will be released on v1.1.1
GiteaMirror commented 2025-11-02 03:26:36 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Apr 28, 2017):

Funny thing is that I have a similar issue in my activities list: all links to repos and branches have that %5C%22/user/repo%5C%22 even if there are no quotation marks in the names. Not Italian here (German was used when setting things up and logging in), but it's fixed when switching the browser language to English (and removing the lang cookie).

Running 1.1.0/ARM here currently. Is that the same issue (and thus fixed), or shall I open a separate issue for that?

@IzzySoft commented on GitHub (Apr 28, 2017): Funny thing is that I have a similar issue in my activities list: all links to repos and branches have that `%5C%22/user/repo%5C%22` even if there are no quotation marks in the names. Not Italian here (German was used when setting things up and logging in), but it's fixed when switching the browser language to English (and removing the `lang` cookie). Running 1.1.0/ARM here currently. Is that the same issue (and thus fixed), or shall I open a separate issue for that?
GiteaMirror commented 2025-11-02 03:26:36 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Apr 29, 2017):

This is a duplicated issue and fixed in release/v1.1

@lunny commented on GitHub (Apr 29, 2017): This is a duplicated issue and fixed in release/v1.1
GiteaMirror commented 2025-11-02 03:26:37 -06:00
Author
Owner
Copy Link

@IzzySoft commented on GitHub (Apr 29, 2017):

@lunny thanks! Thought so already but just wanted to make sure.

@IzzySoft commented on GitHub (Apr 29, 2017): @lunny thanks! Thought so already but just wanted to make sure.
GiteaMirror commented 2025-11-02 03:26:37 -06:00
Author
Owner
Copy Link

@yusefmaali commented on GitHub (May 6, 2017):

Fixed with the 1.1.1 release.
Thanks

@yusefmaali commented on GitHub (May 6, 2017): Fixed with the 1.1.1 release. Thanks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?