github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

When there is no branch protected, the reviews of those who have code write permission should be consider as official #5004

New Issue
Closed
opened 2025-11-02 06:10:42 -06:00 by GiteaMirror · 5 comments
GiteaMirror commented 2025-11-02 06:10:42 -06:00
Owner
Copy Link

Originally created by @lunny on GitHub (Mar 6, 2020).

As above.

If no branch protected, then no official review. Should we change that?

Originally created by @lunny on GitHub (Mar 6, 2020). As above. If no branch protected, then no official review. Should we change that?
GiteaMirror added the pr/breakingissue/confirmedtype/enhancement labels 2025-11-02 06:10:42 -06:00
GiteaMirror commented 2025-11-02 06:10:43 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Mar 6, 2020):

I thought it was always official unless there's a whitelist and the user is not in it. Maybe we've missed that case for unprotected branches?

@guillep2k commented on GitHub (Mar 6, 2020): I thought it was _always_ official unless there's a whitelist and the user is not in it. Maybe we've missed that case for unprotected branches?
GiteaMirror commented 2025-11-02 06:10:43 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Mar 6, 2020):

@guillep2k see https://github.com/go-gitea/gitea/blob/master/models/review.go#L195 , when there is no branch protected, no reviewer will be consider as official.

@lunny commented on GitHub (Mar 6, 2020): @guillep2k see https://github.com/go-gitea/gitea/blob/master/models/review.go#L195 , when there is no branch protected, no reviewer will be consider as official.
GiteaMirror commented 2025-11-02 06:10:44 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Mar 6, 2020):

As Syndrome said: "if everyone is special, then nobody is special" 😄

I agree, I think those should be "official".

@guillep2k commented on GitHub (Mar 6, 2020): As Syndrome said: _"if everyone is special, then **nobody** is special"_ 😄 I agree, I think those should be "official".
GiteaMirror commented 2025-11-02 06:10:44 -06:00
Author
Owner
Copy Link

@stale[bot] commented on GitHub (May 6, 2020):

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale[bot] commented on GitHub (May 6, 2020): This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.
GiteaMirror commented 2025-11-02 06:10:44 -06:00
Author
Owner
Copy Link

@lunny commented on GitHub (Feb 18, 2025):

I think this has been resolved by #32415

@lunny commented on GitHub (Feb 18, 2025): I think this has been resolved by #32415
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/confirmed pr/breaking type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#5004
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?