Detection of renamed files not working with Git 1.9.1 #50

Closed
opened 2025-11-02 03:06:00 -06:00 by GiteaMirror · 8 comments
Owner

Originally created by @jhasse on GitHub (Nov 10, 2016).

  • Gitea version (or commit ref): 0.9.99.0903
  • Git version: 1.9.1
  • Operating system: Ubuntu 14.04.5 LTS
  • Database:
    • PostgreSQL
    • MySQL
    • SQLite

Description

I have a commit with a file A which get's renamed to B. Instead of showing that, Gogs/Gitea just shows me A with all it content removed and added again.

This Gogs commit added support for detecting file renames: bc82157216

I couldn't reproduce this on https://try.gogs.io, so I think it has something to do with my older Git version.

Originally created by @jhasse on GitHub (Nov 10, 2016). - Gitea version (or commit ref): 0.9.99.0903 - Git version: 1.9.1 - Operating system: Ubuntu 14.04.5 LTS - Database: - [ ] PostgreSQL - [x] MySQL - [ ] SQLite ## Description I have a commit with a file A which get's renamed to B. Instead of showing that, Gogs/Gitea just shows me A with all it content removed and added again. This Gogs commit added support for detecting file renames: https://github.com/go-gitea/gitea/commit/bc8215721627fcdeaa23c6e3bf625e0c4e5c3407 I couldn't reproduce this on https://try.gogs.io, so I think it has something to do with my older Git version.
GiteaMirror added the issue/not-a-bug label 2025-11-02 03:06:00 -06:00
Author
Owner

@strk commented on GitHub (Nov 12, 2016):

The commit you reference is already also in Gitea. Can you reproduce locally ?
Non-reproducible bugs would be nearly impossible to fix. Ideally a failing automated test would be provided, can you try that ?

@strk commented on GitHub (Nov 12, 2016): The commit you reference is already also in Gitea. Can you reproduce locally ? Non-reproducible bugs would be nearly impossible to fix. Ideally a failing automated test would be provided, can you try that ?
Author
Owner

@tboerger commented on GitHub (Nov 12, 2016):

Ideally a failing automated test would be provided, can you try that ?

How could he provide a failing test with specific Git versions?

@tboerger commented on GitHub (Nov 12, 2016): > Ideally a failing automated test would be provided, can you try that ? How could he provide a failing test with specific Git versions?
Author
Owner

@jhasse commented on GitHub (Nov 14, 2016):

How could he provide a failing test with specific Git versions?

I could set up a Dockerfile.

Is there an automated test for file renames?

@jhasse commented on GitHub (Nov 14, 2016): > How could he provide a failing test with specific Git versions? I could set up a Dockerfile. Is there an automated test for file renames?
Author
Owner

@strk commented on GitHub (Nov 14, 2016):

I don't think there's an automated test for file renames. Such test would be enough, then the testers would have to deal with different Git versions.

@strk commented on GitHub (Nov 14, 2016): I don't think there's an automated test for file renames. Such test would be enough, then the _testers_ would have to deal with different Git versions.
Author
Owner

@bkcsoft commented on GitHub (Nov 14, 2016):

@strk testers (as in Drone) should test using different git-versions yes 😉

@bkcsoft commented on GitHub (Nov 14, 2016): @strk _testers_ (as in Drone) should test using different git-versions yes :wink:
Author
Owner

@bkcsoft commented on GitHub (Nov 14, 2016):

@jhasse

I think it has something to do with my older Git version.

Please try that first 😉

@bkcsoft commented on GitHub (Nov 14, 2016): @jhasse > I think it has something to do with my older Git version. Please try that first :wink:
Author
Owner

@jhasse commented on GitHub (Nov 14, 2016):

I couldn't reproduce with git version 2.7.4. I'll try again with a virtual machine, might take a while ...

@jhasse commented on GitHub (Nov 14, 2016): I couldn't reproduce with git version 2.7.4. I'll try again with a virtual machine, might take a while ...
Author
Owner

@jhasse commented on GitHub (Nov 18, 2016):

Okay I've could not reproduce, even with the older Git version :( There seems to be something special about that commit, maybe I have time to create a minimal example. I would create a new bug report then.

@jhasse commented on GitHub (Nov 18, 2016): Okay I've could not reproduce, even with the older Git version :( There seems to be something special about that commit, maybe I have time to create a minimal example. I would create a new bug report then.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#50