github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-12 02:24:21 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

Go 1.14 version check fails on Windows/amd64 #4960

New Issue
Closed
opened 2025-11-02 06:09:09 -06:00 by GiteaMirror · 18 comments
GiteaMirror commented 2025-11-02 06:09:09 -06:00
Owner
Copy Link

Originally created by @filipnavara on GitHub (Feb 27, 2020).

  • Gitea version (or commit ref): a924a90349
  • Git version: 2.25
  • Operating system: Windows

Description

The check in make go-check fails because the regular expression for version extraction doesn't match the output of go version.

go version output is go version go1.14 windows/amd64 which cannot be matched with grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s'.

Originally created by @filipnavara on GitHub (Feb 27, 2020). - Gitea version (or commit ref): a924a90349a78ebe8e7eb560e435a7ddc1de9b84 - Git version: 2.25 - Operating system: Windows ## Description The check in `make go-check` fails because the regular expression for version extraction doesn't match the output of `go version`. `go version` output is `go version go1.14 windows/amd64` which cannot be matched with `grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s'`.
GiteaMirror added the issue/needs-feedback label 2025-11-02 06:09:09 -06:00
GiteaMirror commented 2025-11-02 06:09:10 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Feb 27, 2020):

The regex does match and it looks to be able to cope with 2-number versions too. I'm not sure what the issue exactly is.

$ printf "%03d%03d%03d" $(echo 'go version go1.13.4 linux/amd64' | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s' | tr '.' ' ')
001013004

$ printf "%03d%03d%03d" $(echo 'go version go1.14 windows/amd64' | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s' | tr '.' ' ')
001014000
@silverwind commented on GitHub (Feb 27, 2020): The regex does match and it looks to be able to cope with 2-number versions too. I'm not sure what the issue exactly is. ```console $ printf "%03d%03d%03d" $(echo 'go version go1.13.4 linux/amd64' | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s' | tr '.' ' ') 001013004 ``` ```console $ printf "%03d%03d%03d" $(echo 'go version go1.14 windows/amd64' | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s' | tr '.' ' ') 001014000 ```
GiteaMirror commented 2025-11-02 06:09:10 -06:00
Author
Owner
Copy Link

@filipnavara commented on GitHub (Feb 27, 2020):

Interesting, in MSYS I get this:

bash-3.1$ printf "%03d%03d%03d" $(echo 'go version go1.14 windows/amd64' | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s' | tr '.' ' ')
000000000
bash-3.1$

Perhaps an issue with escaping in the pattern vs command line escaping?

@filipnavara commented on GitHub (Feb 27, 2020): Interesting, in MSYS I get this: ``` bash-3.1$ printf "%03d%03d%03d" $(echo 'go version go1.14 windows/amd64' | grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?\s' | tr '.' ' ') 000000000 bash-3.1$ ``` Perhaps an issue with escaping in the pattern vs command line escaping?
GiteaMirror commented 2025-11-02 06:09:10 -06:00
Author
Owner
Copy Link

@jolheiser commented on GitHub (Feb 27, 2020):

In Git Bash on Windows I get 001014000

@jolheiser commented on GitHub (Feb 27, 2020): In Git Bash on Windows I get `001014000`
GiteaMirror commented 2025-11-02 06:09:11 -06:00
Author
Owner
Copy Link

@filipnavara commented on GitHub (Feb 27, 2020):

I get the same garbage in Git Bash, let me check various tool versions to pinpoint which one breaks it.

@filipnavara commented on GitHub (Feb 27, 2020): I get the same garbage in Git Bash, let me check various tool versions to pinpoint which one breaks it.
GiteaMirror commented 2025-11-02 06:09:11 -06:00
Author
Owner
Copy Link

@filipnavara commented on GitHub (Feb 27, 2020):

Seems to be an issue with the grep in MSYS. I'll just close the issue, thanks for help.

@filipnavara commented on GitHub (Feb 27, 2020): Seems to be an issue with the `grep` in MSYS. I'll just close the issue, thanks for help.
GiteaMirror commented 2025-11-02 06:09:11 -06:00
Author
Owner
Copy Link

@filipnavara commented on GitHub (Feb 27, 2020):

For the record, the version of grep in Git Bash is 3.1. The one I had in my MSYS installation was version 2.5.4. The older version doesn't understand the \s syntax apparently, or interprets it incorrectly.

@filipnavara commented on GitHub (Feb 27, 2020): For the record, the version of `grep` in Git Bash is 3.1. The one I had in my MSYS installation was version 2.5.4. The older version doesn't understand the `\s` syntax apparently, or interprets it incorrectly.
GiteaMirror commented 2025-11-02 06:09:11 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

hmm... I think that means we should switch away from using \s as it won't work on non-GNU systems too.

@zeripath commented on GitHub (Feb 27, 2020): hmm... I think that means we should switch away from using \s as it won't work on non-GNU systems too.
GiteaMirror commented 2025-11-02 06:09:12 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

We should probably use \b

@zeripath commented on GitHub (Feb 27, 2020): We should probably use `\b`
GiteaMirror commented 2025-11-02 06:09:12 -06:00
Author
Owner
Copy Link

@filipnavara commented on GitHub (Feb 27, 2020):

\b doesn't work either. With Git Bash it matches both the version and "64" at the end. With the old MSYS grep it doesn't match anything. Putting a dumb (space) instead of \s works with both but not sure if it's reliable and future proof.

Given that version 2.5.4 is over a decade old and we don't have reports from any other system I'd just hope for the best and keep the current code.

@filipnavara commented on GitHub (Feb 27, 2020): `\b` doesn't work either. With Git Bash it matches both the version and "64" at the end. With the old MSYS grep it doesn't match anything. Putting a dumb ` ` (space) instead of `\s` works with both but not sure if it's reliable and future proof. Given that version 2.5.4 is over a decade old and we don't have reports from any other system I'd just hope for the best and keep the current code.
GiteaMirror commented 2025-11-02 06:09:12 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

The BSD users will complain about it too.

@zeripath commented on GitHub (Feb 27, 2020): The BSD users will complain about it too.
GiteaMirror commented 2025-11-02 06:09:12 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Feb 27, 2020):

We should use egrep (a shortcut for grep -e) that supports the whole set of regexp syntax (grep's own, but all of it). grep without -e has a reduced set. BTW egrep has been around since Unix System V Release 4.

@guillep2k commented on GitHub (Feb 27, 2020): We should use `egrep` (a shortcut for `grep -e`) that supports the whole set of regexp syntax (grep's own, but all of it). `grep` without `-e` has a reduced set. BTW `egrep` has been around since [Unix System V Release 4](https://en.wikipedia.org/wiki/UNIX_System_V#SVR4).
GiteaMirror commented 2025-11-02 06:09:13 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Feb 27, 2020):

Maybe replace \s with (a single space). Will break on tab thought.

@silverwind commented on GitHub (Feb 27, 2020): Maybe replace `\s` with ` ` (a single space). Will break on tab thought.
GiteaMirror commented 2025-11-02 06:09:13 -06:00
Author
Owner
Copy Link

@silverwind commented on GitHub (Feb 27, 2020):

We should use egrep

Our grep -E is equivalent to egrep, at least on Linux.

@silverwind commented on GitHub (Feb 27, 2020): > We should use egrep Our `grep -E` is equivalent to `egrep`, at least on Linux.
GiteaMirror commented 2025-11-02 06:09:13 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

can do [ \t] as far as I can see. I'm just trying to find the appropriate manpages.

@zeripath commented on GitHub (Feb 27, 2020): can do [ \t] as far as I can see. I'm just trying to find the appropriate manpages.
GiteaMirror commented 2025-11-02 06:09:13 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Feb 27, 2020):

Our grep -E is equivalent to egrep, at least on Linux.

Oh, doh! 🤦‍♂ Of course. I just felt like remembering the good old times, that's all.

@guillep2k commented on GitHub (Feb 27, 2020): > > Our grep -E is equivalent to `egrep`, at least on Linux. Oh, doh! 🤦‍♂ Of course. I just felt like remembering the good old times, that's all.
GiteaMirror commented 2025-11-02 06:09:13 -06:00
Author
Owner
Copy Link

@guillep2k commented on GitHub (Feb 27, 2020):

The problem is that we need to account for shell and make escaping our characters.

@guillep2k commented on GitHub (Feb 27, 2020): The problem is that we need to account for shell _and_ `make` escaping our characters.
GiteaMirror commented 2025-11-02 06:09:14 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

OK POSIX says that [:space:] should be supported in all locales so I think we can use that.

@zeripath commented on GitHub (Feb 27, 2020): OK POSIX says that [:space:] should be supported in all locales so I think we can use that.
GiteaMirror commented 2025-11-02 06:09:14 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

as in grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?[[:space:]]'

@zeripath commented on GitHub (Feb 27, 2020): as in `grep -Eo '[0-9]+\.?[0-9]+?\.?[0-9]?[[:space:]]'`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label issue/needs-feedback
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4960
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?