github-starred/gitea
2
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-03-09 04:25:18 -05:00
Code Issues 2.6k Packages Projects Releases 100 Wiki Activity

HTML sanitizer doesn't allow centering of text #4940

New Issue
Closed
opened 2025-11-02 06:08:22 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2025-11-02 06:08:22 -06:00
Owner
Copy Link

Originally created by @alexanderadam on GitHub (Feb 26, 2020).

Description

See the missing icon in the README of this mirror on try.gitea.io whereas the rendering on GitHub is flawless. (see #8830 for the image issue).

The text centering of the headline is lost.

Screenshots

Screenshot_20200226_083247

Originally created by @alexanderadam on GitHub (Feb 26, 2020). - Gitea version (or commit ref): ` 1.12.0+dev-379-ge5944a952` - Git version: irrelevant - Operating system: irrelevant - Database: irrelevant - Can you reproduce the bug at https://try.gitea.io: - Yes: https://try.gitea.io/alexanderadam/636f7374-cherry.cr - Log gist: irrelevant ## Description ~~See the missing icon in the README of [this mirror on try.gitea.io](https://try.gitea.io/alexanderadam/636f7374-cherry.cr/src/branch/master/readme.md) whereas the rendering [on GitHub is flawless](https://github.com/636f7374/cherry.cr/blob/master/readme.md).~~ (see #8830 for the image issue). The text centering of the headline is lost. ## Screenshots ![Screenshot_20200226_083247](https://user-images.githubusercontent.com/372620/75322217-9d7dba00-5872-11ea-950f-934180437928.png)
GiteaMirror added the type/enhancement label 2025-11-02 06:08:22 -06:00
GiteaMirror commented 2025-11-02 06:08:23 -06:00
Author
Owner
Copy Link

@jolheiser commented on GitHub (Feb 26, 2020):

The first issue is a duplicate of #8830

The second is because of our sanitizer not allowing align = "center".

@jolheiser commented on GitHub (Feb 26, 2020): The first issue is a duplicate of #8830 The second is because of our sanitizer not allowing `align = "center"`.
GiteaMirror commented 2025-11-02 06:08:23 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 26, 2020):

If instead of writing html you used markdown syntax for the image - it would work as expected.

We don't currently munge the relative URL of a IMG elements - I guess we could and it is likely to be a very simple pr to do that.

@zeripath commented on GitHub (Feb 26, 2020): If instead of writing html you used markdown syntax for the image - it would work as expected. We don't currently munge the relative URL of a IMG elements - I guess we could and it is likely to be a very simple pr to do that.
GiteaMirror commented 2025-11-02 06:08:23 -06:00
Author
Owner
Copy Link

@alexanderadam commented on GitHub (Feb 27, 2020):

The first issue is a duplicate of #8830

Ah I see. I searched for it and found nothing. I will remove the part about the relative path in this issue then.
Thank you for pointing out 👍

If instead of writing html you used markdown syntax for the image - it would work as expected.

  1. It isn't my repository. I just took a random repository from GitHub and mirrored it on try.gitea.io. I obviously can't control random repositories on the web. 😉
  2. So the logic between Markdown and HTML rendering is diverged (= buggy)
@alexanderadam commented on GitHub (Feb 27, 2020): > The first issue is a duplicate of #8830 Ah I see. I searched for it and found nothing. I will remove the part about the relative path in this issue then. Thank you for pointing out :+1: > If instead of writing html you used markdown syntax for the image - it would work as expected. 1. It isn't _my_ repository. I just took a random repository from GitHub and mirrored it on `try.gitea.io`. I obviously can't control random repositories on the web. :wink: 2. So the logic between Markdown and HTML rendering is diverged (= buggy)
GiteaMirror commented 2025-11-02 06:08:24 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 27, 2020):

see #10515 for dealing with the embedded html img tags ...

@zeripath commented on GitHub (Feb 27, 2020): see #10515 for dealing with the embedded html img tags ...
GiteaMirror commented 2025-11-02 06:08:25 -06:00
Author
Owner
Copy Link

@alexanderadam commented on GitHub (Feb 28, 2020):

Awesome, thank you Andrew!

@alexanderadam commented on GitHub (Feb 28, 2020): Awesome, thank you Andrew!
GiteaMirror commented 2025-11-02 06:08:25 -06:00
Author
Owner
Copy Link

@alexanderadam commented on GitHub (Feb 28, 2020):

Thank you so much for fixing those both issues, @zeripath.
I'm afraid I found another markdown/html rendering issue which isn't fixed in the current build on try.gitea.io. Or is the current master not yet deployed?

Screenshot_20200228_231225

Should I open a new issue for this or recycle this one?

@alexanderadam commented on GitHub (Feb 28, 2020): Thank you so much for fixing those both issues, @zeripath. I'm afraid I found another markdown/html rendering issue which isn't fixed in the current build on [`try.gitea.io`](https://try.gitea.io/alexanderadam/636f7374-cherry.cr#user-content-contributors). Or is the current master not yet deployed? ![Screenshot_20200228_231225](https://user-images.githubusercontent.com/372620/75591431-fd957b80-5a7f-11ea-91e3-c130cfb2b2f4.png) Should I open a new issue for this or recycle this one?
GiteaMirror commented 2025-11-02 06:08:25 -06:00
Author
Owner
Copy Link

@zeripath commented on GitHub (Feb 28, 2020):

Open a new one

@zeripath commented on GitHub (Feb 28, 2020): Open a new one
GiteaMirror commented 2025-11-02 06:08:25 -06:00
Author
Owner
Copy Link

@alexanderadam commented on GitHub (Feb 28, 2020):

done. Thank you again for fixing those issues so fast.
And you are even answering blazingly fast. 😉

@alexanderadam commented on GitHub (Feb 28, 2020): [done](https://github.com/go-gitea/gitea/issues/10542). Thank you again for fixing those issues so fast. And you are even _answering_ blazingly fast. :wink:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
$20
$250
$50
$500
backport/done
💎 Bounty
docs-update-needed
good first issue
hacktoberfest
issue/bounty
issue/confirmed
issue/critical
issue/duplicate
issue/needs-feedback
issue/not-a-bug
issue/regression
issue/stale
issue/workaround
lgtm/need 2
modifies/api
modifies/translation
outdated/backport/v1.18
outdated/theme/markdown
outdated/theme/timetracker
performance/bigrepo
performance/cpu
performance/memory
performance/speed
pr/breaking
proposal/accepted
proposal/rejected
pr/wip
pull-request
Mirrored from GitHub Pull Request
 reviewed/wontfix
💰 Rewarded
skip-changelog
status/blocked
topic/accessibility
topic/api
topic/authentication
topic/build
topic/code-linting
topic/commit-signing
topic/content-rendering
topic/deployment
topic/distribution
topic/federation
topic/gitea-actions
topic/issues
topic/lfs
topic/mobile
topic/moderation
topic/packages
topic/pr
topic/projects
topic/repo
topic/repo-migration
topic/security
topic/theme
topic/ui
topic/ui-interaction
topic/ux
topic/webhooks
topic/wiki
type/bug
type/deprecation
type/docs
type/enhancement
type/feature
type/miscellaneous
type/proposal
type/question
type/refactoring
type/summary
type/testing
type/upstream
No Label type/enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4940
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?