Commenting and closing an issue at the same time button #4938

Closed
opened 2025-11-02 06:08:18 -06:00 by GiteaMirror · 4 comments
Owner

Originally created by @aha999 on GitHub (Feb 26, 2020).

www.codeberg.org uses Gitea so i thought i can comment here on the issue.
When you want to make a comment and close the issue with that, there's only "close" next to the comment button. I think it would be better if the option was renamed to "comment & close" so we know it's going to post a comment and then close the issue (if there is text in the comment field already). Or maybe have three options.
With only Close option some can get confused if it's going to comment and then close, or just close.

DCDZw94595

Github method:
A7Q67sS68H

Originally created by @aha999 on GitHub (Feb 26, 2020). www.codeberg.org uses Gitea so i thought i can comment here on the issue. When you want to make a comment and close the issue with that, there's only "close" next to the comment button. I think it would be better if the option was renamed to "comment & close" so we know it's going to post a comment and then close the issue (if there is text in the comment field already). Or maybe have three options. With only Close option some can get confused if it's going to comment and then close, or just close. ![DCDZw94595](https://user-images.githubusercontent.com/50620416/75304130-def67100-5842-11ea-9eea-a19f7e0aa076.png) Github method: ![A7Q67sS68H](https://user-images.githubusercontent.com/50620416/75351082-d1bf9d80-58a7-11ea-81ef-6dd3d928383f.gif)
GiteaMirror added the topic/uitype/proposal labels 2025-11-02 06:08:18 -06:00
Author
Owner

@JVimes commented on GitHub (Feb 24, 2023):

@guillep2k #14407 says this feature exists. This might be "bug fix" instead of proposal?

@JVimes commented on GitHub (Feb 24, 2023): @guillep2k #14407 says this feature exists. This might be "bug fix" instead of proposal?
Author
Owner

@wxiaoguang commented on GitHub (Feb 25, 2023):

Not a bug fix, but the missing code for new editor, the new editor didn't support that .....

Will be fixed by #23135

@wxiaoguang commented on GitHub (Feb 25, 2023): ~~Not a bug fix~~, but the missing code for new editor, the new editor didn't support that ..... Will be fixed by #23135
Author
Owner

@guillep2k commented on GitHub (Feb 25, 2023):

@guillep2k #14407 says this feature exists. This might be "bug fix" instead of proposal?

Ha! Is time going backwards?

@guillep2k commented on GitHub (Feb 25, 2023): > @guillep2k #14407 says this feature exists. This might be "bug fix" instead of proposal? Ha! Is time going backwards?
Author
Owner

@wxiaoguang commented on GitHub (Feb 25, 2023):

The "existing" feature for rich editor is a hacky patch, it doesn't work well with real rich editors, so it got broken later.

EasyMDE/CodeMirror need to handle the onChange event.

@wxiaoguang commented on GitHub (Feb 25, 2023): The "existing" feature for rich editor is a hacky patch, it doesn't work well with real rich editors, so it got broken later. EasyMDE/CodeMirror need to handle the `onChange` event.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4938