Better logic for handling of filenames with # in them when generating links in markdown #4866

New Issue

GiteaMirror · 2025-11-02T06:05:22-06:00

GiteaMirror commented

2025-11-02 06:05:22 -06:00

Originally created by @mrsdizzie on GitHub (Feb 16, 2020).

Right now there are a few bugs trying to turn relative links with a # in them into valid links using our various parsers. This is a combination of assuming anything that starts with a # is an anchor in goldmark.go and not escaping the filename in util.URLJoin.

Some test cases to fix for reference:

https://try.gitea.io/mrsdizzie/testcase/src/branch/master/%231readme.md
https://try.gitea.io/mrsdizzie/testcase/src/branch/master/my%231readme.md

Originally created by @mrsdizzie on GitHub (Feb 16, 2020). Right now there are a few bugs trying to turn relative links with a ```#``` in them into valid links using our various parsers. This is a combination of assuming anything that starts with a # is an anchor in goldmark.go and not escaping the filename in util.URLJoin. Some test cases to fix for reference: https://try.gitea.io/mrsdizzie/testcase/src/branch/master/%231readme.md https://try.gitea.io/mrsdizzie/testcase/src/branch/master/my%231readme.md

GiteaMirror added the type/enhancement issue/stale labels 2025-11-02 06:05:22 -06:00

GiteaMirror closed this issue

2025-11-02 06:05:22 -06:00

GiteaMirror commented

2025-11-02 06:05:23 -06:00

@stale[bot] commented on GitHub (Apr 17, 2020):

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale[bot] commented on GitHub (Apr 17, 2020): This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

GiteaMirror commented

2025-11-02 06:05:23 -06:00

@stale[bot] commented on GitHub (May 1, 2020):

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale[bot] commented on GitHub (May 1, 2020): This issue has been automatically closed because of inactivity. You can re-open it if needed.

GiteaMirror referenced this issue

2025-11-02 13:53:16 -06:00

[PR #4866] [MERGED] Punctuation changes in documentation #17528

Sign in to join this conversation.