[UI] Dont Display File-Conflicts on merged pulls #4812

Closed
opened 2025-11-02 06:03:35 -06:00 by GiteaMirror · 6 comments
Owner

Originally created by @6543 on GitHub (Feb 8, 2020).

gitea version: 1.12.0+dev-251-g d4096ab6a
test url: https://gitea.com/gitea/go-sdk/pulls?q=&type=all&sort=&state=closed&labels=&milestone=0&assignee=0

Bildschirmfoto zu 2020-02-08 12-40-37

Originally created by @6543 on GitHub (Feb 8, 2020). gitea version: 1.12.0+dev-251-g d4096ab6a test url: https://gitea.com/gitea/go-sdk/pulls?q=&type=all&sort=&state=closed&labels=&milestone=0&assignee=0 ![Bildschirmfoto zu 2020-02-08 12-40-37](https://user-images.githubusercontent.com/24977596/74084547-8700f180-4a70-11ea-931b-09cf1f4848a9.png)
Author
Owner

@bagasme commented on GitHub (Feb 8, 2020):

I disagree.

Should be still on status quo because this informs PR openers to solve the conflicts sooner, given the file count.

@bagasme commented on GitHub (Feb 8, 2020): I disagree. Should be still on status quo because this informs PR openers to solve the conflicts sooner, given the file count.
Author
Owner

@6543 commented on GitHub (Feb 8, 2020):

@bagasme of ALREADY merged pulls ?!?

@6543 commented on GitHub (Feb 8, 2020): @bagasme of **ALREADY** merged pulls ?!?
Author
Owner

@bagasme commented on GitHub (Feb 8, 2020):

@6543 AHA! I don't see the context.

Anyway, conflicted files count should only on open PRs, not closed one...

@bagasme commented on GitHub (Feb 8, 2020): @6543 AHA! I don't see the context. Anyway, conflicted files count should only on open PRs, not closed one...
Author
Owner

@6543 commented on GitHub (Feb 8, 2020):

conflicted files count should only on open PRs, not closed one...

thats exactly what I suggest (mine is more explisit: on merged one ...)

@6543 commented on GitHub (Feb 8, 2020): > conflicted files count should only on open PRs, not closed one... thats exactly what I suggest (mine is more explisit: on merged one ...)
Author
Owner

@guillep2k commented on GitHub (Feb 8, 2020):

This is not only a UI problem. My question is: why are these values even calculated for merged PRs? PRs can't be re-opened AFAIK.

@guillep2k commented on GitHub (Feb 8, 2020): This is not only a UI problem. My question is: why are these values even calculated for merged PRs? PRs can't be re-opened AFAIK.
Author
Owner

@zeripath commented on GitHub (Feb 9, 2020):

If I could get #10132 to work after the latest more enforce locking generating the conflicted files should stop happening.

@zeripath commented on GitHub (Feb 9, 2020): If I could get #10132 to work after the latest more enforce locking generating the conflicted files should stop happening.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/gitea#4812