Commits and pull files #47

@bkcsoft commented on GitHub (Nov 9, 2016):

well, If we implement comments on commits we should get this "for free" 🙂

@bkcsoft commented on GitHub (Nov 9, 2016): well, If we implement `comments on commits` we should get this "for free" :slightly_smiling_face:

GiteaMirror commented

@metalmatze commented on GitHub (Nov 9, 2016):

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

@metalmatze commented on GitHub (Nov 9, 2016): I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit. But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

GiteaMirror commented

@lunny commented on GitHub (Nov 10, 2016):

Yes, comment on commits.

@lunny commented on GitHub (Nov 10, 2016): Yes, comment on commits.

GiteaMirror commented

@bkcsoft commented on GitHub (Dec 6, 2016):

I can probably make a proof of concept for this sometime during the weekend or next week

@bkcsoft commented on GitHub (Dec 6, 2016): I can probably make a proof of concept for this sometime during the weekend or next week

GiteaMirror commented

@lunny commented on GitHub (Jan 26, 2017):

@bkcsoft any update?

@lunny commented on GitHub (Jan 26, 2017): @bkcsoft any update?

GiteaMirror commented

@strk commented on GitHub (Jan 26, 2017):

Aren't we going to do this with git-appraise ? See #733

@strk commented on GitHub (Jan 26, 2017): Aren't we going to do this with git-appraise ? See #733

GiteaMirror commented

@sokolovstas commented on GitHub (Jan 26, 2017):

I can look at this, but this will be not so fast

@sokolovstas commented on GitHub (Jan 26, 2017): I can look at this, but this will be not so fast

GiteaMirror commented

@lunny commented on GitHub (Feb 14, 2017):

Move this v1.2 since #733 has moved.

@lunny commented on GitHub (Feb 14, 2017): Move this v1.2 since #733 has moved.

GiteaMirror commented

@lunny commented on GitHub (Feb 14, 2017):

I have tried to do something. Comments on PR is not the same as comments on commits. These are two similar PRs. For comments on PR, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

@lunny commented on GitHub (Feb 14, 2017): I have tried to do something. `Comments on PR` is not the same as `comments on commits`. These are two similar PRs. For `comments on PR`, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for `comments on commits`, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

GiteaMirror commented

@lcges commented on GitHub (Sep 12, 2017):

I send the draft as seen to comment on the code.
For some time I will show demo work.

@lcges commented on GitHub (Sep 12, 2017): I send the draft as seen to comment on the code. For some time I will show demo work. ![1](https://user-images.githubusercontent.com/19255071/30315213-752c5512-97a3-11e7-9b75-f6d1679d5a99.png)

GiteaMirror commented

@lcges commented on GitHub (Sep 22, 2017):

Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept

gitea_comment_code.zip

@lcges commented on GitHub (Sep 22, 2017): Hello. I send you a preview of the model of action. This is a static implementation - proof of concept [gitea_comment_code.zip](https://github.com/go-gitea/gitea/files/1324115/gitea.zip)

GiteaMirror commented

@daviian commented on GitHub (Sep 22, 2017):

@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

@daviian commented on GitHub (Sep 22, 2017): @qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

GiteaMirror commented

@lcges commented on GitHub (Sep 22, 2017):

gitea_c_o_c.zip

I send updated versions.
I'm waiting for comments on this.

@lcges commented on GitHub (Sep 22, 2017): [gitea_c_o_c.zip](https://github.com/go-gitea/gitea/files/1324606/gitea.1.zip) I send updated versions. I'm waiting for comments on this. ![pasted image at 2017_09_22 03_04 pm](https://user-images.githubusercontent.com/19255071/30745729-973e905a-9fa7-11e7-8927-5ceafb2f8353.png)

GiteaMirror commented

@lunny commented on GitHub (Sep 22, 2017):

@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

@lunny commented on GitHub (Sep 22, 2017): @qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

GiteaMirror commented

@lunny commented on GitHub (Sep 22, 2017):

@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

@lunny commented on GitHub (Sep 22, 2017): @qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

GiteaMirror commented

@lunny commented on GitHub (Sep 23, 2017):

@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

@lunny commented on GitHub (Sep 23, 2017): @qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

GiteaMirror commented

2025-11-02 03:05:51 -06:00

@lcges commented on GitHub (Sep 25, 2017):

no problem. I will do what I need
I'll take your code and I'm already working on the correct code.

@lcges commented on GitHub (Sep 25, 2017): no problem. I will do what I need I'll take your code and I'm already working on the correct code. ![pasted image at 2017_09_25 08_30 am](https://user-images.githubusercontent.com/19255071/30795258-f8360e16-a1cc-11e7-8a93-3a4cb514af2f.png) ![pasted image at 2017_09_25 08_35 am](https://user-images.githubusercontent.com/19255071/30795259-f8360088-a1cc-11e7-900d-aae3cf83f63b.png)

GiteaMirror commented

@tonivj5 commented on GitHub (Sep 25, 2017):

@qdbdbp, what tool do you use to do those designs? 😅

@tonivj5 commented on GitHub (Sep 25, 2017): @qdbdbp, what tool do you use to do those designs? :sweat_smile:

GiteaMirror commented

2025-11-02 03:05:53 -06:00

@lcges commented on GitHub (Sep 25, 2017):

hi. I use it for quick drafts this tool:

https://mockflow.com/

@lcges commented on GitHub (Sep 25, 2017): hi. I use it for quick drafts this tool: https://mockflow.com/

GiteaMirror commented

@bclermont commented on GitHub (Mar 13, 2018):

I don't mind to pay to have this feature... how much? who?

@bclermont commented on GitHub (Mar 13, 2018): I don't mind to pay to have this feature... how much? who?

GiteaMirror commented

@lunny commented on GitHub (Mar 13, 2018):

@bclermont we already have a wip pull request #2583.

@lunny commented on GitHub (Mar 13, 2018): @bclermont we already have a wip pull request #2583.

GiteaMirror commented

@bclermont commented on GitHub (Mar 13, 2018):

@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

@bclermont commented on GitHub (Mar 13, 2018): @lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

GiteaMirror commented

@lunny commented on GitHub (Mar 13, 2018):

You could use https://www.bountysource.com/teams/go-gitea

@lunny commented on GitHub (Mar 13, 2018): You could use https://www.bountysource.com/teams/go-gitea

GiteaMirror commented

@techknowlogick commented on GitHub (Mar 14, 2018):

@lunny thanks for posting that link. I added to the bounty.

@techknowlogick commented on GitHub (Mar 14, 2018): @lunny thanks for posting that link. I added to the bounty.

GiteaMirror commented

@cobbzilla commented on GitHub (Mar 28, 2018):

Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

@cobbzilla commented on GitHub (Mar 28, 2018): Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the *only* feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

GiteaMirror commented

@bclermont commented on GitHub (Mar 29, 2018):

I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

@bclermont commented on GitHub (Mar 29, 2018): I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

GiteaMirror commented

@rc1021 commented on GitHub (May 4, 2018):

Are there things to follow?

@rc1021 commented on GitHub (May 4, 2018): Are there things to follow?

GiteaMirror commented